From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Prashant Gaikwad
<pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] clk: tegra: Mark APB clock as critical
Date: Thu, 30 Nov 2017 19:53:46 +0300 [thread overview]
Message-ID: <6378f92d-54a9-590a-5fdb-88a7bfa96fc1@gmail.com> (raw)
In-Reply-To: <43e293c3-daf2-7b2e-2524-f14de3811f44-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 30.11.2017 19:51, Jon Hunter wrote:
>
> On 30/11/17 16:45, Dmitry Osipenko wrote:
>> On 30.11.2017 19:39, Jon Hunter wrote:
>>>
>>> On 30/11/17 13:24, Dmitry Osipenko wrote:
>>>> On 30.11.2017 14:31, Jon Hunter wrote:
>>>>>
>>>>> On 29/11/17 23:13, Dmitry Osipenko wrote:
>>>>>> On 30.11.2017 01:55, Jon Hunter wrote:
>>>>>
>>>>> ...
>>>>>
>>>>>> I've asked you to re-test Tegra114/124 or whatever was failing for you with the
>>>>>> PLL_M being marked as critical instead of PCLK. Maybe it was PLL_M that actually
>>>>>> caused trouble on Tegra114/124.
>>>>>
>>>>> Please share the exact change you would like me to test and I will.
>>>>
>>>> Please try this:
>>>
>>> I tried the patch, but this does not work for Tegra124 it still hangs.
>>> Tracing the clk calls the last thing I see is ...
>>>
>>> [ 2.687846] tegra124-dfll 70110000.clock: couldn't get vdd_cpu regulator
>>> [ 2.694403] clk_prepare: hclk_div
>>> [ 2.695929] clk_prepare_complete: hclk_div
>>> [ 2.700027] clk_prepare: hclk
>>> [ 2.702947] clk_prepare_complete: hclk
>>> [ 2.706673] clk_prepare: pclk_div
>>> [ 2.709986] clk_prepare_complete: pclk_div
>>> [ 2.714039] clk_prepare: pclk
>>> [ 2.716985] clk_prepare_complete: pclk
>>> [ 2.720739] clk_prepare: apbdma
>>> [ 2.723833] clk_prepare_complete: apbdma
>>> [ 2.727736] clk_enable: hclk_div
>>> [ 2.730940] clk_enable_complete: hclk_div
>>> [ 2.734926] clk_enable: hclk
>>> [ 2.737788] clk_enable_complete: hclk
>>> [ 2.741426] clk_enable: pclk_div
>>> [ 2.744633] clk_enable_complete: pclk_div
>>> [ 2.748619] clk_enable: pclk
>>> [ 2.751481] clk_enable_complete: pclk
>>> [ 2.755120] clk_enable: apbdma
>>> [ 2.758153] clk_enable_complete: apbdma
>>> [ 2.762390] clk_disable: apbdma
>>> [ 2.765088] clk_disable_complete: apbdma
>>> [ 2.768986] clk
>>>
>>> So I believe this change is correct and that Peter's analysis on IRC
>>> seems correct, that this change has exposed another issue with the clock
>>> driver.
>>>
>>
>> Could you please show the /sys/kernel/debug/clk/clk_summary?
>
> With what patches present?
>
linux-next without any additional patches
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] clk: tegra: Mark APB clock as critical
Date: Thu, 30 Nov 2017 19:53:46 +0300 [thread overview]
Message-ID: <6378f92d-54a9-590a-5fdb-88a7bfa96fc1@gmail.com> (raw)
In-Reply-To: <43e293c3-daf2-7b2e-2524-f14de3811f44@nvidia.com>
On 30.11.2017 19:51, Jon Hunter wrote:
>
> On 30/11/17 16:45, Dmitry Osipenko wrote:
>> On 30.11.2017 19:39, Jon Hunter wrote:
>>>
>>> On 30/11/17 13:24, Dmitry Osipenko wrote:
>>>> On 30.11.2017 14:31, Jon Hunter wrote:
>>>>>
>>>>> On 29/11/17 23:13, Dmitry Osipenko wrote:
>>>>>> On 30.11.2017 01:55, Jon Hunter wrote:
>>>>>
>>>>> ...
>>>>>
>>>>>> I've asked you to re-test Tegra114/124 or whatever was failing for you with the
>>>>>> PLL_M being marked as critical instead of PCLK. Maybe it was PLL_M that actually
>>>>>> caused trouble on Tegra114/124.
>>>>>
>>>>> Please share the exact change you would like me to test and I will.
>>>>
>>>> Please try this:
>>>
>>> I tried the patch, but this does not work for Tegra124 it still hangs.
>>> Tracing the clk calls the last thing I see is ...
>>>
>>> [ 2.687846] tegra124-dfll 70110000.clock: couldn't get vdd_cpu regulator
>>> [ 2.694403] clk_prepare: hclk_div
>>> [ 2.695929] clk_prepare_complete: hclk_div
>>> [ 2.700027] clk_prepare: hclk
>>> [ 2.702947] clk_prepare_complete: hclk
>>> [ 2.706673] clk_prepare: pclk_div
>>> [ 2.709986] clk_prepare_complete: pclk_div
>>> [ 2.714039] clk_prepare: pclk
>>> [ 2.716985] clk_prepare_complete: pclk
>>> [ 2.720739] clk_prepare: apbdma
>>> [ 2.723833] clk_prepare_complete: apbdma
>>> [ 2.727736] clk_enable: hclk_div
>>> [ 2.730940] clk_enable_complete: hclk_div
>>> [ 2.734926] clk_enable: hclk
>>> [ 2.737788] clk_enable_complete: hclk
>>> [ 2.741426] clk_enable: pclk_div
>>> [ 2.744633] clk_enable_complete: pclk_div
>>> [ 2.748619] clk_enable: pclk
>>> [ 2.751481] clk_enable_complete: pclk
>>> [ 2.755120] clk_enable: apbdma
>>> [ 2.758153] clk_enable_complete: apbdma
>>> [ 2.762390] clk_disable: apbdma
>>> [ 2.765088] clk_disable_complete: apbdma
>>> [ 2.768986] clk
>>>
>>> So I believe this change is correct and that Peter's analysis on IRC
>>> seems correct, that this change has exposed another issue with the clock
>>> driver.
>>>
>>
>> Could you please show the /sys/kernel/debug/clk/clk_summary?
>
> With what patches present?
>
linux-next without any additional patches
next prev parent reply other threads:[~2017-11-30 16:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 11:12 [PATCH] clk: tegra: Mark APB clock as critical Jon Hunter
2017-10-23 11:12 ` Jon Hunter
[not found] ` <1508757172-13030-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-10-23 11:57 ` Peter De Schrijver
2017-10-23 11:57 ` Peter De Schrijver
2017-11-28 23:30 ` Dmitry Osipenko
[not found] ` <18f57c1f-add0-908a-6a26-7cc81f29d7d9-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-29 0:09 ` Dmitry Osipenko
2017-11-29 0:09 ` Dmitry Osipenko
[not found] ` <f940d9f1-aaec-cf25-24d2-956df63bbbd1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-29 10:12 ` Jon Hunter
2017-11-29 10:12 ` Jon Hunter
2017-11-29 15:08 ` Dmitry Osipenko
[not found] ` <95c14859-a2c7-1c61-adba-bd6c16155c01-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-29 22:55 ` Jon Hunter
2017-11-29 22:55 ` Jon Hunter
2017-11-29 23:13 ` Dmitry Osipenko
[not found] ` <a96d03da-c2a3-1e44-f227-02577f972df6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-30 11:31 ` Jon Hunter
2017-11-30 11:31 ` Jon Hunter
2017-11-30 13:24 ` Dmitry Osipenko
[not found] ` <6264cf17-0850-37dd-ca92-9362521d2db6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-30 16:39 ` Jon Hunter
2017-11-30 16:39 ` Jon Hunter
[not found] ` <236aa250-3b9b-94de-0978-0fb8546d504d-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-11-30 16:45 ` Dmitry Osipenko
2017-11-30 16:45 ` Dmitry Osipenko
2017-11-30 16:51 ` Jon Hunter
2017-11-30 16:51 ` Jon Hunter
[not found] ` <43e293c3-daf2-7b2e-2524-f14de3811f44-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2017-11-30 16:53 ` Dmitry Osipenko [this message]
2017-11-30 16:53 ` Dmitry Osipenko
[not found] ` <6378f92d-54a9-590a-5fdb-88a7bfa96fc1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-11-30 17:22 ` Jon Hunter
2017-11-30 17:22 ` Jon Hunter
2017-11-30 17:49 ` Dmitry Osipenko
2017-12-01 8:48 ` Peter De Schrijver
2017-12-01 8:48 ` Peter De Schrijver
2017-12-02 12:47 ` Dmitry Osipenko
[not found] ` <803890bc-e3fe-134a-2127-3363187d04f2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-05 9:06 ` Peter De Schrijver
2017-12-05 9:06 ` Peter De Schrijver
[not found] ` <20171205090635.GL32106-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2017-12-05 18:22 ` Dmitry Osipenko
2017-12-05 18:22 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6378f92d-54a9-590a-5fdb-88a7bfa96fc1@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.