All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: of: Fix the driver and actually compile the 8250_of
Date: Fri, 18 Dec 2015 13:52:33 +0100	[thread overview]
Message-ID: <6383189.zS3XQNVGho@wuerfel> (raw)
In-Reply-To: <1450442612-11372-1-git-send-email-peter.ujfalusi@ti.com>

On Friday 18 December 2015 14:43:32 Peter Ujfalusi wrote:
> The 8250_of never compiled since in the Kconfig we have SERIAL_OF_PLATFORM
> but in the makefile we expect to have SERIAL_8250_OF...
> 
> In the Kconfig keep the SERIAL_OF_PLATFORM for compatibility reasons and
> let it select the SERIAL_8250_OF. Later we can replace the
> SERIAL_OF_PLATFORM use in defconfigs to SERIAL_8250_OF.
> 
> When the 8250_of.c is actually compiled we will have two errors:
> missing linux/nwpserial.h and 8250/8250.h.
> Fix those as well at the same time when enable the compilation of the
> driver.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Fixes: afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory")
> CC: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks for the report. Indeed this could not have worked.

> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index b03cb5175113..01f24613b0e6 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -379,6 +379,11 @@ config SERIAL_8250_MID
>           Intel platforms.
>  
>  config SERIAL_OF_PLATFORM
> +       tristate
> +       depends on SERIAL_8250 && OF
> +       select SERIAL_8250_OF
> +
> +config SERIAL_8250_OF
>         tristate "Devicetree based probing for 8250 ports"
>         depends on SERIAL_8250 && OF
>         help

This will still require changing all the defconfigs, as SERIAL_OF_PLATFORM
is a silent option now. I think it's better to change the Makefile and
leave the slightly odd Kconfig symbol name.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: 8250: of: Fix the driver and actually compile the 8250_of
Date: Fri, 18 Dec 2015 13:52:33 +0100	[thread overview]
Message-ID: <6383189.zS3XQNVGho@wuerfel> (raw)
In-Reply-To: <1450442612-11372-1-git-send-email-peter.ujfalusi@ti.com>

On Friday 18 December 2015 14:43:32 Peter Ujfalusi wrote:
> The 8250_of never compiled since in the Kconfig we have SERIAL_OF_PLATFORM
> but in the makefile we expect to have SERIAL_8250_OF...
> 
> In the Kconfig keep the SERIAL_OF_PLATFORM for compatibility reasons and
> let it select the SERIAL_8250_OF. Later we can replace the
> SERIAL_OF_PLATFORM use in defconfigs to SERIAL_8250_OF.
> 
> When the 8250_of.c is actually compiled we will have two errors:
> missing linux/nwpserial.h and 8250/8250.h.
> Fix those as well at the same time when enable the compilation of the
> driver.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Fixes: afd7f88f1577 ("serial: 8250: move of_serial code to 8250 directory")
> CC: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks for the report. Indeed this could not have worked.

> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index b03cb5175113..01f24613b0e6 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -379,6 +379,11 @@ config SERIAL_8250_MID
>           Intel platforms.
>  
>  config SERIAL_OF_PLATFORM
> +       tristate
> +       depends on SERIAL_8250 && OF
> +       select SERIAL_8250_OF
> +
> +config SERIAL_8250_OF
>         tristate "Devicetree based probing for 8250 ports"
>         depends on SERIAL_8250 && OF
>         help

This will still require changing all the defconfigs, as SERIAL_OF_PLATFORM
is a silent option now. I think it's better to change the Makefile and
leave the slightly odd Kconfig symbol name.

	Arnd

  reply	other threads:[~2015-12-18 12:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 12:43 [PATCH] serial: 8250: of: Fix the driver and actually compile the 8250_of Peter Ujfalusi
2015-12-18 12:43 ` Peter Ujfalusi
2015-12-18 12:43 ` Peter Ujfalusi
2015-12-18 12:52 ` Arnd Bergmann [this message]
2015-12-18 12:52   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6383189.zS3XQNVGho@wuerfel \
    --to=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.