All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
	<nvdimm@lists.linux.dev>
Cc: <dan.j.williams@intel.com>, <jmoyer@redhat.com>,
	<vishal.l.verma@intel.com>
Subject: Re: [ndctl PATCH v3 1/4] ndctl: add CXL bus detection
Date: Fri, 16 Dec 2022 10:44:17 -0800	[thread overview]
Message-ID: <639cbc81606a8_b05d1294d0@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <f804d081-abb9-cb46-e14f-a37f3ac63f21@intel.com>

Dave Jiang wrote:
> 
> 
> On 12/16/2022 10:21 AM, Dave Jiang wrote:
> > Add a CXL bus type, and detect whether a 'dimm' is backed by the CXL
> > subsystem.
> > 
> > Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > 
> > ---
> > v3:
> > - Simplify detecting cxl subsystem. (Dan)
> > v2:
> > - Improve commit log. (Vishal)
> > ---
> >   ndctl/lib/libndctl.c   |   30 ++++++++++++++++++++++++++++++
> >   ndctl/lib/libndctl.sym |    1 +
> >   ndctl/lib/private.h    |    1 +
> >   ndctl/libndctl.h       |    1 +
> >   4 files changed, 33 insertions(+)
> > 
> > diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
> > index ad54f0626510..9cd5340b5702 100644
> > --- a/ndctl/lib/libndctl.c
> > +++ b/ndctl/lib/libndctl.c
> > @@ -12,6 +12,7 @@
> >   #include <ctype.h>
> >   #include <fcntl.h>
> >   #include <dirent.h>
> > +#include <libgen.h>
> 
> Of course I missed removing this change.

With this fixed up feel free to add:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

...for the series.

  reply	other threads:[~2022-12-16 18:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 22:00 [ndctl PATCH v2 0/4] ndctl: Add security test for cxl devices through nvdimm Dave Jiang
2022-12-14 22:00 ` [ndctl PATCH v2 1/4] ndctl: add CXL bus detection Dave Jiang
2022-12-15 20:38   ` Dan Williams
2022-12-15 21:18     ` Jeff Moyer
2022-12-15 22:27       ` Dan Williams
2022-12-16 17:21         ` [ndctl PATCH v3 " Dave Jiang
2022-12-16 17:23           ` Dave Jiang
2022-12-16 18:44             ` Dan Williams [this message]
2023-01-04 20:30             ` [ndctl PATCH v4 " Dave Jiang
2022-12-14 22:00 ` [ndctl PATCH v2 2/4] ndctl/libndctl: Add bus_prefix for CXL Dave Jiang
2022-12-14 22:00 ` [ndctl PATCH v2 3/4] ndctl/libndctl: Allow retrievng of unique_id for CXL mem dev Dave Jiang
2022-12-14 22:00 ` [ndctl PATCH v2 4/4] ndctl/test: Add CXL test for security Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=639cbc81606a8_b05d1294d0@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.