From: Changwei Ge <ge.changwei@h3c.com> To: "ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>, Mark Fasheh <mfasheh@versity.com>, Junxiao Bi <junxiao.bi@oracle.com>, Joseph Qi <jiangqi903@gmail.com>, Joel Becker <jlbec@evilplan.org> Cc: Vitaly Mayatskih <v.mayatskih@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org> Subject: [PATCH] ocfs2: fix cluster hang after a node dies Date: Tue, 17 Oct 2017 06:48:21 +0000 [thread overview] Message-ID: <63ADC13FD55D6546B7DECE290D39E373CED6E0F9@H3CMLB14-EX.srv.huawei-3com.com> (raw) When a node dies, other live nodes have to choose a new master for an existed lock resource mastered by the dead node. As for ocfs2/dlm implementation, this is done by function - dlm_move_lockres_to_recovery_list which marks those lock rsources as DLM_LOCK_RES_RECOVERING and manages them via a list from which DLM changes lock resource's master later. So without invoking dlm_move_lockres_to_recovery_list, no master will be choosed after dlm recovery accomplishment since no lock resource can be found through ::resource list. What's worse is that if DLM_LOCK_RES_RECOVERING is not marked for lock resources mastered a dead node, it will break up synchronization among nodes. So invoke dlm_move_lockres_to_recovery_list again. Fixs: 'commit ee8f7fcbe638 ("ocfs2/dlm: continue to purge recovery lockres when recovery master goes down")' Reported-by: Vitaly Mayatskih <v.mayatskih@gmail.com> Signed-off-by: Changwei Ge <ge.changwei@h3c.com> --- fs/ocfs2/dlm/dlmrecovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index 74407c6..ec8f758 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++ b/fs/ocfs2/dlm/dlmrecovery.c @@ -2419,6 +2419,7 @@ static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node) dlm_lockres_put(res); continue; } + dlm_move_lockres_to_recovery_list(dlm, res); } else if (res->owner == dlm->node_num) { dlm_free_dead_locks(dlm, res, dead_node); __dlm_lockres_calc_usage(dlm, res); -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Changwei Ge <ge.changwei@h3c.com> To: "ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>, Mark Fasheh <mfasheh@versity.com>, Junxiao Bi <junxiao.bi@oracle.com>, Joseph Qi <jiangqi903@gmail.com>, Joel Becker <jlbec@evilplan.org> Cc: Vitaly Mayatskih <v.mayatskih@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org> Subject: [Ocfs2-devel] [PATCH] ocfs2: fix cluster hang after a node dies Date: Tue, 17 Oct 2017 06:48:21 +0000 [thread overview] Message-ID: <63ADC13FD55D6546B7DECE290D39E373CED6E0F9@H3CMLB14-EX.srv.huawei-3com.com> (raw) When a node dies, other live nodes have to choose a new master for an existed lock resource mastered by the dead node. As for ocfs2/dlm implementation, this is done by function - dlm_move_lockres_to_recovery_list which marks those lock rsources as DLM_LOCK_RES_RECOVERING and manages them via a list from which DLM changes lock resource's master later. So without invoking dlm_move_lockres_to_recovery_list, no master will be choosed after dlm recovery accomplishment since no lock resource can be found through ::resource list. What's worse is that if DLM_LOCK_RES_RECOVERING is not marked for lock resources mastered a dead node, it will break up synchronization among nodes. So invoke dlm_move_lockres_to_recovery_list again. Fixs: 'commit ee8f7fcbe638 ("ocfs2/dlm: continue to purge recovery lockres when recovery master goes down")' Reported-by: Vitaly Mayatskih <v.mayatskih@gmail.com> Signed-off-by: Changwei Ge <ge.changwei@h3c.com> --- fs/ocfs2/dlm/dlmrecovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index 74407c6..ec8f758 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++ b/fs/ocfs2/dlm/dlmrecovery.c @@ -2419,6 +2419,7 @@ static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node) dlm_lockres_put(res); continue; } + dlm_move_lockres_to_recovery_list(dlm, res); } else if (res->owner == dlm->node_num) { dlm_free_dead_locks(dlm, res, dead_node); __dlm_lockres_calc_usage(dlm, res); -- 1.7.9.5
next reply other threads:[~2017-10-17 6:50 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-17 6:48 Changwei Ge [this message] 2017-10-17 6:48 ` [Ocfs2-devel] [PATCH] ocfs2: fix cluster hang after a node dies Changwei Ge 2017-10-17 14:28 ` Vitaly Mayatskikh 2017-10-18 8:17 ` [Ocfs2-devel] " piaojun 2017-10-18 8:17 ` piaojun 2017-10-18 8:42 ` Changwei Ge 2017-10-18 8:42 ` Changwei Ge 2017-10-18 11:37 ` Vitaly Mayatskikh 2017-10-18 9:09 ` piaojun 2017-10-18 9:09 ` piaojun 2017-10-23 3:51 ` Joseph Qi 2017-10-23 3:51 ` [Ocfs2-devel] " Joseph Qi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=63ADC13FD55D6546B7DECE290D39E373CED6E0F9@H3CMLB14-EX.srv.huawei-3com.com \ --to=ge.changwei@h3c.com \ --cc=akpm@linux-foundation.org \ --cc=jiangqi903@gmail.com \ --cc=jlbec@evilplan.org \ --cc=junxiao.bi@oracle.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=mfasheh@versity.com \ --cc=ocfs2-devel@oss.oracle.com \ --cc=v.mayatskih@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.