All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu Ionescu <ilg@livius.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] segmentation fault in object.c:type_initialize_interface() if interface not defined
Date: Sun, 3 Apr 2016 20:56:30 +0300	[thread overview]
Message-ID: <63AEB8A6-929B-48B2-B6D1-13FC80F8888F@livius.net> (raw)
In-Reply-To: <CAFEAcA9M1Bgp72uKHVWxUORtCgi7s-hcbx5V_o7ggdiHtakFTQ@mail.gmail.com>


> On 03 Apr 2016, at 20:01, Peter Maydell <peter.maydell@linaro.org> wrote:
> 
> ... This is you changing QEMU to not compile a file that was
> previously always compiled. If you do that then it's
> not surprising if things might break when you move to an
> upstream version, that's all.

well, to summarise, I notified you that in certain conditions, due to an non-obvious dependency that does not break the build when not met, the existing code crashes at run time with a segmentation fault, and I suggested that an assert might help developers to save some debugging time. 

if you want to add this assert, ok; if you don't, and prefer to permanently blame my fork for various reasons, it's also fine, I don't mind, I fix it in my fork and move forward.


regards,

Liviu

  reply	other threads:[~2016-04-03 17:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02 22:15 [Qemu-devel] segmentation fault in object.c:type_initialize_interface() if interface not defined Liviu Ionescu
2016-04-03 12:28 ` Peter Maydell
2016-04-03 15:40   ` Liviu Ionescu
2016-04-03 16:43     ` Peter Maydell
2016-04-03 16:57       ` Liviu Ionescu
2016-04-03 17:01         ` Peter Maydell
2016-04-03 17:56           ` Liviu Ionescu [this message]
2016-04-03 21:30             ` Peter Maydell
2016-04-03 21:42               ` Liviu Ionescu
2016-04-03 21:59                 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63AEB8A6-929B-48B2-B6D1-13FC80F8888F@livius.net \
    --to=ilg@livius.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.