[PATCH] Move online check settings initialization to service init.

[PATCH] Move online check settings initialization to service init.

[Grant Erickson]

The connman settings "EnableOnlineToReadyTransition",
"OnlineCheckInitialInterval", and "OnlineCheckMaxInterval" do not vary
across calls to 'start_online_check'. Consequently, they can be read
and set once in '__connman_service_init'.
---
 src/service.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/service.c b/src/service.c
index 06d02322..55932efc 100644
--- a/src/service.c
+++ b/src/service.c
@@ -1460,12 +1460,6 @@ static void start_online_check(struct connman_service *service,
 			"Default service remains in READY state.");
 		return;
 	}
-	enable_online_to_ready_transition =
-		connman_setting_get_bool("EnableOnlineToReadyTransition");
-	online_check_initial_interval =
-		connman_setting_get_uint("OnlineCheckInitialInterval");
-	online_check_max_interval =
-		connman_setting_get_uint("OnlineCheckMaxInterval");
 
 	if (type == CONNMAN_IPCONFIG_TYPE_IPV6 || check_proxy_setup(service)) {
 		cancel_online_check(service);
@@ -7842,6 +7836,13 @@ int __connman_service_init(void)
 
 	remove_unprovisioned_services();
 
+	enable_online_to_ready_transition =
+		connman_setting_get_bool("EnableOnlineToReadyTransition");
+	online_check_initial_interval =
+		connman_setting_get_uint("OnlineCheckInitialInterval");
+	online_check_max_interval =
+		connman_setting_get_uint("OnlineCheckMaxInterval");
+
 	return 0;
 }
 
-- 
2.32.0

Re: [PATCH] Move online check settings initialization to service init.

[Marcel Holtmann]

Hi Grant,

> The connman settings "EnableOnlineToReadyTransition",
> "OnlineCheckInitialInterval", and "OnlineCheckMaxInterval" do not vary
> across calls to 'start_online_check'. Consequently, they can be read
> and set once in '__connman_service_init'.
> ---
> src/service.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)

patch has been applied.

Regards

Marcel