* [PATCH v2] drm/i915/bdb: Fix version check @ 2021-09-23 16:49 ` Lukasz Majczak 0 siblings, 0 replies; 6+ messages in thread From: Lukasz Majczak @ 2021-09-23 16:49 UTC (permalink / raw) To: Jose Roberto de Souza, Shawn C Lee Cc: Jani Nikula, Joonas Lahtinen, intel-gfx, dri-devel, upstream, Lukasz Majczak With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" the size of bdb_lfp_backlight_data structure has been increased, causing if-statement in the parse_lfp_backlight function that comapres this structure size to the one retrieved from BDB, always to fail for older revisions. This patch calculates expected size of the structure for a given BDB version and compares it with the value gathered from BDB. Tested on Chromebook Pixelbook (Nocturne) (reports bdb->version = 221) Tested-by: Lukasz Majczak <lma@semihalf.com> Signed-off-by: Lukasz Majczak <lma@semihalf.com> --- drivers/gpu/drm/i915/display/intel_bios.c | 11 +++++++++-- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 5 +++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index 3c25926092de..90eae6da12e0 100644 --- a/drivers/gpu/drm/i915/display/intel_bios.c +++ b/drivers/gpu/drm/i915/display/intel_bios.c @@ -428,6 +428,7 @@ parse_lfp_backlight(struct drm_i915_private *i915, const struct lfp_backlight_data_entry *entry; int panel_type = i915->vbt.panel_type; u16 level; + size_t exp_size; backlight_data = find_section(bdb, BDB_LVDS_BACKLIGHT); if (!backlight_data) @@ -450,9 +451,15 @@ parse_lfp_backlight(struct drm_i915_private *i915, return; } + if (bdb->version <= 234) + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_234; + else if (bdb->version > 234 && bdb->version <= 236) + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_236; + else + exp_size = sizeof(struct bdb_lfp_backlight_data); + i915->vbt.backlight.type = INTEL_BACKLIGHT_DISPLAY_DDI; - if (bdb->version >= 191 && - get_blocksize(backlight_data) >= sizeof(*backlight_data)) { + if (bdb->version >= 191 && get_blocksize(backlight_data) >= exp_size) { const struct lfp_backlight_control_method *method; method = &backlight_data->backlight_control[panel_type]; diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h index 330077c2e588..ba9990e5983c 100644 --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h @@ -814,6 +814,11 @@ struct lfp_brightness_level { u16 reserved; } __packed; +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_234 \ + offsetof(struct bdb_lfp_backlight_data, brightness_level) +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_236 \ + offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits) + struct bdb_lfp_backlight_data { u8 entry_size; struct lfp_backlight_data_entry data[16]; -- 2.33.0.464.g1972c5931b-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/bdb: Fix version check @ 2021-09-23 16:49 ` Lukasz Majczak 0 siblings, 0 replies; 6+ messages in thread From: Lukasz Majczak @ 2021-09-23 16:49 UTC (permalink / raw) To: Jose Roberto de Souza, Shawn C Lee Cc: Jani Nikula, Joonas Lahtinen, intel-gfx, dri-devel, upstream, Lukasz Majczak With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" the size of bdb_lfp_backlight_data structure has been increased, causing if-statement in the parse_lfp_backlight function that comapres this structure size to the one retrieved from BDB, always to fail for older revisions. This patch calculates expected size of the structure for a given BDB version and compares it with the value gathered from BDB. Tested on Chromebook Pixelbook (Nocturne) (reports bdb->version = 221) Tested-by: Lukasz Majczak <lma@semihalf.com> Signed-off-by: Lukasz Majczak <lma@semihalf.com> --- drivers/gpu/drm/i915/display/intel_bios.c | 11 +++++++++-- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 5 +++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c index 3c25926092de..90eae6da12e0 100644 --- a/drivers/gpu/drm/i915/display/intel_bios.c +++ b/drivers/gpu/drm/i915/display/intel_bios.c @@ -428,6 +428,7 @@ parse_lfp_backlight(struct drm_i915_private *i915, const struct lfp_backlight_data_entry *entry; int panel_type = i915->vbt.panel_type; u16 level; + size_t exp_size; backlight_data = find_section(bdb, BDB_LVDS_BACKLIGHT); if (!backlight_data) @@ -450,9 +451,15 @@ parse_lfp_backlight(struct drm_i915_private *i915, return; } + if (bdb->version <= 234) + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_234; + else if (bdb->version > 234 && bdb->version <= 236) + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_236; + else + exp_size = sizeof(struct bdb_lfp_backlight_data); + i915->vbt.backlight.type = INTEL_BACKLIGHT_DISPLAY_DDI; - if (bdb->version >= 191 && - get_blocksize(backlight_data) >= sizeof(*backlight_data)) { + if (bdb->version >= 191 && get_blocksize(backlight_data) >= exp_size) { const struct lfp_backlight_control_method *method; method = &backlight_data->backlight_control[panel_type]; diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h index 330077c2e588..ba9990e5983c 100644 --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h @@ -814,6 +814,11 @@ struct lfp_brightness_level { u16 reserved; } __packed; +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_234 \ + offsetof(struct bdb_lfp_backlight_data, brightness_level) +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_236 \ + offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits) + struct bdb_lfp_backlight_data { u8 entry_size; struct lfp_backlight_data_entry data[16]; -- 2.33.0.464.g1972c5931b-goog ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bdb: Fix version check (rev2) 2021-09-23 16:49 ` [Intel-gfx] " Lukasz Majczak (?) @ 2021-09-23 20:34 ` Patchwork -1 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-09-23 20:34 UTC (permalink / raw) To: Lukasz Majczak; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 5485 bytes --] == Series Details == Series: drm/i915/bdb: Fix version check (rev2) URL : https://patchwork.freedesktop.org/series/94871/ State : success == Summary == CI Bug Log - changes from CI_DRM_10632 -> Patchwork_21147 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/index.html Known issues ------------ Here are the changes found in Patchwork_21147 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@query-info: - fi-tgl-1115g4: NOTRUN -> [SKIP][1] ([fdo#109315]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@amdgpu/amd_basic@query-info.html * igt@amdgpu/amd_cs_nop@nop-gfx0: - fi-tgl-1115g4: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +16 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@amdgpu/amd_cs_nop@nop-gfx0.html * igt@gem_exec_suspend@basic-s0: - fi-tgl-u2: [PASS][3] -> [FAIL][4] ([i915#1888]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html * igt@gem_exec_suspend@basic-s3: - fi-tgl-1115g4: NOTRUN -> [FAIL][5] ([i915#1888]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s3.html * igt@gem_huc_copy@huc-copy: - fi-tgl-1115g4: NOTRUN -> [SKIP][6] ([i915#2190]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html * igt@i915_pm_backlight@basic-brightness: - fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([i915#1155]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html * igt@i915_selftest@live@gt_pm: - fi-icl-y: [PASS][8] -> [DMESG-FAIL][9] ([i915#2291]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/fi-icl-y/igt@i915_selftest@live@gt_pm.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-icl-y/igt@i915_selftest@live@gt_pm.html * igt@kms_chamelium@common-hpd-after-suspend: - fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([fdo#111827]) +8 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@kms_chamelium@common-hpd-after-suspend.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#4103]) +1 similar issue [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-1115g4: NOTRUN -> [SKIP][12] ([fdo#109285]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_psr@primary_mmap_gtt: - fi-tgl-1115g4: NOTRUN -> [SKIP][13] ([i915#1072]) +3 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html * igt@prime_vgem@basic-userptr: - fi-tgl-1115g4: NOTRUN -> [SKIP][14] ([i915#3301]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html #### Possible fixes #### * igt@kms_chamelium@hdmi-edid-read: - fi-kbl-7500u: [FAIL][15] ([i915#3449]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/fi-kbl-7500u/igt@kms_chamelium@hdmi-edid-read.html [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3449]: https://gitlab.freedesktop.org/drm/intel/issues/3449 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 Participating hosts (40 -> 34) ------------------------------ Additional (1): fi-tgl-1115g4 Missing (7): bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-4 fi-bdw-samus bat-jsl-2 bat-jsl-1 Build changes ------------- * Linux: CI_DRM_10632 -> Patchwork_21147 CI-20190529: 20190529 CI_DRM_10632: 3e62264203fbb2a56cab68878fe3415ba1e64a32 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6217: e02037bfd63fb26dd32b9e9ceb1ca131ddbf30c3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_21147: 67d3bc985158ac256c048d403d5527361bff7f50 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 67d3bc985158 drm/i915/bdb: Fix version check == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/index.html [-- Attachment #2: Type: text/html, Size: 6542 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bdb: Fix version check (rev2) 2021-09-23 16:49 ` [Intel-gfx] " Lukasz Majczak (?) (?) @ 2021-09-24 1:00 ` Patchwork -1 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-09-24 1:00 UTC (permalink / raw) To: Lukasz Majczak; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30261 bytes --] == Series Details == Series: drm/i915/bdb: Fix version check (rev2) URL : https://patchwork.freedesktop.org/series/94871/ State : success == Summary == CI Bug Log - changes from CI_DRM_10632_full -> Patchwork_21147_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_21147_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@preservation-s3@rcs0: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] ([i915#1373]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-tglb3/igt@gem_ctx_isolation@preservation-s3@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb7/igt@gem_ctx_isolation@preservation-s3@rcs0.html * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vecs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl6/igt@gem_ctx_isolation@preservation-s3@vecs0.html * igt@gem_ctx_persistence@idempotent: - shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-snb6/igt@gem_ctx_persistence@idempotent.html * igt@gem_ctx_sseu@engines: - shard-tglb: NOTRUN -> [SKIP][6] ([i915#280]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@gem_ctx_sseu@engines.html * igt@gem_eio@unwedge-stress: - shard-tglb: [PASS][7] -> [TIMEOUT][8] ([i915#2369] / [i915#3063] / [i915#3648]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-tglb5/igt@gem_eio@unwedge-stress.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb6/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-deadline: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2846]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl7/igt@gem_exec_fair@basic-deadline.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl4/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2842]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-none-vip@rcs0: - shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-glk7/igt@gem_exec_fair@basic-none-vip@rcs0.html * igt@gem_exec_fair@basic-pace@bcs0: - shard-tglb: NOTRUN -> [FAIL][15] ([i915#2842]) +3 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@gem_exec_fair@basic-pace@bcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [PASS][16] -> [FAIL][17] ([i915#2842]) +2 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-iclb: [PASS][18] -> [FAIL][19] ([i915#2842]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb3/igt@gem_exec_fair@basic-pace@vcs0.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb4/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][21] -> [SKIP][22] ([i915#2190]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-tglb5/igt@gem_huc_copy@huc-copy.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb6/igt@gem_huc_copy@huc-copy.html * igt@gem_pwrite@basic-exhaustion: - shard-snb: NOTRUN -> [WARN][23] ([i915#2658]) +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-snb6/igt@gem_pwrite@basic-exhaustion.html * igt@gem_userptr_blits@dmabuf-sync: - shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3323]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl1/igt@gem_userptr_blits@dmabuf-sync.html * igt@gen3_mixed_blits: - shard-tglb: NOTRUN -> [SKIP][25] ([fdo#109289]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@gen3_mixed_blits.html * igt@kms_big_fb@linear-16bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][26] ([fdo#111614]) +1 similar issue [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_big_fb@linear-16bpp-rotate-270.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3777]) +2 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl2/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3777]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl10/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][29] ([fdo#110723]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111615]) +2 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][31] ([i915#3689] / [i915#3886]) +2 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs: - shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886]) +1 similar issue [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl2/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886]) +4 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +2 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl10/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109278]) +2 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][36] ([i915#3689]) +2 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_ccs@pipe-d-missing-ccs-buffer-yf_tiled_ccs.html * igt@kms_chamelium@dp-crc-multiple: - shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +11 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl1/igt@kms_chamelium@dp-crc-multiple.html * igt@kms_chamelium@dp-hpd-enable-disable-mode: - shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109284] / [fdo#111827]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_chamelium@dp-hpd-enable-disable-mode.html * igt@kms_chamelium@dp-hpd-storm-disable: - shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +4 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl10/igt@kms_chamelium@dp-hpd-storm-disable.html * igt@kms_chamelium@hdmi-hpd-for-each-pipe: - shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +13 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl7/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html * igt@kms_chamelium@vga-hpd: - shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +4 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_chamelium@vga-hpd.html * igt@kms_color@pipe-a-ctm-0-75: - shard-skl: [PASS][42] -> [DMESG-WARN][43] ([i915#1982]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl1/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_color_chamelium@pipe-a-ctm-blue-to-red: - shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +12 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-snb6/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html * igt@kms_color_chamelium@pipe-d-ctm-blue-to-red: - shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278] / [fdo#109284] / [fdo#111827]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_color_chamelium@pipe-d-ctm-blue-to-red.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-offscreen: - shard-tglb: NOTRUN -> [SKIP][46] ([i915#3319]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-32x32-offscreen.html * igt@kms_cursor_crc@pipe-c-cursor-512x512-random: - shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109279] / [i915#3359]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html * igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement: - shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [fdo#109279]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: NOTRUN -> [DMESG-WARN][49] ([i915#180]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][50] ([i915#3359]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement.html * igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge: - shard-snb: NOTRUN -> [SKIP][51] ([fdo#109271]) +309 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-snb6/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html * igt@kms_cursor_legacy@cursorb-vs-flipa-legacy: - shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109274] / [fdo#109278]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_cursor_legacy@cursorb-vs-flipa-legacy.html * igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions: - shard-tglb: NOTRUN -> [SKIP][53] ([i915#4103]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [PASS][54] -> [INCOMPLETE][55] ([i915#180] / [i915#1982]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html - shard-kbl: [PASS][56] -> [INCOMPLETE][57] ([i915#155] / [i915#180] / [i915#636]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl6/igt@kms_fbcon_fbt@fbc-suspend.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-blocking-absolute-wf_vblank: - shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109274]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_flip@2x-blocking-absolute-wf_vblank.html * igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2: - shard-glk: [PASS][59] -> [FAIL][60] ([i915#79]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-glk9/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-apl: [PASS][61] -> [DMESG-WARN][62] ([i915#180]) +3 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend@b-edp1: - shard-skl: [PASS][63] -> [INCOMPLETE][64] ([i915#146] / [i915#198]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl1/igt@kms_flip@flip-vs-suspend@b-edp1.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl2/igt@kms_flip@flip-vs-suspend@b-edp1.html * igt@kms_flip@plain-flip-fb-recreate@b-edp1: - shard-skl: [PASS][65] -> [FAIL][66] ([i915#2122]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl1/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl2/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move: - shard-tglb: NOTRUN -> [SKIP][67] ([fdo#111825]) +10 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-move.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt: - shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109280]) +2 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-shrfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc: - shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +114 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html * igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][70] ([i915#265]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][71] -> [FAIL][72] ([fdo#108145] / [i915#265]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: - shard-kbl: NOTRUN -> [FAIL][73] ([fdo#108145] / [i915#265]) +3 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html * igt@kms_plane_lowres@pipe-c-tiling-y: - shard-tglb: NOTRUN -> [SKIP][74] ([i915#3536]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_plane_lowres@pipe-c-tiling-y.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658]) +1 similar issue [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3: - shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl10/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5: - shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#658]) +1 similar issue [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2: - shard-tglb: NOTRUN -> [SKIP][78] ([i915#2920]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][79] -> [SKIP][80] ([fdo#109642] / [fdo#111068] / [i915#658]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb1/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [PASS][81] -> [SKIP][82] ([fdo#109441]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][83] -> [DMESG-WARN][84] ([i915#180] / [i915#295]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame: - shard-tglb: NOTRUN -> [SKIP][85] ([i915#2530]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame.html * igt@perf@blocking: - shard-skl: [PASS][86] -> [FAIL][87] ([i915#1542]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl8/igt@perf@blocking.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl3/igt@perf@blocking.html * igt@perf@short-reads: - shard-skl: [PASS][88] -> [FAIL][89] ([i915#51]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl3/igt@perf@short-reads.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl1/igt@perf@short-reads.html * igt@prime_nv_api@i915_nv_import_twice: - shard-tglb: NOTRUN -> [SKIP][90] ([fdo#109291]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@prime_nv_api@i915_nv_import_twice.html * igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name: - shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271]) +127 similar issues [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl1/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html * igt@prime_nv_api@i915_self_import: - shard-skl: NOTRUN -> [SKIP][92] ([fdo#109271]) +59 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl8/igt@prime_nv_api@i915_self_import.html * igt@prime_nv_pcopy@test3_2: - shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109291]) +1 similar issue [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb3/igt@prime_nv_pcopy@test3_2.html * igt@sysfs_clients@create: - shard-skl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2994]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl10/igt@sysfs_clients@create.html * igt@sysfs_clients@fair-0: - shard-kbl: NOTRUN -> [SKIP][95] ([fdo#109271] / [i915#2994]) [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl3/igt@sysfs_clients@fair-0.html * igt@sysfs_clients@recycle: - shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2994]) +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl8/igt@sysfs_clients@recycle.html #### Possible fixes #### * igt@gem_exec_fair@basic-deadline: - shard-tglb: [FAIL][97] ([i915#2846]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-tglb5/igt@gem_exec_fair@basic-deadline.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb8/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [FAIL][99] ([i915#2842]) -> [PASS][100] +2 similar issues [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][101] ([i915#2849]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_suspend@basic-s3: - shard-kbl: [INCOMPLETE][103] ([i915#155] / [i915#4173]) -> [PASS][104] [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl3/igt@gem_exec_suspend@basic-s3.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl7/igt@gem_exec_suspend@basic-s3.html * igt@gen9_exec_parse@allowed-all: - shard-kbl: [DMESG-WARN][105] ([i915#1436] / [i915#716]) -> [PASS][106] [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl7/igt@gen9_exec_parse@allowed-all.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl2/igt@gen9_exec_parse@allowed-all.html * igt@kms_color@pipe-b-ctm-0-25: - shard-skl: [DMESG-WARN][107] ([i915#1982]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl9/igt@kms_color@pipe-b-ctm-0-25.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl6/igt@kms_color@pipe-b-ctm-0-25.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-tglb: [INCOMPLETE][109] ([i915#2411] / [i915#2828] / [i915#456]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-tglb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [FAIL][111] ([i915#2346]) -> [PASS][112] [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: [DMESG-WARN][113] ([i915#180]) -> [PASS][114] [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile: - shard-iclb: [SKIP][115] ([i915#3701]) -> [PASS][116] +1 similar issue [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc: - shard-glk: [FAIL][117] ([i915#2546]) -> [PASS][118] [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-glk8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-glk8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc.html * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes: - shard-kbl: [DMESG-WARN][119] ([i915#180]) -> [PASS][120] +3 similar issues [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl6/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [SKIP][121] ([fdo#109441]) -> [PASS][122] +1 similar issue [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb3/igt@kms_psr@psr2_cursor_render.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb2/igt@kms_psr@psr2_cursor_render.html * igt@perf@polling-parameterized: - shard-glk: [FAIL][123] ([i915#1542]) -> [PASS][124] [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-glk1/igt@perf@polling-parameterized.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-glk9/igt@perf@polling-parameterized.html * igt@perf@polling-small-buf: - shard-tglb: [FAIL][125] ([i915#1722]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-tglb2/igt@perf@polling-small-buf.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-tglb3/igt@perf@polling-small-buf.html * igt@syncobj_wait@wait-all-delayed-signal: - shard-glk: [DMESG-WARN][127] ([i915#118] / [i915#95]) -> [PASS][128] +3 similar issues [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-glk5/igt@syncobj_wait@wait-all-delayed-signal.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-glk6/igt@syncobj_wait@wait-all-delayed-signal.html #### Warnings #### * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][129] ([i915#2684]) -> [WARN][130] ([i915#1804] / [i915#2684]) [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb4/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][131] ([i915#658]) -> [SKIP][132] ([i915#2920]) +1 similar issue [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb8/igt@kms_psr2_sf@cursor-plane-update-sf.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1: - shard-iclb: [SKIP][133] ([i915#2920]) -> [SKIP][134] ([i915#658]) +1 similar issue [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/shard-iclb7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html * igt@runner@aborted: - shard-kbl: ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602] / [i915#716]) -> ([FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602] / [i915#92]) [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl1/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl1/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl1/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl4/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl1/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl3/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl1/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10632/shard-kbl6/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tr == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21147/index.html [-- Attachment #2: Type: text/html, Size: 34021 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/i915/bdb: Fix version check 2021-09-23 16:49 ` [Intel-gfx] " Lukasz Majczak @ 2021-09-29 18:01 ` Souza, Jose -1 siblings, 0 replies; 6+ messages in thread From: Souza, Jose @ 2021-09-29 18:01 UTC (permalink / raw) To: Lee, Shawn C, lma Cc: dri-devel, joonas.lahtinen, intel-gfx, jani.nikula, upstream On Thu, 2021-09-23 at 18:49 +0200, Lukasz Majczak wrote: > With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" > the size of bdb_lfp_backlight_data structure has been increased, > causing if-statement in the parse_lfp_backlight function > that comapres this structure size to the one retrieved from BDB, > always to fail for older revisions. > This patch calculates expected size of the structure for a given > BDB version and compares it with the value gathered from BDB. > Tested on Chromebook Pixelbook (Nocturne) (reports bdb->version = 221) Fixes: d381baad29b4 ("drm/i915/vbt: Fix backlight parsing for VBT 234+") > > Tested-by: Lukasz Majczak <lma@semihalf.com> > Signed-off-by: Lukasz Majczak <lma@semihalf.com> > --- > drivers/gpu/drm/i915/display/intel_bios.c | 11 +++++++++-- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 5 +++++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c > index 3c25926092de..90eae6da12e0 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.c > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > @@ -428,6 +428,7 @@ parse_lfp_backlight(struct drm_i915_private *i915, > const struct lfp_backlight_data_entry *entry; > int panel_type = i915->vbt.panel_type; > u16 level; > + size_t exp_size; > > backlight_data = find_section(bdb, BDB_LVDS_BACKLIGHT); > if (!backlight_data) > @@ -450,9 +451,15 @@ parse_lfp_backlight(struct drm_i915_private *i915, > return; > } > > + if (bdb->version <= 234) > + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_234; > + else if (bdb->version > 234 && bdb->version <= 236) > + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_236; > + else > + exp_size = sizeof(struct bdb_lfp_backlight_data); Usually we go by the newest(IP version, platform...) to the oldest: if (bdb->version >= 236) exp_size = sizeof(struct bdb_lfp_backlight_data); else if (bdb->version >= 234) exp_size = offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits); else exp_size = offsetof(struct bdb_lfp_backlight_data, brightness_level); backlight_control was added in version 191 so no need to set exp_size for older versions. > + > i915->vbt.backlight.type = INTEL_BACKLIGHT_DISPLAY_DDI; > - if (bdb->version >= 191 && > - get_blocksize(backlight_data) >= sizeof(*backlight_data)) { > + if (bdb->version >= 191 && get_blocksize(backlight_data) >= exp_size) { > const struct lfp_backlight_control_method *method; > > method = &backlight_data->backlight_control[panel_type]; > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h > index 330077c2e588..ba9990e5983c 100644 > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h > @@ -814,6 +814,11 @@ struct lfp_brightness_level { > u16 reserved; > } __packed; > > +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_234 \ > + offsetof(struct bdb_lfp_backlight_data, brightness_level) version 234 starts at brightness_level but the size of 234 data must be included to the size, so it should be: offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits). > +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_236 \ > + offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits) > + > struct bdb_lfp_backlight_data { > u8 entry_size; > struct lfp_backlight_data_entry data[16]; ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/bdb: Fix version check @ 2021-09-29 18:01 ` Souza, Jose 0 siblings, 0 replies; 6+ messages in thread From: Souza, Jose @ 2021-09-29 18:01 UTC (permalink / raw) To: Lee, Shawn C, lma Cc: dri-devel, joonas.lahtinen, intel-gfx, jani.nikula, upstream On Thu, 2021-09-23 at 18:49 +0200, Lukasz Majczak wrote: > With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" > the size of bdb_lfp_backlight_data structure has been increased, > causing if-statement in the parse_lfp_backlight function > that comapres this structure size to the one retrieved from BDB, > always to fail for older revisions. > This patch calculates expected size of the structure for a given > BDB version and compares it with the value gathered from BDB. > Tested on Chromebook Pixelbook (Nocturne) (reports bdb->version = 221) Fixes: d381baad29b4 ("drm/i915/vbt: Fix backlight parsing for VBT 234+") > > Tested-by: Lukasz Majczak <lma@semihalf.com> > Signed-off-by: Lukasz Majczak <lma@semihalf.com> > --- > drivers/gpu/drm/i915/display/intel_bios.c | 11 +++++++++-- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 5 +++++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c > index 3c25926092de..90eae6da12e0 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.c > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > @@ -428,6 +428,7 @@ parse_lfp_backlight(struct drm_i915_private *i915, > const struct lfp_backlight_data_entry *entry; > int panel_type = i915->vbt.panel_type; > u16 level; > + size_t exp_size; > > backlight_data = find_section(bdb, BDB_LVDS_BACKLIGHT); > if (!backlight_data) > @@ -450,9 +451,15 @@ parse_lfp_backlight(struct drm_i915_private *i915, > return; > } > > + if (bdb->version <= 234) > + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_234; > + else if (bdb->version > 234 && bdb->version <= 236) > + exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_236; > + else > + exp_size = sizeof(struct bdb_lfp_backlight_data); Usually we go by the newest(IP version, platform...) to the oldest: if (bdb->version >= 236) exp_size = sizeof(struct bdb_lfp_backlight_data); else if (bdb->version >= 234) exp_size = offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits); else exp_size = offsetof(struct bdb_lfp_backlight_data, brightness_level); backlight_control was added in version 191 so no need to set exp_size for older versions. > + > i915->vbt.backlight.type = INTEL_BACKLIGHT_DISPLAY_DDI; > - if (bdb->version >= 191 && > - get_blocksize(backlight_data) >= sizeof(*backlight_data)) { > + if (bdb->version >= 191 && get_blocksize(backlight_data) >= exp_size) { > const struct lfp_backlight_control_method *method; > > method = &backlight_data->backlight_control[panel_type]; > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h > index 330077c2e588..ba9990e5983c 100644 > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h > @@ -814,6 +814,11 @@ struct lfp_brightness_level { > u16 reserved; > } __packed; > > +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_234 \ > + offsetof(struct bdb_lfp_backlight_data, brightness_level) version 234 starts at brightness_level but the size of 234 data must be included to the size, so it should be: offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits). > +#define EXP_BDB_LFP_BL_DATA_SIZE_REV_236 \ > + offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits) > + > struct bdb_lfp_backlight_data { > u8 entry_size; > struct lfp_backlight_data_entry data[16]; ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-29 18:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-09-23 16:49 [PATCH v2] drm/i915/bdb: Fix version check Lukasz Majczak 2021-09-23 16:49 ` [Intel-gfx] " Lukasz Majczak 2021-09-23 20:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bdb: Fix version check (rev2) Patchwork 2021-09-24 1:00 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-09-29 18:01 ` [PATCH v2] drm/i915/bdb: Fix version check Souza, Jose 2021-09-29 18:01 ` [Intel-gfx] " Souza, Jose
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.