Re: [PATCH v6 3/5] dt-binding: mt8183: Add Mediatek MDP3 dt-bindings

[moudy.ho <moudy.ho@mediatek.com>]

On Thu, 2021-08-19 at 07:49 -0500, Rob Herring wrote:
> On Thu, 19 Aug 2021 15:09:52 +0800, Moudy Ho wrote:
> > This patch adds DT binding document for Media Data Path 3 (MDP3)
> > a unit in multimedia system used for scaling and color format
> > convert.
> > 
> > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
> > ---
> >  .../bindings/media/mediatek,mdp3-ccorr.yaml   |  58 +++++
> >  .../bindings/media/mediatek,mdp3-rdma.yaml    | 241
> > ++++++++++++++++++
> >  .../bindings/media/mediatek,mdp3-rsz.yaml     |  66 +++++
> >  .../bindings/media/mediatek,mdp3-wdma.yaml    |  71 ++++++
> >  .../bindings/media/mediatek,mdp3-wrot.yaml    |  71 ++++++
> >  5 files changed, 507 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/mediatek,mdp3-ccorr.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/media/mediatek,mdp3-wdma.yaml
> >  create mode 100644
> > Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
> > 
Sorry for missing a space on line:183 of the file "mediatek,mdp3-
rdma.yaml " caused an alignment error that make "dt_binding_check"
fail.
It will be fixed in the further.
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> make[1]: *** Deleting file
> 'Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.example.dts'
> Traceback (most recent call last):
>   File "/usr/local/bin/dt-extract-example", line 45, in <module>
>     binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
>   File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py",
> line 434, in load
>     return constructor.get_single_data()
>   File "/usr/local/lib/python3.8/dist-
> packages/ruamel/yaml/constructor.py", line 120, in get_single_data
>     node = self.composer.get_single_node()
>   File "_ruamel_yaml.pyx", line 706, in
> _ruamel_yaml.CParser.get_single_node
>   File "_ruamel_yaml.pyx", line 724, in
> _ruamel_yaml.CParser._compose_document
>   File "_ruamel_yaml.pyx", line 775, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 889, in
> _ruamel_yaml.CParser._compose_mapping_node
>   File "_ruamel_yaml.pyx", line 773, in
> _ruamel_yaml.CParser._compose_node
>   File "_ruamel_yaml.pyx", line 848, in
> _ruamel_yaml.CParser._compose_sequence_node
>   File "_ruamel_yaml.pyx", line 904, in
> _ruamel_yaml.CParser._parse_next_event
> ruamel.yaml.scanner.ScannerError: while scanning a block scalar
>   in "<unicode string>", line 171, column 5
> found a tab character where an indentation space is expected
>   in "<unicode string>", line 183, column 1
> make[1]: *** [Documentation/devicetree/bindings/Makefile:20:
> Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.example.dts] Error 1
> make[1]: *** Waiting for unfinished jobs....
> ./Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml:  while scanning a block scalar
>   in "<unicode string>", line 171, column 5
> found a tab character where an indentation space is expected
>   in "<unicode string>", line 183, column 1
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml: ignoring, error parsing file
> warning: no schema found in file:
> ./Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> make: *** [Makefile:1419: dt_binding_check] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See 
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/1518477__;!!CTRNKA9wMg0ARbw!2av75m5eJ2hSjFAgkXmPi-gQOv7ITc4RcVm1365xi_QcwQlFdg7oYQsw4pZf2ft_$
>  
> 
> This check can fail if there are any dependencies. The base for a
> patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek