* [PATCH] iio: proximity: as3935: fix AS3935_INT mask
@ 2017-04-27 7:52 Matt Ranostay
2017-04-27 7:59 ` Matt Ranostay
0 siblings, 1 reply; 4+ messages in thread
From: Matt Ranostay @ 2017-04-27 7:52 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Matt Ranostay, stable
AS3935 interrupt mask has been incorrect so valid lightning events
would never trigger an buffer event. Also noise interrupt should be
BIT(0).
Fixes: 24ddb0e4bba4 ("iio: Add AS3935 lightning sensor support")
CC: stable@vger.kernel.org
Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
---
drivers/iio/proximity/as3935.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
index aa0d0be1a608..8f081ef4802d 100644
--- a/drivers/iio/proximity/as3935.c
+++ b/drivers/iio/proximity/as3935.c
@@ -40,9 +40,9 @@
#define AS3935_AFE_PWR_BIT BIT(0)
#define AS3935_INT 0x03
-#define AS3935_INT_MASK 0x07
+#define AS3935_INT_MASK 0x0f
#define AS3935_EVENT_INT BIT(3)
-#define AS3935_NOISE_INT BIT(1)
+#define AS3935_NOISE_INT BIT(0)
#define AS3935_DATA 0x07
#define AS3935_DATA_MASK 0x3F
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: proximity: as3935: fix AS3935_INT mask
2017-04-27 7:52 [PATCH] iio: proximity: as3935: fix AS3935_INT mask Matt Ranostay
@ 2017-04-27 7:59 ` Matt Ranostay
2017-04-27 8:00 ` Matt Ranostay
0 siblings, 1 reply; 4+ messages in thread
From: Matt Ranostay @ 2017-04-27 7:59 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: open list:IIO SUBSYSTEM AND..., Matt Ranostay, stable
On Thu, Apr 27, 2017 at 12:52 AM, Matt Ranostay
<matt.ranostay@konsulko.com> wrote:
> AS3935 interrupt mask has been incorrect so valid lightning events
> would never trigger an buffer event. Also noise interrupt should be
> BIT(0).
Er, BIT(1)
Damn comment errors :)
>
> Fixes: 24ddb0e4bba4 ("iio: Add AS3935 lightning sensor support")
> CC: stable@vger.kernel.org
> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
> ---
> drivers/iio/proximity/as3935.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
> index aa0d0be1a608..8f081ef4802d 100644
> --- a/drivers/iio/proximity/as3935.c
> +++ b/drivers/iio/proximity/as3935.c
> @@ -40,9 +40,9 @@
> #define AS3935_AFE_PWR_BIT BIT(0)
>
> #define AS3935_INT 0x03
> -#define AS3935_INT_MASK 0x07
> +#define AS3935_INT_MASK 0x0f
> #define AS3935_EVENT_INT BIT(3)
> -#define AS3935_NOISE_INT BIT(1)
> +#define AS3935_NOISE_INT BIT(0)
>
> #define AS3935_DATA 0x07
> #define AS3935_DATA_MASK 0x3F
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: proximity: as3935: fix AS3935_INT mask
2017-04-27 7:59 ` Matt Ranostay
@ 2017-04-27 8:00 ` Matt Ranostay
2017-04-27 15:29 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Matt Ranostay @ 2017-04-27 8:00 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: open list:IIO SUBSYSTEM AND..., Matt Ranostay, stable
On Thu, Apr 27, 2017 at 12:59 AM, Matt Ranostay
<matt.ranostay@konsulko.com> wrote:
> On Thu, Apr 27, 2017 at 12:52 AM, Matt Ranostay
> <matt.ranostay@konsulko.com> wrote:
>> AS3935 interrupt mask has been incorrect so valid lightning events
>> would never trigger an buffer event. Also noise interrupt should be
>> BIT(0).
>
> Er, BIT(1)
Gah zero re-read the line wrong. Datasheet fun!
>
> Damn comment errors :)
>
>>
>> Fixes: 24ddb0e4bba4 ("iio: Add AS3935 lightning sensor support")
>> CC: stable@vger.kernel.org
>> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
>> ---
>> drivers/iio/proximity/as3935.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
>> index aa0d0be1a608..8f081ef4802d 100644
>> --- a/drivers/iio/proximity/as3935.c
>> +++ b/drivers/iio/proximity/as3935.c
>> @@ -40,9 +40,9 @@
>> #define AS3935_AFE_PWR_BIT BIT(0)
>>
>> #define AS3935_INT 0x03
>> -#define AS3935_INT_MASK 0x07
>> +#define AS3935_INT_MASK 0x0f
>> #define AS3935_EVENT_INT BIT(3)
>> -#define AS3935_NOISE_INT BIT(1)
>> +#define AS3935_NOISE_INT BIT(0)
>>
>> #define AS3935_DATA 0x07
>> #define AS3935_DATA_MASK 0x3F
>> --
>> 2.11.0
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: proximity: as3935: fix AS3935_INT mask
2017-04-27 8:00 ` Matt Ranostay
@ 2017-04-27 15:29 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2017-04-27 15:29 UTC (permalink / raw)
To: Matt Ranostay; +Cc: open list:IIO SUBSYSTEM AND..., stable
On 27/04/17 09:00, Matt Ranostay wrote:
> On Thu, Apr 27, 2017 at 12:59 AM, Matt Ranostay
> <matt.ranostay@konsulko.com> wrote:
>> On Thu, Apr 27, 2017 at 12:52 AM, Matt Ranostay
>> <matt.ranostay@konsulko.com> wrote:
>>> AS3935 interrupt mask has been incorrect so valid lightning events
>>> would never trigger an buffer event. Also noise interrupt should be
>>> BIT(0).
>>
>> Er, BIT(1)
>
> Gah zero re-read the line wrong. Datasheet fun!
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>>
>> Damn comment errors :)
>>
>>>
>>> Fixes: 24ddb0e4bba4 ("iio: Add AS3935 lightning sensor support")
>>> CC: stable@vger.kernel.org
>>> Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com>
>>> ---
>>> drivers/iio/proximity/as3935.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c
>>> index aa0d0be1a608..8f081ef4802d 100644
>>> --- a/drivers/iio/proximity/as3935.c
>>> +++ b/drivers/iio/proximity/as3935.c
>>> @@ -40,9 +40,9 @@
>>> #define AS3935_AFE_PWR_BIT BIT(0)
>>>
>>> #define AS3935_INT 0x03
>>> -#define AS3935_INT_MASK 0x07
>>> +#define AS3935_INT_MASK 0x0f
>>> #define AS3935_EVENT_INT BIT(3)
>>> -#define AS3935_NOISE_INT BIT(1)
>>> +#define AS3935_NOISE_INT BIT(0)
>>>
>>> #define AS3935_DATA 0x07
>>> #define AS3935_DATA_MASK 0x3F
>>> --
>>> 2.11.0
>>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-27 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 7:52 [PATCH] iio: proximity: as3935: fix AS3935_INT mask Matt Ranostay
2017-04-27 7:59 ` Matt Ranostay
2017-04-27 8:00 ` Matt Ranostay
2017-04-27 15:29 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.