All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Sasha Levin <sashal@kernel.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Mark Hounschell <markh@compro.net>,
	Karol Herbst <kherbst@redhat.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH AUTOSEL 4.14 2/8] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve
Date: Mon, 14 Dec 2020 10:49:55 +0100	[thread overview]
Message-ID: <642b5479-d4d9-37a7-3b14-3162374829d5@amd.com> (raw)
In-Reply-To: <20201212160859.2335412-2-sashal@kernel.org>

Hi Sasha,

please don't apply this patch to any older kernel.

The fix was only needed for a patch which went in with the 5.10 pull 
request.

Thanks,
Christian.

Am 12.12.20 um 17:08 schrieb Sasha Levin:
> From: Christian König <christian.koenig@amd.com>
>
> [ Upstream commit aea656b0d05ec5b8ed5beb2f94c4dd42ea834e9d ]
>
> This wasn't initialized for pre NV50 hardware.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reported-and-Tested-by: Mark Hounschell <markh@compro.net>
> Reviewed-by: Karol Herbst <kherbst@redhat.com>
> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F84298%2F&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7C664e6201322444b319e908d89eb83eda%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637433861463180140%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=OQ2BSmlDxz%2BPGq6aDpQBaXjQgO0wdt6y6KlCzIIFVso%3D&amp;reserved=0
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>   drivers/gpu/drm/nouveau/nouveau_bo.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index e427f80344c4d..fddbe66935464 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1375,6 +1375,7 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg)
>   			nvkm_vm_map(&mem->bar_vma, mem);
>   			reg->bus.offset = mem->bar_vma.offset;
>   		}
> +		ret = 0;
>   		break;
>   	default:
>   		return -EINVAL;


WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Sasha Levin <sashal@kernel.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Mark Hounschell <markh@compro.net>,
	dri-devel@lists.freedesktop.org,
	Karol Herbst <kherbst@redhat.com>
Subject: Re: [PATCH AUTOSEL 4.14 2/8] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve
Date: Mon, 14 Dec 2020 10:49:55 +0100	[thread overview]
Message-ID: <642b5479-d4d9-37a7-3b14-3162374829d5@amd.com> (raw)
In-Reply-To: <20201212160859.2335412-2-sashal@kernel.org>

Hi Sasha,

please don't apply this patch to any older kernel.

The fix was only needed for a patch which went in with the 5.10 pull 
request.

Thanks,
Christian.

Am 12.12.20 um 17:08 schrieb Sasha Levin:
> From: Christian König <christian.koenig@amd.com>
>
> [ Upstream commit aea656b0d05ec5b8ed5beb2f94c4dd42ea834e9d ]
>
> This wasn't initialized for pre NV50 hardware.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reported-and-Tested-by: Mark Hounschell <markh@compro.net>
> Reviewed-by: Karol Herbst <kherbst@redhat.com>
> Link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F84298%2F&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7C664e6201322444b319e908d89eb83eda%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637433861463180140%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=OQ2BSmlDxz%2BPGq6aDpQBaXjQgO0wdt6y6KlCzIIFVso%3D&amp;reserved=0
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>   drivers/gpu/drm/nouveau/nouveau_bo.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index e427f80344c4d..fddbe66935464 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1375,6 +1375,7 @@ nouveau_ttm_io_mem_reserve(struct ttm_bo_device *bdev, struct ttm_mem_reg *reg)
>   			nvkm_vm_map(&mem->bar_vma, mem);
>   			reg->bus.offset = mem->bar_vma.offset;
>   		}
> +		ret = 0;
>   		break;
>   	default:
>   		return -EINVAL;

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-12-14  9:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12 16:08 [PATCH AUTOSEL 4.14 1/8] kernel/cpu: add arch override for clear_tasks_mm_cpumask() mm handling Sasha Levin
2020-12-12 16:08 ` [PATCH AUTOSEL 4.14 2/8] drm/nouveau: make sure ret is initialized in nouveau_ttm_io_mem_reserve Sasha Levin
2020-12-12 16:08   ` Sasha Levin
2020-12-14  9:49   ` Christian König [this message]
2020-12-14  9:49     ` Christian König
2020-12-14 15:16     ` Sasha Levin
2020-12-14 15:16       ` Sasha Levin
2020-12-12 16:08 ` [PATCH AUTOSEL 4.14 3/8] drm/tegra: sor: Disable clocks on error in tegra_sor_init() Sasha Levin
2020-12-12 16:08   ` Sasha Levin
2020-12-12 16:08 ` [PATCH AUTOSEL 4.14 4/8] vxlan: Add needed_headroom for lower device Sasha Levin
2020-12-12 16:08 ` [PATCH AUTOSEL 4.14 5/8] vxlan: Copy needed_tailroom from lowerdev Sasha Levin
2020-12-12 16:08 ` [PATCH AUTOSEL 4.14 6/8] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback() Sasha Levin
2020-12-12 16:08   ` Sasha Levin
2020-12-12 16:08 ` [PATCH AUTOSEL 4.14 7/8] scsi: mpt3sas: Increase IOCInit request timeout to 30s Sasha Levin
2020-12-12 16:08 ` [PATCH AUTOSEL 4.14 8/8] dm table: Remove BUG_ON(in_interrupt()) Sasha Levin
2020-12-12 16:08   ` [dm-devel] " Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=642b5479-d4d9-37a7-3b14-3162374829d5@amd.com \
    --to=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kherbst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.