* [PATCH net-next] net: ena: remove set but not used variable 'rx_ring'
@ 2019-12-24 12:51 YueHaibing
2019-12-24 12:56 ` Jubran, Samih
2019-12-28 0:32 ` David Miller
0 siblings, 2 replies; 6+ messages in thread
From: YueHaibing @ 2019-12-24 12:51 UTC (permalink / raw)
To: davem, sameehj; +Cc: netdev, linux-kernel, YueHaibing
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function ena_xdp_xmit_buff:
drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
variable rx_ring set but not used [-Wunused-but-set-variable]
commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")
left behind this unused variable.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 081acf0..894e8c1 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -313,7 +313,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
struct ena_com_tx_ctx ena_tx_ctx = {0};
struct ena_tx_buffer *tx_info;
struct ena_ring *xdp_ring;
- struct ena_ring *rx_ring;
u16 next_to_use, req_id;
int rc;
void *push_hdr;
@@ -324,8 +323,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
req_id = xdp_ring->free_ids[next_to_use];
tx_info = &xdp_ring->tx_buffer_info[req_id];
tx_info->num_of_bufs = 0;
- rx_ring = &xdp_ring->adapter->rx_ring[qid -
- xdp_ring->adapter->xdp_first_ring];
page_ref_inc(rx_info->page);
tx_info->xdp_rx_page = rx_info->page;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH net-next] net: ena: remove set but not used variable 'rx_ring'
2019-12-24 12:51 [PATCH net-next] net: ena: remove set but not used variable 'rx_ring' YueHaibing
@ 2019-12-24 12:56 ` Jubran, Samih
2019-12-28 0:32 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: Jubran, Samih @ 2019-12-24 12:56 UTC (permalink / raw)
To: YueHaibing, davem; +Cc: netdev, linux-kernel
Good catch, looks good.
Ack, thanks!
> -----Original Message-----
> From: YueHaibing <yuehaibing@huawei.com>
> Sent: Tuesday, December 24, 2019 2:51 PM
> To: davem@davemloft.net; Jubran, Samih <sameehj@amazon.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [PATCH net-next] net: ena: remove set but not used variable
> 'rx_ring'
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function
> ena_xdp_xmit_buff:
> drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
> variable rx_ring set but not used [-Wunused-but-set-variable]
>
> commit 548c4940b9f1 ("net: ena: Implement XDP_TX action") left behind this
> unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 081acf0..894e8c1 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -313,7 +313,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
> struct ena_com_tx_ctx ena_tx_ctx = {0};
> struct ena_tx_buffer *tx_info;
> struct ena_ring *xdp_ring;
> - struct ena_ring *rx_ring;
> u16 next_to_use, req_id;
> int rc;
> void *push_hdr;
> @@ -324,8 +323,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
> req_id = xdp_ring->free_ids[next_to_use];
> tx_info = &xdp_ring->tx_buffer_info[req_id];
> tx_info->num_of_bufs = 0;
> - rx_ring = &xdp_ring->adapter->rx_ring[qid -
> - xdp_ring->adapter->xdp_first_ring];
> page_ref_inc(rx_info->page);
> tx_info->xdp_rx_page = rx_info->page;
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: ena: remove set but not used variable 'rx_ring'
2019-12-24 12:51 [PATCH net-next] net: ena: remove set but not used variable 'rx_ring' YueHaibing
2019-12-24 12:56 ` Jubran, Samih
@ 2019-12-28 0:32 ` David Miller
1 sibling, 0 replies; 6+ messages in thread
From: David Miller @ 2019-12-28 0:32 UTC (permalink / raw)
To: yuehaibing; +Cc: sameehj, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 24 Dec 2019 20:51:28 +0800
> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function ena_xdp_xmit_buff:
> drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
> variable rx_ring set but not used [-Wunused-but-set-variable]
>
> commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")
> left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net-next] net: ena: remove set but not used variable 'rx_ring'
@ 2020-02-18 1:59 YueHaibing
2020-02-18 5:53 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2020-02-18 1:59 UTC (permalink / raw)
To: netanel, akiyano, gtzalik, saeedb, zorik, davem, kuba, hawk,
john.fastabend, sameehj
Cc: netdev, linux-kernel, YueHaibing
drivers/net/ethernet/amazon/ena/ena_netdev.c: In function ena_xdp_xmit_buff:
drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
variable rx_ring set but not used [-Wunused-but-set-variable]
commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")
left behind this unused variable.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 081acf0..894e8c1 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -313,7 +313,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
struct ena_com_tx_ctx ena_tx_ctx = {0};
struct ena_tx_buffer *tx_info;
struct ena_ring *xdp_ring;
- struct ena_ring *rx_ring;
u16 next_to_use, req_id;
int rc;
void *push_hdr;
@@ -324,8 +323,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
req_id = xdp_ring->free_ids[next_to_use];
tx_info = &xdp_ring->tx_buffer_info[req_id];
tx_info->num_of_bufs = 0;
- rx_ring = &xdp_ring->adapter->rx_ring[qid -
- xdp_ring->adapter->xdp_first_ring];
page_ref_inc(rx_info->page);
tx_info->xdp_rx_page = rx_info->page;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: ena: remove set but not used variable 'rx_ring'
2020-02-18 1:59 YueHaibing
@ 2020-02-18 5:53 ` David Miller
2020-02-18 6:19 ` Yuehaibing
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2020-02-18 5:53 UTC (permalink / raw)
To: yuehaibing
Cc: netanel, akiyano, gtzalik, saeedb, zorik, kuba, hawk,
john.fastabend, sameehj, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 18 Feb 2020 09:59:51 +0800
> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function ena_xdp_xmit_buff:
> drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
> variable rx_ring set but not used [-Wunused-but-set-variable]
>
> commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")
> left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This does not apply cleanly to net-next, please respin.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: ena: remove set but not used variable 'rx_ring'
2020-02-18 5:53 ` David Miller
@ 2020-02-18 6:19 ` Yuehaibing
0 siblings, 0 replies; 6+ messages in thread
From: Yuehaibing @ 2020-02-18 6:19 UTC (permalink / raw)
To: David Miller
Cc: netanel, akiyano, gtzalik, saeedb, zorik, kuba, hawk,
john.fastabend, sameehj, netdev, linux-kernel
On 2020/2/18 13:53, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Tue, 18 Feb 2020 09:59:51 +0800
>
>> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function ena_xdp_xmit_buff:
>> drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
>> variable rx_ring set but not used [-Wunused-but-set-variable]
>>
>> commit 548c4940b9f1 ("net: ena: Implement XDP_TX action")
>> left behind this unused variable.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> This does not apply cleanly to net-next, please respin.
Sorry, this is a duplicate, my bad.
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-18 6:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-24 12:51 [PATCH net-next] net: ena: remove set but not used variable 'rx_ring' YueHaibing
2019-12-24 12:56 ` Jubran, Samih
2019-12-28 0:32 ` David Miller
2020-02-18 1:59 YueHaibing
2020-02-18 5:53 ` David Miller
2020-02-18 6:19 ` Yuehaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.