From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, den@virtuozzo.com,
armbru@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qapi: support external bitmaps in block-dirty-bitmap-merge
Date: Mon, 20 May 2019 10:23:48 -0500 [thread overview]
Message-ID: <64336004-7376-d4ec-b918-37d21fc1dfac@redhat.com> (raw)
In-Reply-To: <e9c48cc9-3208-c111-9669-f6098ec746cd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On 5/17/19 5:45 PM, John Snow wrote:
>
>
> On 5/17/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Add new optional parameter making possible to merge bitmaps from
>> different nodes. It is needed to maintain external snapshots during
>> incremental backup chain history.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>> +# Since: 4.1
>> +##
>> +{ 'alternate': 'BlockDirtyBitmapMergeSource',
>> + 'data': { 'local': 'str',
>> + 'external': 'BlockDirtyBitmap' } }
>> +
>
> We might be able to use something more generic to name this type of
> thing, but I think such changes are wire compatible, so we can rename it
> to be more generic if we decide to use this for something else in the
> future, so this is good.
Correct - type names are not API, so we can rename them later if it
makes sense.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-20 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 15:21 [Qemu-devel] [PATCH v2 0/2] bitmaps: merge bitmaps from different nodes Vladimir Sementsov-Ogievskiy
2019-05-17 15:21 ` [Qemu-devel] [PATCH v2 1/2] qapi: support external bitmaps in block-dirty-bitmap-merge Vladimir Sementsov-Ogievskiy
2019-05-17 22:45 ` John Snow
2019-05-20 15:23 ` Eric Blake [this message]
2019-05-17 15:21 ` [Qemu-devel] [PATCH v2 2/2] iotests: test external snapshot with bitmap copying Vladimir Sementsov-Ogievskiy
2019-05-18 1:31 ` John Snow
2019-05-20 7:47 ` Vladimir Sementsov-Ogievskiy
2019-05-20 22:50 ` John Snow
2019-06-05 14:51 ` [Qemu-devel] [Qemu-block] " Max Reitz
2019-06-05 15:08 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64336004-7376-d4ec-b918-37d21fc1dfac@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.