All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Greentime Hu <green.hu@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	andrew@lunn.ch, linux-kernel@vger.kernel.org, jiri@resnulli.us
Subject: Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.
Date: Sat, 31 Dec 2016 21:23:58 +0100	[thread overview]
Message-ID: <6434425.l4ZxB6kK6L@wuerfel> (raw)
In-Reply-To: <351d1ae7-ca51-7962-0e52-38cdc69bcebd@gmail.com>

On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote:
> 
> On 12/29/2016 11:37 PM, Greentime Hu wrote:
> > Signed-off-by: Greentime Hu <green.hu@gmail.com>
> 
> This is not enough, you need to add a Device Tree binding document under
> Documentation/devicetree/bindings/net/ which documents this compatible
> string, as well as additional properties that may be required to
> describe this hardware block.

We already have

Documentation/devicetree/bindings/net/moxa,moxart-mac.txt

for the same hardware (though used by a different driver).

I'd suggest renaming that one to a more generic file name and
adding the new compatible string there.

Aside from that, every patch should also have a changelog comment.

	Arnd

  reply	other threads:[~2016-12-31 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30  7:37 [PATCH v3] net: ethernet: faraday: To support device tree usage Greentime Hu
2016-12-31 18:48 ` Florian Fainelli
2016-12-31 18:48   ` Florian Fainelli
2016-12-31 20:23   ` Arnd Bergmann [this message]
     [not found]     ` <CAEbi=3cJtHr-G+CHzAMgsfoscj6Eb=YUJeXB7=AmmT5DrHOqXg@mail.gmail.com>
2017-01-03 13:24       ` Arnd Bergmann
     [not found]         ` <CAEbi=3f7pf59YjNha-bpK+GZw4BSdevngi=fekd9uNLMVXDVnQ@mail.gmail.com>
2017-01-04 13:23           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6434425.l4ZxB6kK6L@wuerfel \
    --to=arnd@arndb.de \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=green.hu@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.