* [PATCH v3] net: ethernet: faraday: To support device tree usage.
@ 2016-12-30 7:37 Greentime Hu
2016-12-31 18:48 ` Florian Fainelli
0 siblings, 1 reply; 6+ messages in thread
From: Greentime Hu @ 2016-12-30 7:37 UTC (permalink / raw)
To: netdev, devicetree, andrew, arnd, linux-kernel, jiri; +Cc: Greentime Hu
Signed-off-by: Greentime Hu <green.hu@gmail.com>
---
Changes in v3:
- Nothing changed in this patch but I have committed andestech to vendor-prefixes.txt.
drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..5d70ee9 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c
@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
return 0;
}
+static const struct of_device_id ftmac100_of_ids[] = {
+ { .compatible = "andestech,atmac100" },
+ { }
+};
+
static struct platform_driver ftmac100_driver = {
.probe = ftmac100_probe,
.remove = __exit_p(ftmac100_remove),
.driver = {
.name = DRV_NAME,
+ .of_match_table = ftmac100_of_ids
},
};
@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
MODULE_AUTHOR("Po-Yu Chuang <ratbert@faraday-tech.com>");
MODULE_DESCRIPTION("FTMAC100 driver");
MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, ftmac100_of_ids);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.
@ 2016-12-31 18:48 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2016-12-31 18:48 UTC (permalink / raw)
To: Greentime Hu, netdev, devicetree, andrew, arnd, linux-kernel, jiri
On 12/29/2016 11:37 PM, Greentime Hu wrote:
> Signed-off-by: Greentime Hu <green.hu@gmail.com>
This is not enough, you need to add a Device Tree binding document under
Documentation/devicetree/bindings/net/ which documents this compatible
string, as well as additional properties that may be required to
describe this hardware block.
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.
@ 2016-12-31 18:48 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2016-12-31 18:48 UTC (permalink / raw)
To: Greentime Hu, netdev-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA, andrew-g2DYL2Zd6BY,
arnd-r2nGTMty4D4, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
jiri-rHqAuBHg3fBzbRFIqnYvSA
On 12/29/2016 11:37 PM, Greentime Hu wrote:
> Signed-off-by: Greentime Hu <green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
This is not enough, you need to add a Device Tree binding document under
Documentation/devicetree/bindings/net/ which documents this compatible
string, as well as additional properties that may be required to
describe this hardware block.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] net: ethernet: faraday: To support device tree usage.
2016-12-31 18:48 ` Florian Fainelli
(?)
@ 2016-12-31 20:23 ` Arnd Bergmann
[not found] ` <CAEbi=3cJtHr-G+CHzAMgsfoscj6Eb=YUJeXB7=AmmT5DrHOqXg@mail.gmail.com>
-1 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2016-12-31 20:23 UTC (permalink / raw)
To: Florian Fainelli
Cc: Greentime Hu, netdev, devicetree, andrew, linux-kernel, jiri
On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote:
>
> On 12/29/2016 11:37 PM, Greentime Hu wrote:
> > Signed-off-by: Greentime Hu <green.hu@gmail.com>
>
> This is not enough, you need to add a Device Tree binding document under
> Documentation/devicetree/bindings/net/ which documents this compatible
> string, as well as additional properties that may be required to
> describe this hardware block.
We already have
Documentation/devicetree/bindings/net/moxa,moxart-mac.txt
for the same hardware (though used by a different driver).
I'd suggest renaming that one to a more generic file name and
adding the new compatible string there.
Aside from that, every patch should also have a changelog comment.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-04 13:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-30 7:37 [PATCH v3] net: ethernet: faraday: To support device tree usage Greentime Hu
2016-12-31 18:48 ` Florian Fainelli
2016-12-31 18:48 ` Florian Fainelli
2016-12-31 20:23 ` Arnd Bergmann
[not found] ` <CAEbi=3cJtHr-G+CHzAMgsfoscj6Eb=YUJeXB7=AmmT5DrHOqXg@mail.gmail.com>
2017-01-03 13:24 ` Arnd Bergmann
[not found] ` <CAEbi=3f7pf59YjNha-bpK+GZw4BSdevngi=fekd9uNLMVXDVnQ@mail.gmail.com>
2017-01-04 13:23 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.