[Buildroot] [PATCH 1/1] package/python-pep517: migrate setup type to flit

[Buildroot] [PATCH 1/1] package/python-pep517: migrate setup type to flit

[James Hilliard]

This package is moving to flit, we need to use flit-bootstrap
since host-python-pypa-build depends on host-python-pep517.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/python-pep517/python-pep517.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/python-pep517/python-pep517.mk b/package/python-pep517/python-pep517.mk
index 99aa62d51d..45c4f8dd39 100644
--- a/package/python-pep517/python-pep517.mk
+++ b/package/python-pep517/python-pep517.mk
@@ -9,7 +9,7 @@ PYTHON_PEP517_SOURCE = pep517-$(PYTHON_PEP517_VERSION).tar.gz
 PYTHON_PEP517_SITE = https://files.pythonhosted.org/packages/0a/65/6e656d49c679136edfba25f25791f45ffe1ea4ae2ec1c59fe9c35e061cd1
 PYTHON_PEP517_LICENSE = MIT
 PYTHON_PEP517_LICENSE_FILES = LICENSE
-PYTHON_PEP517_SETUP_TYPE = distutils
+PYTHON_PEP517_SETUP_TYPE = flit-bootstrap
 HOST_PYTHON_PEP517_DEPENDENCIES = host-python-tomli
 
 $(eval $(host-python-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/python-pep517: migrate setup type to flit

[Arnout Vandecappelle]

On 26/04/2022 03:23, James Hilliard wrote:
> This package is moving to flit, we need to use flit-bootstrap
> since host-python-pypa-build depends on host-python-pep517.

  But that only becomes relevant when we bump the version to something which 
drops distutils support, right?

  Of course, we can merge this patch now already, that's not what I'm saying. 
But the commit message says "we need to" which is not entirely correct. It's 
more like "we'll have to". Right?

  Regards,
  Arnout

> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>   package/python-pep517/python-pep517.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/python-pep517/python-pep517.mk b/package/python-pep517/python-pep517.mk
> index 99aa62d51d..45c4f8dd39 100644
> --- a/package/python-pep517/python-pep517.mk
> +++ b/package/python-pep517/python-pep517.mk
> @@ -9,7 +9,7 @@ PYTHON_PEP517_SOURCE = pep517-$(PYTHON_PEP517_VERSION).tar.gz
>   PYTHON_PEP517_SITE = https://files.pythonhosted.org/packages/0a/65/6e656d49c679136edfba25f25791f45ffe1ea4ae2ec1c59fe9c35e061cd1
>   PYTHON_PEP517_LICENSE = MIT
>   PYTHON_PEP517_LICENSE_FILES = LICENSE
> -PYTHON_PEP517_SETUP_TYPE = distutils
> +PYTHON_PEP517_SETUP_TYPE = flit-bootstrap
>   HOST_PYTHON_PEP517_DEPENDENCIES = host-python-tomli
>   
>   $(eval $(host-python-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/python-pep517: migrate setup type to flit

[James Hilliard]

On Wed, Apr 27, 2022 at 1:10 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 26/04/2022 03:23, James Hilliard wrote:
> > This package is moving to flit, we need to use flit-bootstrap
> > since host-python-pypa-build depends on host-python-pep517.
>
>   But that only becomes relevant when we bump the version to something which
> drops distutils support, right?

Yeah, it will be required soon though it seems:
https://github.com/pypa/pep517/blob/v0.12.0/pyproject.toml#L2

The distutils support in pep517 is coming from the deprecated flit distutils
generator compatibility feature.

>
>   Of course, we can merge this patch now already, that's not what I'm saying.
> But the commit message says "we need to" which is not entirely correct. It's
> more like "we'll have to". Right?

The "we need to" part was referring to having to use the special flit-bootstrap
setup type instead of the regular flit setup type, not that this is immediately
needed by pep517, I may not have worded that clearly I guess.

>
>   Regards,
>   Arnout
>
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >   package/python-pep517/python-pep517.mk | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/python-pep517/python-pep517.mk b/package/python-pep517/python-pep517.mk
> > index 99aa62d51d..45c4f8dd39 100644
> > --- a/package/python-pep517/python-pep517.mk
> > +++ b/package/python-pep517/python-pep517.mk
> > @@ -9,7 +9,7 @@ PYTHON_PEP517_SOURCE = pep517-$(PYTHON_PEP517_VERSION).tar.gz
> >   PYTHON_PEP517_SITE = https://files.pythonhosted.org/packages/0a/65/6e656d49c679136edfba25f25791f45ffe1ea4ae2ec1c59fe9c35e061cd1
> >   PYTHON_PEP517_LICENSE = MIT
> >   PYTHON_PEP517_LICENSE_FILES = LICENSE
> > -PYTHON_PEP517_SETUP_TYPE = distutils
> > +PYTHON_PEP517_SETUP_TYPE = flit-bootstrap
> >   HOST_PYTHON_PEP517_DEPENDENCIES = host-python-tomli
> >
> >   $(eval $(host-python-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/python-pep517: migrate setup type to flit

[Arnout Vandecappelle]

On 26/04/2022 03:23, James Hilliard wrote:
> This package is moving to flit, we need to use flit-bootstrap
> since host-python-pypa-build depends on host-python-pep517.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/python-pep517/python-pep517.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/python-pep517/python-pep517.mk b/package/python-pep517/python-pep517.mk
> index 99aa62d51d..45c4f8dd39 100644
> --- a/package/python-pep517/python-pep517.mk
> +++ b/package/python-pep517/python-pep517.mk
> @@ -9,7 +9,7 @@ PYTHON_PEP517_SOURCE = pep517-$(PYTHON_PEP517_VERSION).tar.gz
>   PYTHON_PEP517_SITE = https://files.pythonhosted.org/packages/0a/65/6e656d49c679136edfba25f25791f45ffe1ea4ae2ec1c59fe9c35e061cd1
>   PYTHON_PEP517_LICENSE = MIT
>   PYTHON_PEP517_LICENSE_FILES = LICENSE
> -PYTHON_PEP517_SETUP_TYPE = distutils
> +PYTHON_PEP517_SETUP_TYPE = flit-bootstrap
>   HOST_PYTHON_PEP517_DEPENDENCIES = host-python-tomli
>   
>   $(eval $(host-python-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot