From: David Ahern <dsa@cumulusnetworks.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: pablo@netfilter.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Benc <jbenc@redhat.com>,
jiri@resnulli.us, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 1/5] netlink: extended ACK reporting
Date: Sat, 8 Apr 2017 16:14:39 -0400 [thread overview]
Message-ID: <647a29e0-fd0d-9bba-e38f-e73dc35ae414@cumulusnetworks.com> (raw)
In-Reply-To: <20170408174900.12820-2-johannes@sipsolutions.net>
On 4/8/17 1:48 PM, Johannes Berg wrote:
> diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h
> index f3946a27bd07..d1564557d645 100644
> --- a/include/uapi/linux/netlink.h
> +++ b/include/uapi/linux/netlink.h
> @@ -101,6 +101,29 @@ struct nlmsghdr {
> struct nlmsgerr {
> int error;
> struct nlmsghdr msg;
> + /*
> + * followed by the message contents unless NETLINK_CAP_ACK was set,
> + * message length is aligned with NLMSG_ALIGN()
> + */
> + /*
> + * followed by TLVs defined in enum nlmsgerr_attrs
> + * if NETLINK_EXT_ACK was set
> + */
> +};
> +
> +/**
> + * enum nlmsgerr_attrs - netlink error message attributes
> + * @NLMSGERR_ATTR_UNUSED: unused
> + * @NLMSGERR_ATTR_MSG: error message string (string)
> + * @NLMSGERR_ATTR_OFFS: error offset in the original message (u32)
> + * @NLMSGERR_ATTR_ATTR: top-level attribute that caused the error
> + * (or is missing, u16)
> + */
> +enum nlmsgerr_attrs {
> + NLMSGERR_ATTR_UNUSED,
> + NLMSGERR_ATTR_MSG,
> + NLMSGERR_ATTR_OFFS,
> + NLMSGERR_ATTR_ATTR,
can you add __NLMSGERR_ATTR_MAX and
#define NLMSGERR_ATTR_MAX (__NLMSGERR_ATTR_MAX - 1)
next prev parent reply other threads:[~2017-04-08 20:14 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 17:48 [PATCH 0/5] extended netlink ACK reporting Johannes Berg
2017-04-08 17:48 ` Johannes Berg
2017-04-08 17:48 ` [PATCH 1/5] netlink: extended " Johannes Berg
2017-04-08 18:26 ` David Ahern
2017-04-08 18:34 ` Jiri Pirko
2017-04-08 18:37 ` Johannes Berg
2017-04-08 18:40 ` Jiri Pirko
2017-04-08 20:13 ` Johannes Berg
2017-04-08 20:13 ` Johannes Berg
2017-04-09 17:43 ` David Ahern
2017-04-09 17:43 ` David Ahern
2017-04-10 6:18 ` Johannes Berg
2017-04-13 13:27 ` Nicolas Dichtel
2017-04-13 13:27 ` Nicolas Dichtel
2017-04-13 13:29 ` Johannes Berg
2017-04-13 14:05 ` Nicolas Dichtel
2017-04-13 14:05 ` Nicolas Dichtel
2017-04-13 19:24 ` Johannes Berg
2017-04-13 19:24 ` Johannes Berg
[not found] ` <1492111480.29526.7.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-13 21:44 ` Joe Stringer
2017-04-18 9:41 ` Johannes Berg
2017-04-18 9:41 ` Johannes Berg
2017-04-18 23:46 ` Joe Stringer
2017-04-18 23:46 ` Joe Stringer
2017-04-16 14:40 ` second wave of netlink " Jamal Hadi Salim
2017-04-16 14:40 ` Jamal Hadi Salim
2017-04-16 14:45 ` David Ahern
2017-04-16 14:45 ` David Ahern
2017-04-16 14:48 ` Jamal Hadi Salim
2017-04-16 14:48 ` Jamal Hadi Salim
2017-04-16 14:50 ` David Ahern
2017-04-16 14:50 ` David Ahern
2017-04-16 16:55 ` David Ahern
2017-04-16 16:55 ` David Ahern
2017-04-08 18:36 ` [PATCH 1/5] netlink: " David Ahern
2017-04-08 18:36 ` David Ahern
2017-04-08 18:37 ` Johannes Berg
2017-04-08 18:37 ` Johannes Berg
2017-04-08 20:14 ` David Ahern [this message]
2017-04-08 17:48 ` [PATCH 2/5] genetlink: pass extended ACK report down Johannes Berg
2017-04-08 17:48 ` [PATCH 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-08 17:48 ` Johannes Berg
2017-04-08 17:48 ` [PATCH 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
2017-04-08 18:50 ` David Ahern
2017-04-08 18:50 ` David Ahern
2017-04-08 20:15 ` Johannes Berg
2017-04-08 20:15 ` Johannes Berg
2017-04-08 17:49 ` [PATCH 5/5] netlink: pass extended ACK struct where available Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=647a29e0-fd0d-9bba-e38f-e73dc35ae414@cumulusnetworks.com \
--to=dsa@cumulusnetworks.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.