All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Stringer <joe@ovn.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@redhat.com>, ovs dev <dev@openvswitch.org>,
	David Ahern <dsa@cumulusnetworks.com>,
	Pravin Shelar <pshelar@nicira.com>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	linux-wireless@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	netdev <netdev@vger.kernel.org>, Greg Rose <gvrose8192@gmail.com>
Subject: Re: [PATCH 1/5] netlink: extended ACK reporting
Date: Tue, 18 Apr 2017 16:46:15 -0700	[thread overview]
Message-ID: <CAPWQB7FeSe6dMBObgFGcpJa5eLGYA81gTiEG=9PCtstiJxfgqQ@mail.gmail.com> (raw)
In-Reply-To: <1492508494.2472.11.camel@sipsolutions.net>

On 18 April 2017 at 02:41, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Thu, 2017-04-13 at 14:44 -0700, Joe Stringer wrote
> (something that never made it to the list, due to HTML formatting)
>>
>> I think that OVS was doing some more elaborate validation than most
>> users, so over time we picked up a bunch of extra parsing code that
>> layers on top of nla_parse(). I took a look at trying to broaden this
>> and make it useful to other users a while ago, but when I posted
>> there wasn't much interest from others on it so I just moved on.
>> Maybe it's about time to pick that back up.
>
> Ah, ok. I didn't realize it was actually on top of nla_parse(). Some of
> this does seem rather useful though, and having more expressive policy
> would seem very useful too - I'd love to be able to express nesting
> better, for example.

Ah, correction - nla_parse() is used in some parts but not all of it.
More expressive policy sounds useful for OVS cases too.

WARNING: multiple messages have this Message-ID (diff)
From: Joe Stringer <joe-LZ6Gd1LRuIk@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: ovs dev <dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org>,
	Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>,
	netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jamal Hadi Salim <jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org>,
	David Ahern
	<dsa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>,
	Nicolas Dichtel
	<nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>,
	Pablo Neira Ayuso <pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org>
Subject: Re: [PATCH 1/5] netlink: extended ACK reporting
Date: Tue, 18 Apr 2017 16:46:15 -0700	[thread overview]
Message-ID: <CAPWQB7FeSe6dMBObgFGcpJa5eLGYA81gTiEG=9PCtstiJxfgqQ@mail.gmail.com> (raw)
In-Reply-To: <1492508494.2472.11.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>

On 18 April 2017 at 02:41, Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> On Thu, 2017-04-13 at 14:44 -0700, Joe Stringer wrote
> (something that never made it to the list, due to HTML formatting)
>>
>> I think that OVS was doing some more elaborate validation than most
>> users, so over time we picked up a bunch of extra parsing code that
>> layers on top of nla_parse(). I took a look at trying to broaden this
>> and make it useful to other users a while ago, but when I posted
>> there wasn't much interest from others on it so I just moved on.
>> Maybe it's about time to pick that back up.
>
> Ah, ok. I didn't realize it was actually on top of nla_parse(). Some of
> this does seem rather useful though, and having more expressive policy
> would seem very useful too - I'd love to be able to express nesting
> better, for example.

Ah, correction - nla_parse() is used in some parts but not all of it.
More expressive policy sounds useful for OVS cases too.

  reply	other threads:[~2017-04-18 23:54 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08 17:48 [PATCH 0/5] extended netlink ACK reporting Johannes Berg
2017-04-08 17:48 ` Johannes Berg
2017-04-08 17:48 ` [PATCH 1/5] netlink: extended " Johannes Berg
2017-04-08 18:26   ` David Ahern
2017-04-08 18:34   ` Jiri Pirko
2017-04-08 18:37     ` Johannes Berg
2017-04-08 18:40       ` Jiri Pirko
2017-04-08 20:13         ` Johannes Berg
2017-04-08 20:13           ` Johannes Berg
2017-04-09 17:43         ` David Ahern
2017-04-09 17:43           ` David Ahern
2017-04-10  6:18           ` Johannes Berg
2017-04-13 13:27             ` Nicolas Dichtel
2017-04-13 13:27               ` Nicolas Dichtel
2017-04-13 13:29               ` Johannes Berg
2017-04-13 14:05                 ` Nicolas Dichtel
2017-04-13 14:05                   ` Nicolas Dichtel
2017-04-13 19:24                   ` Johannes Berg
2017-04-13 19:24                     ` Johannes Berg
     [not found]                     ` <1492111480.29526.7.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-04-13 21:44                       ` Joe Stringer
2017-04-18  9:41                         ` Johannes Berg
2017-04-18  9:41                           ` Johannes Berg
2017-04-18 23:46                           ` Joe Stringer [this message]
2017-04-18 23:46                             ` Joe Stringer
2017-04-16 14:40                     ` second wave of netlink " Jamal Hadi Salim
2017-04-16 14:40                       ` Jamal Hadi Salim
2017-04-16 14:45                       ` David Ahern
2017-04-16 14:45                         ` David Ahern
2017-04-16 14:48                         ` Jamal Hadi Salim
2017-04-16 14:48                           ` Jamal Hadi Salim
2017-04-16 14:50                           ` David Ahern
2017-04-16 14:50                             ` David Ahern
2017-04-16 16:55                       ` David Ahern
2017-04-16 16:55                         ` David Ahern
2017-04-08 18:36   ` [PATCH 1/5] netlink: " David Ahern
2017-04-08 18:36     ` David Ahern
2017-04-08 18:37     ` Johannes Berg
2017-04-08 18:37       ` Johannes Berg
2017-04-08 20:14   ` David Ahern
2017-04-08 17:48 ` [PATCH 2/5] genetlink: pass extended ACK report down Johannes Berg
2017-04-08 17:48 ` [PATCH 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-08 17:48   ` Johannes Berg
2017-04-08 17:48 ` [PATCH 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
2017-04-08 18:50   ` David Ahern
2017-04-08 18:50     ` David Ahern
2017-04-08 20:15     ` Johannes Berg
2017-04-08 20:15       ` Johannes Berg
2017-04-08 17:49 ` [PATCH 5/5] netlink: pass extended ACK struct where available Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPWQB7FeSe6dMBObgFGcpJa5eLGYA81gTiEG=9PCtstiJxfgqQ@mail.gmail.com' \
    --to=joe@ovn.org \
    --cc=dev@openvswitch.org \
    --cc=dsa@cumulusnetworks.com \
    --cc=gvrose8192@gmail.com \
    --cc=jbenc@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pablo@netfilter.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.