From: Marek Szyprowski <m.szyprowski@samsung.com> To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>, linux-clk@vger.kernel.org, sboyd@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne <nsaenz@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] clk: bcm2835: Switch to clk_divider.determine_rate Date: Mon, 5 Jul 2021 08:57:56 +0200 [thread overview] Message-ID: <647c4c32-f4e6-dbea-66b9-f92bc502525e@samsung.com> (raw) In-Reply-To: <20210702225145.2643303-4-martin.blumenstingl@googlemail.com> On 03.07.2021 00:51, Martin Blumenstingl wrote: > .determine_rate is meant to replace .round_rate in CCF in the future. > Switch over to .determine_rate now that clk_divider_ops has gained > support for that. > > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-rpi-kernel@lists.infradead.org > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/clk/bcm/clk-bcm2835.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 1ac803e14fa3..a254512965eb 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -805,11 +805,10 @@ static int bcm2835_pll_divider_is_on(struct clk_hw *hw) > return !(cprman_read(cprman, data->a2w_reg) & A2W_PLL_CHANNEL_DISABLE); > } > > -static long bcm2835_pll_divider_round_rate(struct clk_hw *hw, > - unsigned long rate, > - unsigned long *parent_rate) > +static int bcm2835_pll_divider_determine_rate(struct clk_hw *hw, > + struct clk_rate_request *req) > { > - return clk_divider_ops.round_rate(hw, rate, parent_rate); > + return clk_divider_ops.determine_rate(hw, req); > } > > static unsigned long bcm2835_pll_divider_get_rate(struct clk_hw *hw, > @@ -901,7 +900,7 @@ static const struct clk_ops bcm2835_pll_divider_clk_ops = { > .unprepare = bcm2835_pll_divider_off, > .recalc_rate = bcm2835_pll_divider_get_rate, > .set_rate = bcm2835_pll_divider_set_rate, > - .round_rate = bcm2835_pll_divider_round_rate, > + .determine_rate = bcm2835_pll_divider_determine_rate, > .debug_init = bcm2835_pll_divider_debug_init, > }; > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com> To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>, linux-clk@vger.kernel.org, sboyd@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne <nsaenz@kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH v1 3/6] clk: bcm2835: Switch to clk_divider.determine_rate Date: Mon, 5 Jul 2021 08:57:56 +0200 [thread overview] Message-ID: <647c4c32-f4e6-dbea-66b9-f92bc502525e@samsung.com> (raw) In-Reply-To: <20210702225145.2643303-4-martin.blumenstingl@googlemail.com> On 03.07.2021 00:51, Martin Blumenstingl wrote: > .determine_rate is meant to replace .round_rate in CCF in the future. > Switch over to .determine_rate now that clk_divider_ops has gained > support for that. > > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: Ray Jui <rjui@broadcom.com> > Cc: Scott Branden <sbranden@broadcom.com> > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-rpi-kernel@lists.infradead.org > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/clk/bcm/clk-bcm2835.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 1ac803e14fa3..a254512965eb 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -805,11 +805,10 @@ static int bcm2835_pll_divider_is_on(struct clk_hw *hw) > return !(cprman_read(cprman, data->a2w_reg) & A2W_PLL_CHANNEL_DISABLE); > } > > -static long bcm2835_pll_divider_round_rate(struct clk_hw *hw, > - unsigned long rate, > - unsigned long *parent_rate) > +static int bcm2835_pll_divider_determine_rate(struct clk_hw *hw, > + struct clk_rate_request *req) > { > - return clk_divider_ops.round_rate(hw, rate, parent_rate); > + return clk_divider_ops.determine_rate(hw, req); > } > > static unsigned long bcm2835_pll_divider_get_rate(struct clk_hw *hw, > @@ -901,7 +900,7 @@ static const struct clk_ops bcm2835_pll_divider_clk_ops = { > .unprepare = bcm2835_pll_divider_off, > .recalc_rate = bcm2835_pll_divider_get_rate, > .set_rate = bcm2835_pll_divider_set_rate, > - .round_rate = bcm2835_pll_divider_round_rate, > + .determine_rate = bcm2835_pll_divider_determine_rate, > .debug_init = bcm2835_pll_divider_debug_init, > }; > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-05 6:58 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-02 22:51 [PATCH v1 0/6] clk: switch dividers to .determine_rate Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-07-02 22:51 ` [PATCH v1 1/6] clk: divider: Implement and wire up .determine_rate by default Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-10-14 9:55 ` Alex Bee 2021-10-14 9:55 ` Alex Bee 2021-10-14 9:55 ` Alex Bee 2021-10-14 12:11 ` Martin Blumenstingl 2021-10-14 12:11 ` Martin Blumenstingl 2021-10-14 12:11 ` Martin Blumenstingl 2021-10-14 21:34 ` Martin Blumenstingl 2021-10-14 21:34 ` Martin Blumenstingl 2021-10-14 21:34 ` Martin Blumenstingl 2021-10-14 22:52 ` Stephen Boyd 2021-10-14 22:52 ` Stephen Boyd 2021-10-14 22:52 ` Stephen Boyd 2021-10-15 12:05 ` [PATCH] clk: composite: Also consider .determine_rate for rate + mux composites Martin Blumenstingl 2021-10-15 12:05 ` Martin Blumenstingl 2021-10-15 12:05 ` Martin Blumenstingl 2021-10-15 21:27 ` Stephen Boyd 2021-10-15 21:27 ` Stephen Boyd 2021-10-15 21:27 ` Stephen Boyd 2021-11-01 20:19 ` Guillaume Tucker 2021-11-01 20:19 ` Guillaume Tucker 2021-11-01 20:19 ` Guillaume Tucker 2021-11-01 20:58 ` Martin Blumenstingl 2021-11-01 20:58 ` Martin Blumenstingl 2021-11-01 20:58 ` Martin Blumenstingl 2021-11-01 21:59 ` Robin Murphy 2021-11-01 21:59 ` Robin Murphy 2021-11-01 21:59 ` Robin Murphy 2021-11-01 22:11 ` Robin Murphy 2021-11-01 22:11 ` Robin Murphy 2021-11-01 22:11 ` Robin Murphy 2021-11-01 22:41 ` Alex Bee 2021-11-01 22:41 ` Alex Bee 2021-11-01 22:41 ` Alex Bee 2021-11-02 7:58 ` Guillaume Tucker 2021-11-02 7:58 ` Guillaume Tucker 2021-11-02 7:58 ` Guillaume Tucker 2021-11-02 21:40 ` LABBE Corentin 2021-11-02 21:40 ` Corentin Labbe 2021-11-02 21:40 ` LABBE Corentin 2021-11-02 21:40 ` LABBE Corentin 2021-10-15 19:14 ` [PATCH v1 1/6] clk: divider: Implement and wire up .determine_rate by default Alex Bee 2021-10-15 19:14 ` Alex Bee 2021-10-15 19:14 ` Alex Bee 2021-10-15 21:31 ` Stephen Boyd 2021-10-15 21:31 ` Stephen Boyd 2021-10-15 21:31 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 2/6] clk: imx: clk-divider-gate: Switch to clk_divider.determine_rate Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-07-19 10:43 ` Abel Vesa 2021-07-19 10:43 ` Abel Vesa 2021-07-29 11:30 ` Abel Vesa 2021-07-29 11:30 ` Abel Vesa 2021-07-02 22:51 ` [PATCH v1 3/6] clk: bcm2835: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-07-05 6:57 ` Marek Szyprowski [this message] 2021-07-05 6:57 ` Marek Szyprowski 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 4/6] clk: stm32f4: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 5/6] clk: stm32h7: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-07-02 22:51 ` [PATCH v1 6/6] clk: stm32mp1: " Martin Blumenstingl 2021-07-02 22:51 ` Martin Blumenstingl 2021-08-06 1:10 ` Stephen Boyd 2021-08-06 1:10 ` Stephen Boyd 2021-08-03 19:32 ` [PATCH v1 0/6] clk: switch dividers to .determine_rate Martin Blumenstingl 2021-08-03 19:32 ` Martin Blumenstingl 2021-08-03 20:16 ` Stephen Boyd 2021-08-03 20:16 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=647c4c32-f4e6-dbea-66b9-f92bc502525e@samsung.com \ --to=m.szyprowski@samsung.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=martin.blumenstingl@googlemail.com \ --cc=nsaenz@kernel.org \ --cc=rjui@broadcom.com \ --cc=sboyd@kernel.org \ --cc=sbranden@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.