All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: rockchip: fix rk3368 cpuclk divider offsets
@ 2015-12-01 21:31 Heiko Stübner
  2015-12-03 15:47   ` Heiko Stübner
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stübner @ 2015-12-01 21:31 UTC (permalink / raw)
  To: mturquette, sboyd; +Cc: linux-clk, linux-rockchip, Xing Zheng

Due to a copy-paste error the the rk3368 cpuclk settings were acessing
rk3288-specific register offsets. This never caused problems till now,
as cpu frequency scaling in't used currently at all.

Reported-by: Xing Zheng <zhengxing@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
Posted for reference, as described above this doesn't cause any breakage,
so can probably simply wait for 4.5

 drivers/clk/rockchip/clk-rk3368.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/rockchip/clk-rk3368.c b/drivers/clk/rockchip/clk-rk3368.c
index 7e6b783..2ae9c57 100644
--- a/drivers/clk/rockchip/clk-rk3368.c
+++ b/drivers/clk/rockchip/clk-rk3368.c
@@ -184,13 +184,13 @@ static const struct rockchip_cpuclk_reg_data rk3368_cpuclkl_data = {
 
 #define RK3368_CLKSEL0(_offs, _aclkm)					\
 	{								\
-		.reg = RK3288_CLKSEL_CON(0 + _offs),			\
+		.reg = RK3368_CLKSEL_CON(0 + _offs),			\
 		.val = HIWORD_UPDATE(_aclkm, RK3368_DIV_ACLKM_MASK,	\
 				RK3368_DIV_ACLKM_SHIFT),		\
 	}
 #define RK3368_CLKSEL1(_offs, _atclk, _pdbg)				\
 	{								\
-		.reg = RK3288_CLKSEL_CON(1 + _offs),			\
+		.reg = RK3368_CLKSEL_CON(1 + _offs),			\
 		.val = HIWORD_UPDATE(_atclk, RK3368_DIV_ATCLK_MASK,	\
 				RK3368_DIV_ATCLK_SHIFT) |		\
 		       HIWORD_UPDATE(_pdbg, RK3368_DIV_PCLK_DBG_MASK,	\
-- 
2.6.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: rockchip: fix rk3368 cpuclk divider offsets
  2015-12-01 21:31 [PATCH] clk: rockchip: fix rk3368 cpuclk divider offsets Heiko Stübner
@ 2015-12-03 15:47   ` Heiko Stübner
  0 siblings, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2015-12-03 15:47 UTC (permalink / raw)
  To: mturquette; +Cc: sboyd, linux-clk, linux-rockchip, Xing Zheng

Am Dienstag, 1. Dezember 2015, 22:31:56 schrieb Heiko St=FCbner:
> Due to a copy-paste error the the rk3368 cpuclk settings were acessin=
g
> rk3288-specific register offsets. This never caused problems till now=
,
> as cpu frequency scaling in't used currently at all.
>=20
> Reported-by: Xing Zheng <zhengxing@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

applied to my clock-branch for 4.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: rockchip: fix rk3368 cpuclk divider offsets
@ 2015-12-03 15:47   ` Heiko Stübner
  0 siblings, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2015-12-03 15:47 UTC (permalink / raw)
  To: mturquette; +Cc: sboyd, linux-clk, linux-rockchip, Xing Zheng

Am Dienstag, 1. Dezember 2015, 22:31:56 schrieb Heiko Stübner:
> Due to a copy-paste error the the rk3368 cpuclk settings were acessing
> rk3288-specific register offsets. This never caused problems till now,
> as cpu frequency scaling in't used currently at all.
> 
> Reported-by: Xing Zheng <zhengxing@rock-chips.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

applied to my clock-branch for 4.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-03 15:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-01 21:31 [PATCH] clk: rockchip: fix rk3368 cpuclk divider offsets Heiko Stübner
2015-12-03 15:47 ` Heiko Stübner
2015-12-03 15:47   ` Heiko Stübner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.