All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: v5.9-rc1 nvme_rdma regression?
       [not found]   ` <20200623084420.GA5886@lst.de>
@ 2020-06-23 15:21     ` Bart Van Assche
  0 siblings, 0 replies; only message in thread
From: Bart Van Assche @ 2020-06-23 15:21 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linux-nvme

On 2020-06-23 01:44, Christoph Hellwig wrote:
> Actually, please just try this patch:
> 
> 
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 97b1054efb8409..6d5c4495f352ea 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1696,9 +1696,10 @@ static void nvme_rdma_process_nvme_rsp(struct nvme_rdma_queue *queue,
>  			nvme_rdma_error_recovery(queue->ctrl);
>  		}
>  		/* the local invalidation completion will end the request */
> -	} else {
> -		nvme_rdma_end_request(req);
> +		return;
>  	}
> +
> +	nvme_rdma_end_request(req);
>  }
>  
>  static void nvme_rdma_recv_done(struct ib_cq *cq, struct ib_wc *wc)

That helps, so feel free to add:

Tested-by: Bart van Assche <bvanassche@acm.org>

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-23 15:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <593c1a8b-f5c5-fda1-99f6-1417186f0fff@acm.org>
     [not found] ` <20200623084232.GA5762@lst.de>
     [not found]   ` <20200623084420.GA5886@lst.de>
2020-06-23 15:21     ` v5.9-rc1 nvme_rdma regression? Bart Van Assche

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.