All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nvmet: fix the structure member indentation
@ 2018-11-19 23:16 Chaitanya Kulkarni
  2018-11-19 23:18 ` Logan Gunthorpe
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2018-11-19 23:16 UTC (permalink / raw)


This is a cleanup patch which fixes the structure member indentation
introduced by the p2p:

commit c6925093d0b2 ("nvmet: Optionally use PCI P2P memory").
We don't change any functionality in this patch.

This is needed so that any future members will also follow the uniform
indentation.

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
---
 drivers/nvme/target/nvmet.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
index 03988fe9d915..ac2f7e58552c 100644
--- a/drivers/nvme/target/nvmet.h
+++ b/drivers/nvme/target/nvmet.h
@@ -199,8 +199,8 @@ struct nvmet_ctrl {
 	char			subsysnqn[NVMF_NQN_FIELD_LEN];
 	char			hostnqn[NVMF_NQN_FIELD_LEN];
 
-	struct device *p2p_client;
-	struct radix_tree_root p2p_ns_map;
+	struct device		*p2p_client;
+	struct radix_tree_root	p2p_ns_map;
 };
 
 struct nvmet_subsys {
@@ -313,8 +313,8 @@ struct nvmet_req {
 	void (*execute)(struct nvmet_req *req);
 	const struct nvmet_fabrics_ops *ops;
 
-	struct pci_dev *p2p_dev;
-	struct device *p2p_client;
+	struct pci_dev		*p2p_dev;
+	struct device		*p2p_client;
 };
 
 extern struct workqueue_struct *buffered_io_wq;
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] nvmet: fix the structure member indentation
  2018-11-19 23:16 [PATCH] nvmet: fix the structure member indentation Chaitanya Kulkarni
@ 2018-11-19 23:18 ` Logan Gunthorpe
  2018-11-20  1:43 ` Sagi Grimberg
  2018-11-20  9:35 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Logan Gunthorpe @ 2018-11-19 23:18 UTC (permalink / raw)




On 2018-11-19 4:16 p.m., Chaitanya Kulkarni wrote:
> This is a cleanup patch which fixes the structure member indentation
> introduced by the p2p:
> 
> commit c6925093d0b2 ("nvmet: Optionally use PCI P2P memory").
> We don't change any functionality in this patch.
> 
> This is needed so that any future members will also follow the uniform
> indentation.
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>

Acked-by: Logan Gunthorpe <logang at deltatee.com>


> ---
>  drivers/nvme/target/nvmet.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/nvme/target/nvmet.h b/drivers/nvme/target/nvmet.h
> index 03988fe9d915..ac2f7e58552c 100644
> --- a/drivers/nvme/target/nvmet.h
> +++ b/drivers/nvme/target/nvmet.h
> @@ -199,8 +199,8 @@ struct nvmet_ctrl {
>  	char			subsysnqn[NVMF_NQN_FIELD_LEN];
>  	char			hostnqn[NVMF_NQN_FIELD_LEN];
>  
> -	struct device *p2p_client;
> -	struct radix_tree_root p2p_ns_map;
> +	struct device		*p2p_client;
> +	struct radix_tree_root	p2p_ns_map;
>  };
>  
>  struct nvmet_subsys {
> @@ -313,8 +313,8 @@ struct nvmet_req {
>  	void (*execute)(struct nvmet_req *req);
>  	const struct nvmet_fabrics_ops *ops;
>  
> -	struct pci_dev *p2p_dev;
> -	struct device *p2p_client;
> +	struct pci_dev		*p2p_dev;
> +	struct device		*p2p_client;
>  };
>  
>  extern struct workqueue_struct *buffered_io_wq;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] nvmet: fix the structure member indentation
  2018-11-19 23:16 [PATCH] nvmet: fix the structure member indentation Chaitanya Kulkarni
  2018-11-19 23:18 ` Logan Gunthorpe
@ 2018-11-20  1:43 ` Sagi Grimberg
  2018-11-20  9:35 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2018-11-20  1:43 UTC (permalink / raw)


Reviewed-by: Sagi Grimberg <sagi at grimberg.me>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] nvmet: fix the structure member indentation
  2018-11-19 23:16 [PATCH] nvmet: fix the structure member indentation Chaitanya Kulkarni
  2018-11-19 23:18 ` Logan Gunthorpe
  2018-11-20  1:43 ` Sagi Grimberg
@ 2018-11-20  9:35 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2018-11-20  9:35 UTC (permalink / raw)


Thanks, applied to nvme-4.21.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-20  9:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 23:16 [PATCH] nvmet: fix the structure member indentation Chaitanya Kulkarni
2018-11-19 23:18 ` Logan Gunthorpe
2018-11-20  1:43 ` Sagi Grimberg
2018-11-20  9:35 ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.