All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v5 3/4] drm/i915/perf: prepare driver to receive multiple ctx handles
Date: Tue, 14 Apr 2020 12:50:57 +0300	[thread overview]
Message-ID: <64e3375e-5a79-8545-679e-f81e4e0a22f5@intel.com> (raw)
In-Reply-To: <20200413233409.GC61072@orsosgc001.amr.corp.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1047 bytes --]

On 14/04/2020 02:34, Umesh Nerlige Ramappa wrote:
>> -         * When set globally, we use a low priority kernel context,
>> -         * so it will effectively take effect when idle.
>> -         */
>> -        ret = emit_oa_config(stream, config, ce,
>> +        ret = emit_oa_config(stream, config,
>> +                     stream->config_context,
>>                      active, false /* global */);
>>         if (ret)
>>             goto err_active;
>>
>> -        ret = emit_oa_config(stream, config, ce,
>> +        ret = emit_oa_config(stream, config,
>> +                     stream->config_context,
>>                      active, true /* global */);
>
> I see emit_oa_config is called twice in all places (except the for 
> loop below). Maybe all those places, these 2 calls can be wrapped into 
> one function.
>
> Thanks,
> Umesh 

Good point, I'll add a helper.


Thanks,


-Lionel


[-- Attachment #1.2: Type: text/html, Size: 1802 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-14  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  9:17 [Intel-gfx] [PATCH v5 1/4] drm/i915/perf: break OA config buffer object in 2 Lionel Landwerlin
2020-04-09  9:17 ` [Intel-gfx] [PATCH v5 2/4] drm/i915/perf: stop using the kernel context Lionel Landwerlin
2020-04-09  9:17 ` [Intel-gfx] [PATCH v5 3/4] drm/i915/perf: prepare driver to receive multiple ctx handles Lionel Landwerlin
2020-04-13 23:34   ` Umesh Nerlige Ramappa
2020-04-14  9:50     ` Lionel Landwerlin [this message]
2020-04-09  9:17 ` [Intel-gfx] [PATCH v5 4/4] drm/i915/perf: enable filtering on multiple contexts Lionel Landwerlin
2020-04-09 12:17 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v5,1/4] drm/i915/perf: break OA config buffer object in 2 Patchwork
2020-04-13 23:24 ` [Intel-gfx] [PATCH v5 1/4] " Umesh Nerlige Ramappa
2020-04-14  9:21   ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64e3375e-5a79-8545-679e-f81e4e0a22f5@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.