All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function
Date: Thu, 29 Jun 2017 18:39:46 +0900	[thread overview]
Message-ID: <650f82d1-528f-895a-43f9-341ac5058a5e@samsung.com> (raw)
In-Reply-To: <1497278179-6439-1-git-send-email-j-keerthy@ti.com>

Hi,

On 06/12/2017 11:36 PM, Keerthy wrote:
> The function wrongly returned an integer while it is supposed to
> return boolean. Fix that.
> 
> Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support")
> Reported-by:Nishanth Menon <nm@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>

Applied on u-boot-mmc for PMIC. Thanks!

Best Regards,
Jaehoon Chung

> ---
>  drivers/power/regulator/lp87565_regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
> index 2a0b8ca..e5de578 100644
> --- a/drivers/power/regulator/lp87565_regulator.c
> +++ b/drivers/power/regulator/lp87565_regulator.c
> @@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev)
>  
>  	ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
>  	if (ret)
> -		return ret;
> +		return false;
>  
>  	return enable;
>  }
> 

  parent reply	other threads:[~2017-06-29  9:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170612143742epcas2p36e9887bed02fb5112d4fc540c9360bd3@epcas2p3.samsung.com>
2017-06-12 14:36 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Keerthy
2017-06-12 14:36   ` [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function Keerthy
2017-06-29  9:40     ` Jaehoon Chung
2017-06-29  9:59       ` Keerthy
2017-06-29  9:39   ` Jaehoon Chung [this message]
2017-06-29  9:59     ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Keerthy
2017-06-29 10:24       ` Jaehoon Chung
2017-06-29 10:26         ` Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650f82d1-528f-895a-43f9-341ac5058a5e@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.