* [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function
@ 2017-06-12 14:36 ` Keerthy
2017-06-12 14:36 ` [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function Keerthy
2017-06-29 9:39 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Jaehoon Chung
0 siblings, 2 replies; 8+ messages in thread
From: Keerthy @ 2017-06-12 14:36 UTC (permalink / raw)
To: u-boot
The function wrongly returned an integer while it is supposed to
return boolean. Fix that.
Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support")
Reported-by:Nishanth Menon <nm@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/power/regulator/lp87565_regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
index 2a0b8ca..e5de578 100644
--- a/drivers/power/regulator/lp87565_regulator.c
+++ b/drivers/power/regulator/lp87565_regulator.c
@@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev)
ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
if (ret)
- return ret;
+ return false;
return enable;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function
2017-06-12 14:36 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Keerthy
@ 2017-06-12 14:36 ` Keerthy
2017-06-29 9:40 ` Jaehoon Chung
2017-06-29 9:39 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Jaehoon Chung
1 sibling, 1 reply; 8+ messages in thread
From: Keerthy @ 2017-06-12 14:36 UTC (permalink / raw)
To: u-boot
The functions wrongly returned an integer while it is supposed to
return boolean. Fix that.
Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support")
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
Changes in v2:
* Squashed patch 2 and 3 of v1 into 1 patch.
drivers/power/regulator/lp873x_regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/regulator/lp873x_regulator.c b/drivers/power/regulator/lp873x_regulator.c
index dcb19ff..8c26baf 100644
--- a/drivers/power/regulator/lp873x_regulator.c
+++ b/drivers/power/regulator/lp873x_regulator.c
@@ -263,7 +263,7 @@ static bool ldo_get_enable(struct udevice *dev)
ret = lp873x_ldo_enable(dev, PMIC_OP_GET, &enable);
if (ret)
- return ret;
+ return false;
return enable;
}
@@ -318,7 +318,7 @@ static bool buck_get_enable(struct udevice *dev)
ret = lp873x_buck_enable(dev, PMIC_OP_GET, &enable);
if (ret)
- return ret;
+ return false;
return enable;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function
2017-06-12 14:36 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Keerthy
2017-06-12 14:36 ` [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function Keerthy
@ 2017-06-29 9:39 ` Jaehoon Chung
2017-06-29 9:59 ` Keerthy
1 sibling, 1 reply; 8+ messages in thread
From: Jaehoon Chung @ 2017-06-29 9:39 UTC (permalink / raw)
To: u-boot
Hi,
On 06/12/2017 11:36 PM, Keerthy wrote:
> The function wrongly returned an integer while it is supposed to
> return boolean. Fix that.
>
> Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support")
> Reported-by:Nishanth Menon <nm@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
Applied on u-boot-mmc for PMIC. Thanks!
Best Regards,
Jaehoon Chung
> ---
> drivers/power/regulator/lp87565_regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
> index 2a0b8ca..e5de578 100644
> --- a/drivers/power/regulator/lp87565_regulator.c
> +++ b/drivers/power/regulator/lp87565_regulator.c
> @@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev)
>
> ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
> if (ret)
> - return ret;
> + return false;
>
> return enable;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function
2017-06-12 14:36 ` [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function Keerthy
@ 2017-06-29 9:40 ` Jaehoon Chung
2017-06-29 9:59 ` Keerthy
0 siblings, 1 reply; 8+ messages in thread
From: Jaehoon Chung @ 2017-06-29 9:40 UTC (permalink / raw)
To: u-boot
On 06/12/2017 11:36 PM, Keerthy wrote:
> The functions wrongly returned an integer while it is supposed to
> return boolean. Fix that.
>
> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support")
> Signed-off-by: Keerthy <j-keerthy@ti.com>
Applied to u-boot-mmc for pmic. Thanks!
Best Regards,
Jaehoon Chung
> ---
>
> Changes in v2:
>
> * Squashed patch 2 and 3 of v1 into 1 patch.
>
> drivers/power/regulator/lp873x_regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/regulator/lp873x_regulator.c b/drivers/power/regulator/lp873x_regulator.c
> index dcb19ff..8c26baf 100644
> --- a/drivers/power/regulator/lp873x_regulator.c
> +++ b/drivers/power/regulator/lp873x_regulator.c
> @@ -263,7 +263,7 @@ static bool ldo_get_enable(struct udevice *dev)
>
> ret = lp873x_ldo_enable(dev, PMIC_OP_GET, &enable);
> if (ret)
> - return ret;
> + return false;
>
> return enable;
> }
> @@ -318,7 +318,7 @@ static bool buck_get_enable(struct udevice *dev)
>
> ret = lp873x_buck_enable(dev, PMIC_OP_GET, &enable);
> if (ret)
> - return ret;
> + return false;
>
> return enable;
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function
2017-06-29 9:40 ` Jaehoon Chung
@ 2017-06-29 9:59 ` Keerthy
0 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2017-06-29 9:59 UTC (permalink / raw)
To: u-boot
On Thursday 29 June 2017 03:10 PM, Jaehoon Chung wrote:
> On 06/12/2017 11:36 PM, Keerthy wrote:
>> The functions wrongly returned an integer while it is supposed to
>> return boolean. Fix that.
>>
>> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support")
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> Applied to u-boot-mmc for pmic. Thanks!
Jaehoon,
Oops! This is not needed as per latest discussion here:
https://www.mail-archive.com/u-boot at lists.denx.de/msg253113.html
Regards,
Keerthy
>
> Best Regards,
> Jaehoon Chung
>
>> ---
>>
>> Changes in v2:
>>
>> * Squashed patch 2 and 3 of v1 into 1 patch.
>>
>> drivers/power/regulator/lp873x_regulator.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/power/regulator/lp873x_regulator.c b/drivers/power/regulator/lp873x_regulator.c
>> index dcb19ff..8c26baf 100644
>> --- a/drivers/power/regulator/lp873x_regulator.c
>> +++ b/drivers/power/regulator/lp873x_regulator.c
>> @@ -263,7 +263,7 @@ static bool ldo_get_enable(struct udevice *dev)
>>
>> ret = lp873x_ldo_enable(dev, PMIC_OP_GET, &enable);
>> if (ret)
>> - return ret;
>> + return false;
>>
>> return enable;
>> }
>> @@ -318,7 +318,7 @@ static bool buck_get_enable(struct udevice *dev)
>>
>> ret = lp873x_buck_enable(dev, PMIC_OP_GET, &enable);
>> if (ret)
>> - return ret;
>> + return false;
>>
>> return enable;
>> }
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function
2017-06-29 9:39 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Jaehoon Chung
@ 2017-06-29 9:59 ` Keerthy
2017-06-29 10:24 ` Jaehoon Chung
0 siblings, 1 reply; 8+ messages in thread
From: Keerthy @ 2017-06-29 9:59 UTC (permalink / raw)
To: u-boot
On Thursday 29 June 2017 03:09 PM, Jaehoon Chung wrote:
> Hi,
>
> On 06/12/2017 11:36 PM, Keerthy wrote:
>> The function wrongly returned an integer while it is supposed to
>> return boolean. Fix that.
>>
>> Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support")
>> Reported-by:Nishanth Menon <nm@ti.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> Applied on u-boot-mmc for PMIC. Thanks!
Jaehoon,
Oops! This is not needed as per latest discussion here:
https://www.mail-archive.com/u-boot at lists.denx.de/msg253113.html
Regards,
Keerthy
>
> Best Regards,
> Jaehoon Chung
>
>> ---
>> drivers/power/regulator/lp87565_regulator.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
>> index 2a0b8ca..e5de578 100644
>> --- a/drivers/power/regulator/lp87565_regulator.c
>> +++ b/drivers/power/regulator/lp87565_regulator.c
>> @@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev)
>>
>> ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
>> if (ret)
>> - return ret;
>> + return false;
>>
>> return enable;
>> }
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function
2017-06-29 9:59 ` Keerthy
@ 2017-06-29 10:24 ` Jaehoon Chung
2017-06-29 10:26 ` Keerthy
0 siblings, 1 reply; 8+ messages in thread
From: Jaehoon Chung @ 2017-06-29 10:24 UTC (permalink / raw)
To: u-boot
Hi Keerthy,
On 06/29/2017 06:59 PM, Keerthy wrote:
>
>
> On Thursday 29 June 2017 03:09 PM, Jaehoon Chung wrote:
>> Hi,
>>
>> On 06/12/2017 11:36 PM, Keerthy wrote:
>>> The function wrongly returned an integer while it is supposed to
>>> return boolean. Fix that.
>>>
>>> Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support")
>>> Reported-by:Nishanth Menon <nm@ti.com>
>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>
>> Applied on u-boot-mmc for PMIC. Thanks!
>
> Jaehoon,
>
> Oops! This is not needed as per latest discussion here:
> https://www.mail-archive.com/u-boot at lists.denx.de/msg253113.html
I read it now..i will push patches to u-boot-mmc without your patch v2. :)
I'm doing the build testing now. Thanks!
Best Regards,
Jaehoon Chung
>
> Regards,
> Keerthy
>
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>> ---
>>> drivers/power/regulator/lp87565_regulator.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
>>> index 2a0b8ca..e5de578 100644
>>> --- a/drivers/power/regulator/lp87565_regulator.c
>>> +++ b/drivers/power/regulator/lp87565_regulator.c
>>> @@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev)
>>>
>>> ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
>>> if (ret)
>>> - return ret;
>>> + return false;
>>>
>>> return enable;
>>> }
>>>
>>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function
2017-06-29 10:24 ` Jaehoon Chung
@ 2017-06-29 10:26 ` Keerthy
0 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2017-06-29 10:26 UTC (permalink / raw)
To: u-boot
On Thursday 29 June 2017 03:54 PM, Jaehoon Chung wrote:
> Hi Keerthy,
>
> On 06/29/2017 06:59 PM, Keerthy wrote:
>>
>>
>> On Thursday 29 June 2017 03:09 PM, Jaehoon Chung wrote:
>>> Hi,
>>>
>>> On 06/12/2017 11:36 PM, Keerthy wrote:
>>>> The function wrongly returned an integer while it is supposed to
>>>> return boolean. Fix that.
>>>>
>>>> Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support")
>>>> Reported-by:Nishanth Menon <nm@ti.com>
>>>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>>>
>>> Applied on u-boot-mmc for PMIC. Thanks!
>>
>> Jaehoon,
>>
>> Oops! This is not needed as per latest discussion here:
>> https://www.mail-archive.com/u-boot at lists.denx.de/msg253113.html
>
> I read it now..i will push patches to u-boot-mmc without your patch v2. :)
> I'm doing the build testing now. Thanks!
Cool Thanks :-)
>
> Best Regards,
> Jaehoon Chung
>
>>
>> Regards,
>> Keerthy
>>
>>>
>>> Best Regards,
>>> Jaehoon Chung
>>>
>>>> ---
>>>> drivers/power/regulator/lp87565_regulator.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
>>>> index 2a0b8ca..e5de578 100644
>>>> --- a/drivers/power/regulator/lp87565_regulator.c
>>>> +++ b/drivers/power/regulator/lp87565_regulator.c
>>>> @@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev)
>>>>
>>>> ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
>>>> if (ret)
>>>> - return ret;
>>>> + return false;
>>>>
>>>> return enable;
>>>> }
>>>>
>>>
>>
>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-06-29 10:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170612143742epcas2p36e9887bed02fb5112d4fc540c9360bd3@epcas2p3.samsung.com>
2017-06-12 14:36 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Keerthy
2017-06-12 14:36 ` [U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function Keerthy
2017-06-29 9:40 ` Jaehoon Chung
2017-06-29 9:59 ` Keerthy
2017-06-29 9:39 ` [U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function Jaehoon Chung
2017-06-29 9:59 ` Keerthy
2017-06-29 10:24 ` Jaehoon Chung
2017-06-29 10:26 ` Keerthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.