All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tao Zhou <tao.zhou@linux.dev>, Ingo Molnar <mingo@redhat.com>,
	Tom Zanussi <zanussi@kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Clark Williams <williams@redhat.com>,
	John Kacur <jkacur@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-rt-users@vger.kernel.org,
	linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode
Date: Thu, 25 Nov 2021 15:30:19 +0100	[thread overview]
Message-ID: <65848fd0-0b37-dde6-fa5a-259c07b69f34@kernel.org> (raw)
In-Reply-To: <20211125092018.17e36369@oasis.local.home>

On 11/25/21 15:20, Steven Rostedt wrote:
> On Thu, 25 Nov 2021 14:45:30 +0100
> Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
> 
>>> Or do you think that 1d should be the default, and we have:
>>>
>>> 	tracefs_hist_alloc()	-- 1d histogram
>>> 	tracefs_hist_alloc_2d()	-- 2d histogram
>>> 	tracefs_hist_alloc_nd()	-- Nd histogram?
>>>
>>> ??  
>>
>> IMHO, the function names in your second email sound more intuitive, i.e.,
>> tracefs_hist_alloc()/tracefs_hist_alloc_2d()/tracefs_hist_alloc_nd().
>>
>>> We haven't tagged it yet, so we could change it again (and then your code
>>> will work as is).  
>>
>> two birds with a single stone :-)
> 
> Just to confirm (confused by "second email" above), you prefer that we
> update the API to:
> 
> 	tracefs_hist_alloc()
> 	tracefs_hist_alloc_2d()
> 	tracefs_hist_alloc_nd()
> 
> Right?

Right!

-- Daniel

> Thanks,
> 
> -- Steve
> 


  reply	other threads:[~2021-11-25 14:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 19:26 [PATCH V7 00/14] RTLA: An interface for osnoise/timerlat tracers Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 01/14] rtla: Real-Time Linux Analysis tool Daniel Bristot de Oliveira
2021-11-24 21:28   ` Steven Rostedt
2021-11-25 13:37     ` Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 02/14] rtla: Helper functions for rtla Daniel Bristot de Oliveira
2021-11-24 21:37   ` Steven Rostedt
2021-11-25 13:42     ` Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 03/14] rtla: Add osnoise tool Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 04/14] rtla/osnoise: Add osnoise top mode Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 05/14] rtla/osnoise: Add the hist mode Daniel Bristot de Oliveira
2021-11-24 22:12   ` Steven Rostedt
2021-11-24 22:15     ` Steven Rostedt
2021-11-25 13:45       ` Daniel Bristot de Oliveira
2021-11-25 14:20         ` Steven Rostedt
2021-11-25 14:30           ` Daniel Bristot de Oliveira [this message]
2021-10-29 19:26 ` [PATCH V7 06/14] rtla: Add timerlat tool and timelart top mode Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 07/14] rtla/timerlat: Add timerlat hist mode Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 08/14] rtla: Add Documentation Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 09/14] rtla: Add rtla osnoise man page Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 10/14] rtla: Add rtla osnoise top documentation Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 11/14] rtla: Add rtla osnoise hist documentation Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 12/14] rtla: Add rtla timerlat documentation Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 13/14] rtla: Add rtla timerlat top documentation Daniel Bristot de Oliveira
2021-10-29 19:26 ` [PATCH V7 14/14] rtla: Add rtla timerlat hist documentation Daniel Bristot de Oliveira
2021-11-24 22:11 ` [PATCH V7 00/14] RTLA: An interface for osnoise/timerlat tracers Steven Rostedt
2021-11-25 13:46   ` Daniel Bristot de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65848fd0-0b37-dde6-fa5a-259c07b69f34@kernel.org \
    --to=bristot@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tao.zhou@linux.dev \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    --cc=zanussi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.