All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: meson: odroidc2: readd PHY reset properties
@ 2021-04-07 14:49 ` Stefan Agner
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Agner @ 2021-04-07 14:49 UTC (permalink / raw)
  To: u-boot

The sync of the device tree and dt-bindings from Linux v5.6-rc2
11a48a5a18c6 ("Linux 5.6-rc2") causes Ethernet to break on some
ODROID-C2. The PHY seems to need proper reset timing to be functional
in U-Boot and Linux afterwards. Readd the old PHY reset bindings for
dwmac until we support the new bindings in the PHY node.

Fixes: dd5f2351e99a ("arm64: dts: meson: sync dt and bindings from v5.6-rc2")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/dts/meson-gxbb-odroidc2.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts
index 70fcfb7b06..8b80bbc90b 100644
--- a/arch/arm/dts/meson-gxbb-odroidc2.dts
+++ b/arch/arm/dts/meson-gxbb-odroidc2.dts
@@ -188,6 +188,10 @@
 	phy-handle = <&eth_phy0>;
 	phy-mode = "rgmii";
 
+	snps,reset-gpio = <&gpio GPIOZ_14 0>;
+	snps,reset-delays-us = <0 10000 1000000>;
+	snps,reset-active-low;
+
 	amlogic,tx-delay-ns = <2>;
 
 	mdio {
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: meson: odroidc2: readd PHY reset properties
@ 2021-04-07 14:49 ` Stefan Agner
  0 siblings, 0 replies; 4+ messages in thread
From: Stefan Agner @ 2021-04-07 14:49 UTC (permalink / raw)
  To: narmstrong; +Cc: jbrunet, khilman, u-boot-amlogic, u-boot, Stefan Agner

The sync of the device tree and dt-bindings from Linux v5.6-rc2
11a48a5a18c6 ("Linux 5.6-rc2") causes Ethernet to break on some
ODROID-C2. The PHY seems to need proper reset timing to be functional
in U-Boot and Linux afterwards. Readd the old PHY reset bindings for
dwmac until we support the new bindings in the PHY node.

Fixes: dd5f2351e99a ("arm64: dts: meson: sync dt and bindings from v5.6-rc2")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/dts/meson-gxbb-odroidc2.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts
index 70fcfb7b06..8b80bbc90b 100644
--- a/arch/arm/dts/meson-gxbb-odroidc2.dts
+++ b/arch/arm/dts/meson-gxbb-odroidc2.dts
@@ -188,6 +188,10 @@
 	phy-handle = <&eth_phy0>;
 	phy-mode = "rgmii";
 
+	snps,reset-gpio = <&gpio GPIOZ_14 0>;
+	snps,reset-delays-us = <0 10000 1000000>;
+	snps,reset-active-low;
+
 	amlogic,tx-delay-ns = <2>;
 
 	mdio {
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: meson: odroidc2: readd PHY reset properties
  2021-04-07 14:49 ` Stefan Agner
@ 2021-04-07 15:51   ` Neil Armstrong
  -1 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2021-04-07 15:51 UTC (permalink / raw)
  To: u-boot

On 07/04/2021 16:49, Stefan Agner wrote:
> The sync of the device tree and dt-bindings from Linux v5.6-rc2
> 11a48a5a18c6 ("Linux 5.6-rc2") causes Ethernet to break on some
> ODROID-C2. The PHY seems to need proper reset timing to be functional
> in U-Boot and Linux afterwards. Readd the old PHY reset bindings for
> dwmac until we support the new bindings in the PHY node.
> 
> Fixes: dd5f2351e99a ("arm64: dts: meson: sync dt and bindings from v5.6-rc2")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  arch/arm/dts/meson-gxbb-odroidc2.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts
> index 70fcfb7b06..8b80bbc90b 100644
> --- a/arch/arm/dts/meson-gxbb-odroidc2.dts
> +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts
> @@ -188,6 +188,10 @@
>  	phy-handle = <&eth_phy0>;
>  	phy-mode = "rgmii";
>  
> +	snps,reset-gpio = <&gpio GPIOZ_14 0>;
> +	snps,reset-delays-us = <0 10000 1000000>;
> +	snps,reset-active-low;
> +
>  	amlogic,tx-delay-ns = <2>;
>  
>  	mdio {
> 

Thanks, it's ok but please add the changes to arch/arm/dts/meson-gxbb-odroidc2-u-boot.dtsi
instead, we want to keep the DT files in sync with Linux, local u-boot changes must go into
the -u-boot.dtsi files.

Neil

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson: odroidc2: readd PHY reset properties
@ 2021-04-07 15:51   ` Neil Armstrong
  0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2021-04-07 15:51 UTC (permalink / raw)
  To: Stefan Agner; +Cc: jbrunet, khilman, u-boot-amlogic, u-boot

On 07/04/2021 16:49, Stefan Agner wrote:
> The sync of the device tree and dt-bindings from Linux v5.6-rc2
> 11a48a5a18c6 ("Linux 5.6-rc2") causes Ethernet to break on some
> ODROID-C2. The PHY seems to need proper reset timing to be functional
> in U-Boot and Linux afterwards. Readd the old PHY reset bindings for
> dwmac until we support the new bindings in the PHY node.
> 
> Fixes: dd5f2351e99a ("arm64: dts: meson: sync dt and bindings from v5.6-rc2")
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  arch/arm/dts/meson-gxbb-odroidc2.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts
> index 70fcfb7b06..8b80bbc90b 100644
> --- a/arch/arm/dts/meson-gxbb-odroidc2.dts
> +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts
> @@ -188,6 +188,10 @@
>  	phy-handle = <&eth_phy0>;
>  	phy-mode = "rgmii";
>  
> +	snps,reset-gpio = <&gpio GPIOZ_14 0>;
> +	snps,reset-delays-us = <0 10000 1000000>;
> +	snps,reset-active-low;
> +
>  	amlogic,tx-delay-ns = <2>;
>  
>  	mdio {
> 

Thanks, it's ok but please add the changes to arch/arm/dts/meson-gxbb-odroidc2-u-boot.dtsi
instead, we want to keep the DT files in sync with Linux, local u-boot changes must go into
the -u-boot.dtsi files.

Neil

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-07 15:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 14:49 [PATCH] arm64: dts: meson: odroidc2: readd PHY reset properties Stefan Agner
2021-04-07 14:49 ` Stefan Agner
2021-04-07 15:51 ` Neil Armstrong
2021-04-07 15:51   ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.