All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1 linux-next] jfs: atomically read inode size
@ 2017-01-23 17:50 Fabian Frederick
  2017-01-23 18:43 ` Dave Kleikamp
  0 siblings, 1 reply; 4+ messages in thread
From: Fabian Frederick @ 2017-01-23 17:50 UTC (permalink / raw)
  To: Dave Kleikamp; +Cc: jfs-discussion, linux-kernel, fabf

See i_size_read() comments in include/linux/fs.h

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/jfs/resize.c | 4 ++--
 fs/jfs/super.c  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
index bd9b641..7ddcb44 100644
--- a/fs/jfs/resize.c
+++ b/fs/jfs/resize.c
@@ -98,7 +98,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
 		goto out;
 	}
 
-	VolumeSize = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits;
+	VolumeSize = i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits;
 
 	if (VolumeSize) {
 		if (newLVSize > VolumeSize) {
@@ -211,7 +211,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
 	txQuiesce(sb);
 
 	/* Reset size of direct inode */
-	sbi->direct_inode->i_size =  sb->s_bdev->bd_inode->i_size;
+	sbi->direct_inode->i_size =  i_size_read(sb->s_bdev->bd_inode);
 
 	if (sbi->mntflag & JFS_INLINELOG) {
 		/*
diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index c64c257..ad02f00 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -283,7 +283,7 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
 		}
 		case Opt_resize_nosize:
 		{
-			*newLVSize = sb->s_bdev->bd_inode->i_size >>
+			*newLVSize = i_size_read(sb->s_bdev->bd_inode) >>
 				sb->s_blocksize_bits;
 			if (*newLVSize == 0)
 				pr_err("JFS: Cannot determine volume size\n");
@@ -549,7 +549,7 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
 		goto out_unload;
 	}
 	inode->i_ino = 0;
-	inode->i_size = sb->s_bdev->bd_inode->i_size;
+	inode->i_size = i_size_read(sb->s_bdev->bd_inode);
 	inode->i_mapping->a_ops = &jfs_metapage_aops;
 	hlist_add_fake(&inode->i_hash);
 	mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1 linux-next] jfs: atomically read inode size
  2017-01-23 17:50 [PATCH 1/1 linux-next] jfs: atomically read inode size Fabian Frederick
@ 2017-01-23 18:43 ` Dave Kleikamp
  2017-01-23 19:52   ` Fabian Frederick
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Kleikamp @ 2017-01-23 18:43 UTC (permalink / raw)
  To: Fabian Frederick, Dave Kleikamp; +Cc: jfs-discussion, linux-kernel

On 01/23/2017 11:50 AM, Fabian Frederick wrote:
> See i_size_read() comments in include/linux/fs.h

Is this fixing a real problem? Can the bd_inode size change while we're
mounting or resizing the filesystem?

> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  fs/jfs/resize.c | 4 ++--
>  fs/jfs/super.c  | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
> index bd9b641..7ddcb44 100644
> --- a/fs/jfs/resize.c
> +++ b/fs/jfs/resize.c
> @@ -98,7 +98,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
>  		goto out;
>  	}
>  
> -	VolumeSize = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits;
> +	VolumeSize = i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits;
>  
>  	if (VolumeSize) {
>  		if (newLVSize > VolumeSize) {
> @@ -211,7 +211,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
>  	txQuiesce(sb);
>  
>  	/* Reset size of direct inode */
> -	sbi->direct_inode->i_size =  sb->s_bdev->bd_inode->i_size;
> +	sbi->direct_inode->i_size =  i_size_read(sb->s_bdev->bd_inode);
>  
>  	if (sbi->mntflag & JFS_INLINELOG) {
>  		/*
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index c64c257..ad02f00 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -283,7 +283,7 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
>  		}
>  		case Opt_resize_nosize:
>  		{
> -			*newLVSize = sb->s_bdev->bd_inode->i_size >>
> +			*newLVSize = i_size_read(sb->s_bdev->bd_inode) >>
>  				sb->s_blocksize_bits;
>  			if (*newLVSize == 0)
>  				pr_err("JFS: Cannot determine volume size\n");
> @@ -549,7 +549,7 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
>  		goto out_unload;
>  	}
>  	inode->i_ino = 0;
> -	inode->i_size = sb->s_bdev->bd_inode->i_size;
> +	inode->i_size = i_size_read(sb->s_bdev->bd_inode);
>  	inode->i_mapping->a_ops = &jfs_metapage_aops;
>  	hlist_add_fake(&inode->i_hash);
>  	mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1 linux-next] jfs: atomically read inode size
  2017-01-23 18:43 ` Dave Kleikamp
@ 2017-01-23 19:52   ` Fabian Frederick
  2017-01-24 14:30     ` Dave Kleikamp
  0 siblings, 1 reply; 4+ messages in thread
From: Fabian Frederick @ 2017-01-23 19:52 UTC (permalink / raw)
  To: Dave Kleikamp, Dave Kleikamp; +Cc: linux-kernel, jfs-discussion



> On 23 January 2017 at 19:43 Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
>
>
> On 01/23/2017 11:50 AM, Fabian Frederick wrote:
> > See i_size_read() comments in include/linux/fs.h
>
> Is this fixing a real problem? Can the bd_inode size change while we're
> mounting or resizing the filesystem?
>

Behind good locking, there should be no problem.
I made some patches like this to use read operation to remove any
ambiguity.

Regards,
Fabian

> >
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> > ---
> >  fs/jfs/resize.c | 4 ++--
> >  fs/jfs/super.c  | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
> > index bd9b641..7ddcb44 100644
> > --- a/fs/jfs/resize.c
> > +++ b/fs/jfs/resize.c
> > @@ -98,7 +98,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize,
> > int newLogSize)
> >             goto out;
> >     }
> > 
> > -   VolumeSize = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits;
> > +   VolumeSize = i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits;
> > 
> >     if (VolumeSize) {
> >             if (newLVSize > VolumeSize) {
> > @@ -211,7 +211,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize,
> > int newLogSize)
> >     txQuiesce(sb);
> > 
> >     /* Reset size of direct inode */
> > -   sbi->direct_inode->i_size =  sb->s_bdev->bd_inode->i_size;
> > +   sbi->direct_inode->i_size =  i_size_read(sb->s_bdev->bd_inode);
> > 
> >     if (sbi->mntflag & JFS_INLINELOG) {
> >             /*
> > diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> > index c64c257..ad02f00 100644
> > --- a/fs/jfs/super.c
> > +++ b/fs/jfs/super.c
> > @@ -283,7 +283,7 @@ static int parse_options(char *options, struct
> > super_block *sb, s64 *newLVSize,
> >             }
> >             case Opt_resize_nosize:
> >             {
> > -                   *newLVSize = sb->s_bdev->bd_inode->i_size >>
> > +                   *newLVSize = i_size_read(sb->s_bdev->bd_inode) >>
> >                             sb->s_blocksize_bits;
> >                     if (*newLVSize == 0)
> >                             pr_err("JFS: Cannot determine volume size\n");
> > @@ -549,7 +549,7 @@ static int jfs_fill_super(struct super_block *sb, void
> > *data, int silent)
> >             goto out_unload;
> >     }
> >     inode->i_ino = 0;
> > -   inode->i_size = sb->s_bdev->bd_inode->i_size;
> > +   inode->i_size = i_size_read(sb->s_bdev->bd_inode);
> >     inode->i_mapping->a_ops = &jfs_metapage_aops;
> >     hlist_add_fake(&inode->i_hash);
> >     mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1 linux-next] jfs: atomically read inode size
  2017-01-23 19:52   ` Fabian Frederick
@ 2017-01-24 14:30     ` Dave Kleikamp
  0 siblings, 0 replies; 4+ messages in thread
From: Dave Kleikamp @ 2017-01-24 14:30 UTC (permalink / raw)
  To: Fabian Frederick; +Cc: linux-kernel, jfs-discussion

On 01/23/2017 01:52 PM, Fabian Frederick wrote:
> 
> 
>> On 23 January 2017 at 19:43 Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
>>
>>
>> On 01/23/2017 11:50 AM, Fabian Frederick wrote:
>>> See i_size_read() comments in include/linux/fs.h
>>
>> Is this fixing a real problem? Can the bd_inode size change while we're
>> mounting or resizing the filesystem?
>>
> 
> Behind good locking, there should be no problem.
> I made some patches like this to use read operation to remove any
> ambiguity.

There are a lot of places where i_size_read/write is used for bd_inode,
so I'll go ahead and take this patch for consistency of the code.

Thanks,
Shaggy

> 
> Regards,
> Fabian
> 
>>>
>>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>>> ---
>>>   fs/jfs/resize.c | 4 ++--
>>>   fs/jfs/super.c  | 4 ++--
>>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
>>> index bd9b641..7ddcb44 100644
>>> --- a/fs/jfs/resize.c
>>> +++ b/fs/jfs/resize.c
>>> @@ -98,7 +98,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize,
>>> int newLogSize)
>>>              goto out;
>>>      }
>>>  
>>> -   VolumeSize = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits;
>>> +   VolumeSize = i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits;
>>>  
>>>      if (VolumeSize) {
>>>              if (newLVSize > VolumeSize) {
>>> @@ -211,7 +211,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize,
>>> int newLogSize)
>>>      txQuiesce(sb);
>>>  
>>>      /* Reset size of direct inode */
>>> -   sbi->direct_inode->i_size =  sb->s_bdev->bd_inode->i_size;
>>> +   sbi->direct_inode->i_size =  i_size_read(sb->s_bdev->bd_inode);
>>>  
>>>      if (sbi->mntflag & JFS_INLINELOG) {
>>>              /*
>>> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
>>> index c64c257..ad02f00 100644
>>> --- a/fs/jfs/super.c
>>> +++ b/fs/jfs/super.c
>>> @@ -283,7 +283,7 @@ static int parse_options(char *options, struct
>>> super_block *sb, s64 *newLVSize,
>>>              }
>>>              case Opt_resize_nosize:
>>>              {
>>> -                   *newLVSize = sb->s_bdev->bd_inode->i_size >>
>>> +                   *newLVSize = i_size_read(sb->s_bdev->bd_inode) >>
>>>                              sb->s_blocksize_bits;
>>>                      if (*newLVSize == 0)
>>>                              pr_err("JFS: Cannot determine volume size\n");
>>> @@ -549,7 +549,7 @@ static int jfs_fill_super(struct super_block *sb, void
>>> *data, int silent)
>>>              goto out_unload;
>>>      }
>>>      inode->i_ino = 0;
>>> -   inode->i_size = sb->s_bdev->bd_inode->i_size;
>>> +   inode->i_size = i_size_read(sb->s_bdev->bd_inode);
>>>      inode->i_mapping->a_ops = &jfs_metapage_aops;
>>>      hlist_add_fake(&inode->i_hash);
>>>      mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
>>>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-24 14:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-23 17:50 [PATCH 1/1 linux-next] jfs: atomically read inode size Fabian Frederick
2017-01-23 18:43 ` Dave Kleikamp
2017-01-23 19:52   ` Fabian Frederick
2017-01-24 14:30     ` Dave Kleikamp

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.