* [PATCH] usb: xen-hcd: unlock on error paths
@ 2021-12-17 7:08 Dan Carpenter
2021-12-17 7:12 ` Juergen Gross
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-12-17 7:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, Juergen Gross; +Cc: linux-usb, kernel-janitors
These error paths are missing unlocks so it will lead to a system
hang.
Fixes: 494ed3997d75 ("usb: Introduce Xen pvUSB frontend (xen hcd)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/usb/host/xen-hcd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/host/xen-hcd.c b/drivers/usb/host/xen-hcd.c
index 7801dde6f5ee..81adb6be8ee9 100644
--- a/drivers/usb/host/xen-hcd.c
+++ b/drivers/usb/host/xen-hcd.c
@@ -941,6 +941,7 @@ static int xenhcd_urb_request_done(struct xenhcd_info *info)
rp = info->urb_ring.sring->rsp_prod;
if (RING_RESPONSE_PROD_OVERFLOW(&info->urb_ring, rp)) {
+ spin_unlock_irqrestore(&info->lock, flags);
xenhcd_set_error(info, "Illegal index on urb-ring");
return 0;
}
@@ -997,6 +998,7 @@ static int xenhcd_conn_notify(struct xenhcd_info *info)
rp = info->conn_ring.sring->rsp_prod;
if (RING_RESPONSE_PROD_OVERFLOW(&info->conn_ring, rp)) {
xenhcd_set_error(info, "Illegal index on conn-ring");
+ spin_unlock_irqrestore(&info->lock, flags);
return 0;
}
rmb(); /* ensure we see queued responses up to "rp" */
@@ -1010,6 +1012,7 @@ static int xenhcd_conn_notify(struct xenhcd_info *info)
if (xenhcd_rhport_connect(info, portnum, speed)) {
xenhcd_set_error(info, "Illegal data on conn-ring");
+ spin_unlock_irqrestore(&info->lock, flags);
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: xen-hcd: unlock on error paths
2021-12-17 7:08 [PATCH] usb: xen-hcd: unlock on error paths Dan Carpenter
@ 2021-12-17 7:12 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2021-12-17 7:12 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman; +Cc: linux-usb, kernel-janitors
[-- Attachment #1.1.1: Type: text/plain, Size: 333 bytes --]
On 17.12.21 08:08, Dan Carpenter wrote:
> These error paths are missing unlocks so it will lead to a system
> hang.
>
> Fixes: 494ed3997d75 ("usb: Introduce Xen pvUSB frontend (xen hcd)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
A similar patch has been queued in the usb-next branch already.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-17 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-17 7:08 [PATCH] usb: xen-hcd: unlock on error paths Dan Carpenter
2021-12-17 7:12 ` Juergen Gross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.