* [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW
@ 2024-02-08 17:57 Paolo Abeni
2024-02-08 20:51 ` Willem de Bruijn
2024-02-12 10:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 5+ messages in thread
From: Paolo Abeni @ 2024-02-08 17:57 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Shuah Khan,
linux-kselftest
This test is time sensitive. It may fail on virtual machines and for
debug builds.
Similar to commit c41dfb0dfbec ("selftests/net: ignore timing errors in
so_txtime if KSFT_MACHINE_SLOW"), optionally suppress failure for timing
errors (only).
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
tools/testing/selftests/net/txtimestamp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/txtimestamp.c b/tools/testing/selftests/net/txtimestamp.c
index 10f2fde3686b..ec60a16c9307 100644
--- a/tools/testing/selftests/net/txtimestamp.c
+++ b/tools/testing/selftests/net/txtimestamp.c
@@ -163,7 +163,8 @@ static void validate_timestamp(struct timespec *cur, int min_delay)
if (cur64 < start64 + min_delay || cur64 > start64 + max_delay) {
fprintf(stderr, "ERROR: %" PRId64 " us expected between %d and %d\n",
cur64 - start64, min_delay, max_delay);
- test_failed = true;
+ if (!getenv("KSFT_MACHINE_SLOW"))
+ test_failed = true;
}
}
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW
2024-02-08 17:57 [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW Paolo Abeni
@ 2024-02-08 20:51 ` Willem de Bruijn
2024-02-08 23:34 ` Jakub Kicinski
2024-02-12 10:30 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 5+ messages in thread
From: Willem de Bruijn @ 2024-02-08 20:51 UTC (permalink / raw)
To: Paolo Abeni, netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Shuah Khan,
linux-kselftest
Paolo Abeni wrote:
> This test is time sensitive. It may fail on virtual machines and for
> debug builds.
>
> Similar to commit c41dfb0dfbec ("selftests/net: ignore timing errors in
> so_txtime if KSFT_MACHINE_SLOW"), optionally suppress failure for timing
> errors (only).
>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Is this still failing after commit 5264ab612e28
("selftests/net: calibrate txtimestamp")?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW
2024-02-08 20:51 ` Willem de Bruijn
@ 2024-02-08 23:34 ` Jakub Kicinski
2024-02-08 23:46 ` Willem de Bruijn
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2024-02-08 23:34 UTC (permalink / raw)
To: Willem de Bruijn
Cc: Paolo Abeni, netdev, David S. Miller, Eric Dumazet, Shuah Khan,
linux-kselftest
On Thu, 08 Feb 2024 15:51:31 -0500 Willem de Bruijn wrote:
> Paolo Abeni wrote:
> > This test is time sensitive. It may fail on virtual machines and for
> > debug builds.
> >
> > Similar to commit c41dfb0dfbec ("selftests/net: ignore timing errors in
> > so_txtime if KSFT_MACHINE_SLOW"), optionally suppress failure for timing
> > errors (only).
> >
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>
> Is this still failing after commit 5264ab612e28
> ("selftests/net: calibrate txtimestamp")?
On a debug kernel it continues to flake :(
https://netdev.bots.linux.dev/flakes.html?br-cnt=80&tn-needle=txtimestamp&min-flip=0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW
2024-02-08 23:34 ` Jakub Kicinski
@ 2024-02-08 23:46 ` Willem de Bruijn
0 siblings, 0 replies; 5+ messages in thread
From: Willem de Bruijn @ 2024-02-08 23:46 UTC (permalink / raw)
To: Jakub Kicinski, Willem de Bruijn
Cc: Paolo Abeni, netdev, David S. Miller, Eric Dumazet, Shuah Khan,
linux-kselftest
Jakub Kicinski wrote:
> On Thu, 08 Feb 2024 15:51:31 -0500 Willem de Bruijn wrote:
> > Paolo Abeni wrote:
> > > This test is time sensitive. It may fail on virtual machines and for
> > > debug builds.
> > >
> > > Similar to commit c41dfb0dfbec ("selftests/net: ignore timing errors in
> > > so_txtime if KSFT_MACHINE_SLOW"), optionally suppress failure for timing
> > > errors (only).
> > >
> > > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> >
> > Is this still failing after commit 5264ab612e28
> > ("selftests/net: calibrate txtimestamp")?
>
> On a debug kernel it continues to flake :(
>
> https://netdev.bots.linux.dev/flakes.html?br-cnt=80&tn-needle=txtimestamp&min-flip=0
Thanks. I should have checked the dash directly. Reminder for next time.
Reviewed-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW
2024-02-08 17:57 [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW Paolo Abeni
2024-02-08 20:51 ` Willem de Bruijn
@ 2024-02-12 10:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-12 10:30 UTC (permalink / raw)
To: Paolo Abeni; +Cc: netdev, davem, edumazet, kuba, shuah, linux-kselftest
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 8 Feb 2024 18:57:49 +0100 you wrote:
> This test is time sensitive. It may fail on virtual machines and for
> debug builds.
>
> Similar to commit c41dfb0dfbec ("selftests/net: ignore timing errors in
> so_txtime if KSFT_MACHINE_SLOW"), optionally suppress failure for timing
> errors (only).
>
> [...]
Here is the summary with links:
- [net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW
https://git.kernel.org/netdev/net-next/c/9c52994e32c5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-12 10:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-08 17:57 [PATCH net-next] selftests: net: ignore timing errors in txtimestamp if KSFT_MACHINE_SLOW Paolo Abeni
2024-02-08 20:51 ` Willem de Bruijn
2024-02-08 23:34 ` Jakub Kicinski
2024-02-08 23:46 ` Willem de Bruijn
2024-02-12 10:30 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.