* linux-next: build warning after merge of the iommu tree
@ 2019-02-27 2:20 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2019-02-27 2:20 UTC (permalink / raw)
To: Joerg Roedel
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Kuppuswamy Sathyanarayanan
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
Hi Joerg,
After merging the iommu tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from drivers/pci/pci.c:32:
include/linux/pci-ats.h:70:12: warning: 'pci_prg_resp_pasid_required' defined but not used [-Wunused-function]
static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
The non CONFIG_PCI_PASID version needs an "inline".
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the iommu tree
@ 2019-02-27 2:20 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2019-02-27 2:20 UTC (permalink / raw)
To: Joerg Roedel
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Kuppuswamy Sathyanarayanan
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
Hi Joerg,
After merging the iommu tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from drivers/pci/pci.c:32:
include/linux/pci-ats.h:70:12: warning: 'pci_prg_resp_pasid_required' defined but not used [-Wunused-function]
static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
The non CONFIG_PCI_PASID version needs an "inline".
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the iommu tree
2019-02-27 2:20 ` Stephen Rothwell
@ 2019-02-27 18:48 ` sathyanarayanan kuppuswamy
-1 siblings, 0 replies; 6+ messages in thread
From: sathyanarayanan kuppuswamy @ 2019-02-27 18:48 UTC (permalink / raw)
To: Stephen Rothwell, Joerg Roedel
Cc: Linux Next Mailing List, Linux Kernel Mailing List
Hi,
On 2/26/19 6:20 PM, Stephen Rothwell wrote:
> Hi Joerg,
>
> After merging the iommu tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from drivers/pci/pci.c:32:
> include/linux/pci-ats.h:70:12: warning: 'pci_prg_resp_pasid_required' defined but not used [-Wunused-function]
> static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
>
> The non CONFIG_PCI_PASID version needs an "inline".
I can submit the fix, but do we need a new patch to fix it or the
original patch can be updated ?
>
--
Sathyanarayanan Kuppuswamy
Linux kernel developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the iommu tree
@ 2019-02-27 18:48 ` sathyanarayanan kuppuswamy
0 siblings, 0 replies; 6+ messages in thread
From: sathyanarayanan kuppuswamy @ 2019-02-27 18:48 UTC (permalink / raw)
To: Stephen Rothwell, Joerg Roedel
Cc: Linux Next Mailing List, Linux Kernel Mailing List
Hi,
On 2/26/19 6:20 PM, Stephen Rothwell wrote:
> Hi Joerg,
>
> After merging the iommu tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from drivers/pci/pci.c:32:
> include/linux/pci-ats.h:70:12: warning: 'pci_prg_resp_pasid_required' defined but not used [-Wunused-function]
> static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
>
> The non CONFIG_PCI_PASID version needs an "inline".
I can submit the fix, but do we need a new patch to fix it or the
original patch can be updated ?
>
--
Sathyanarayanan Kuppuswamy
Linux kernel developer
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/1] PCI/ATS: Add inline to pci_prg_resp_pasid_required()
2019-02-27 2:20 ` Stephen Rothwell
@ 2019-02-27 19:26 ` Kuppuswamy Sathyanarayanan
-1 siblings, 0 replies; 6+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2019-02-27 19:26 UTC (permalink / raw)
To: sfr, joro; +Cc: linux-next, linux-kernel, sathyanarayanan.kuppuswamy
Fix unused function warning when compiled with CONFIG_PCI_PASID
disabled.
Fixes: e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
include/linux/pci-ats.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/pci-ats.h b/include/linux/pci-ats.h
index facfd6a18fe1..1ebb88e7c184 100644
--- a/include/linux/pci-ats.h
+++ b/include/linux/pci-ats.h
@@ -67,7 +67,7 @@ static inline int pci_max_pasids(struct pci_dev *pdev)
return -EINVAL;
}
-static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
+static inline int pci_prg_resp_pasid_required(struct pci_dev *pdev)
{
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 1/1] PCI/ATS: Add inline to pci_prg_resp_pasid_required()
@ 2019-02-27 19:26 ` Kuppuswamy Sathyanarayanan
0 siblings, 0 replies; 6+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2019-02-27 19:26 UTC (permalink / raw)
To: sfr, joro; +Cc: linux-next, linux-kernel, sathyanarayanan.kuppuswamy
Fix unused function warning when compiled with CONFIG_PCI_PASID
disabled.
Fixes: e5567f5f6762 ("PCI/ATS: Add pci_prg_resp_pasid_required() interface.")
Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
include/linux/pci-ats.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/pci-ats.h b/include/linux/pci-ats.h
index facfd6a18fe1..1ebb88e7c184 100644
--- a/include/linux/pci-ats.h
+++ b/include/linux/pci-ats.h
@@ -67,7 +67,7 @@ static inline int pci_max_pasids(struct pci_dev *pdev)
return -EINVAL;
}
-static int pci_prg_resp_pasid_required(struct pci_dev *pdev)
+static inline int pci_prg_resp_pasid_required(struct pci_dev *pdev)
{
return 0;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-27 19:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-27 2:20 linux-next: build warning after merge of the iommu tree Stephen Rothwell
2019-02-27 2:20 ` Stephen Rothwell
2019-02-27 18:48 ` sathyanarayanan kuppuswamy
2019-02-27 18:48 ` sathyanarayanan kuppuswamy
2019-02-27 19:26 ` [PATCH v1 1/1] PCI/ATS: Add inline to pci_prg_resp_pasid_required() Kuppuswamy Sathyanarayanan
2019-02-27 19:26 ` Kuppuswamy Sathyanarayanan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.