[PATCH] ARM: dts: stm32: Fix SPI2 pinmux pin comments

[PATCH] ARM: dts: stm32: Fix SPI2 pinmux pin comments

[Marek Vasut]

Those pin comments refer to SPI2 pins, not SPI1 pins, update the comments.
No functional change.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
index 4f671045a0818..2cc9341d43d29 100644
--- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
@@ -1866,30 +1866,30 @@ pins {
 
 	spi2_pins_a: spi2-0 {
 		pins1 {
-			pinmux = <STM32_PINMUX('B', 10, AF5)>, /* SPI1_SCK */
-				 <STM32_PINMUX('I', 3, AF5)>; /* SPI1_MOSI */
+			pinmux = <STM32_PINMUX('B', 10, AF5)>, /* SPI2_SCK */
+				 <STM32_PINMUX('I', 3, AF5)>; /* SPI2_MOSI */
 			bias-disable;
 			drive-push-pull;
 			slew-rate = <1>;
 		};
 
 		pins2 {
-			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI1_MISO */
+			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI2_MISO */
 			bias-disable;
 		};
 	};
 
 	spi2_pins_b: spi2-1 {
 		pins1 {
-			pinmux = <STM32_PINMUX('I', 1, AF5)>, /* SPI1_SCK */
-				 <STM32_PINMUX('I', 3, AF5)>; /* SPI1_MOSI */
+			pinmux = <STM32_PINMUX('I', 1, AF5)>, /* SPI2_SCK */
+				 <STM32_PINMUX('I', 3, AF5)>; /* SPI2_MOSI */
 			bias-disable;
 			drive-push-pull;
 			slew-rate = <1>;
 		};
 
 		pins2 {
-			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI1_MISO */
+			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI2_MISO */
 			bias-disable;
 		};
 	};
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: stm32: Fix SPI2 pinmux pin comments

[Alexandre TORGUE]

Hi Marek

On 6/16/22 01:33, Marek Vasut wrote:
> Those pin comments refer to SPI2 pins, not SPI1 pins, update the comments.
> No functional change.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index 4f671045a0818..2cc9341d43d29 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -1866,30 +1866,30 @@ pins {
>   
>   	spi2_pins_a: spi2-0 {
>   		pins1 {
> -			pinmux = <STM32_PINMUX('B', 10, AF5)>, /* SPI1_SCK */
> -				 <STM32_PINMUX('I', 3, AF5)>; /* SPI1_MOSI */
> +			pinmux = <STM32_PINMUX('B', 10, AF5)>, /* SPI2_SCK */
> +				 <STM32_PINMUX('I', 3, AF5)>; /* SPI2_MOSI */
>   			bias-disable;
>   			drive-push-pull;
>   			slew-rate = <1>;
>   		};
>   
>   		pins2 {
> -			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI1_MISO */
> +			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI2_MISO */
>   			bias-disable;
>   		};
>   	};
>   
>   	spi2_pins_b: spi2-1 {

I don't have this reference (spi2-1). Do I miss something ?

>   		pins1 {
> -			pinmux = <STM32_PINMUX('I', 1, AF5)>, /* SPI1_SCK */
> -				 <STM32_PINMUX('I', 3, AF5)>; /* SPI1_MOSI */
> +			pinmux = <STM32_PINMUX('I', 1, AF5)>, /* SPI2_SCK */
> +				 <STM32_PINMUX('I', 3, AF5)>; /* SPI2_MOSI */
>   			bias-disable;
>   			drive-push-pull;
>   			slew-rate = <1>;
>   		};
>   
>   		pins2 {
> -			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI1_MISO */
> +			pinmux = <STM32_PINMUX('I', 2, AF5)>; /* SPI2_MISO */
>   			bias-disable;
>   		};
>   	};


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: stm32: Fix SPI2 pinmux pin comments

[Marek Vasut]

On 6/20/22 17:21, Alexandre TORGUE wrote:
> Hi Marek

Hello Alexandre,

> On 6/16/22 01:33, Marek Vasut wrote:
>> Those pin comments refer to SPI2 pins, not SPI1 pins, update the 
>> comments.
>> No functional change.

[...]

>>       spi2_pins_b: spi2-1 {
> 
> I don't have this reference (spi2-1). Do I miss something ?

I had the DRC Compact series in my tree before this patch, sorry. I 
updated both this patch and the DRC Compact series and submitted V2 and 
V3 respectively.

For the sake of simplicity, below are PW links to the latest versions of 
all outstanding patches. There are also AV96 DCMI patches in there:

https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=644216&state=%2A&archive=both

https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220626001559.198689-1-marex@denx.de/

https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=653863&state=%2A&archive=both

>>           pins1 {
>> -            pinmux = <STM32_PINMUX('I', 1, AF5)>, /* SPI1_SCK */
>> -                 <STM32_PINMUX('I', 3, AF5)>; /* SPI1_MOSI */
>> +            pinmux = <STM32_PINMUX('I', 1, AF5)>, /* SPI2_SCK */
>> +                 <STM32_PINMUX('I', 3, AF5)>; /* SPI2_MOSI */

[...]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel