From: Alistair Popple <apopple@nvidia.com>
To: <linux-mm@kvack.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>,
Daniel Vetter <daniel@ffwll.ch>,
"Nouveau Dev" <nouveau@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
<kvm-ppc@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Ralph Campbell <rcampbell@nvidia.com>,
Jerome Glisse <jglisse@redhat.com>
Subject: Re: [PATCH 0/9] Add support for SVM atomics in Nouveau
Date: Thu, 18 Feb 2021 10:00:54 +1100 [thread overview]
Message-ID: <6616185.Wbe1NtApLk@nvdebian> (raw)
In-Reply-To: <20210211075510.GA2368090@infradead.org>
On Thursday, 11 February 2021 6:55:10 PM AEDT Christoph Hellwig wrote:
> On Wed, Feb 10, 2021 at 01:59:13PM -0400, Jason Gunthorpe wrote:
> > Really what you want to do here is leave the CPU page in the VMA and
> > the page tables where it started and deny CPU access to the page. Then
> > all the proper machinery will continue to work.
> >
> > IMHO "migration" is the wrong idea if the data isn't actually moving.
>
> Agreed.
I chose "migration" because device private pages seemed like a good way of
reusing existing code to do what was required (a callback on CPU access).
However I have been reworking this to use mmu notifiers as the callback and it
seems to simplify some things nicely so think I also agree. It removes the
requirement for the pin as well which is nice, I'll post it as a v2 soon.
- Alistair
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <apopple@nvidia.com>
To: <linux-mm@kvack.org>
Cc: Ralph Campbell <rcampbell@nvidia.com>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Nouveau Dev <nouveau@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm-ppc@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Ben Skeggs <bskeggs@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Nouveau] [PATCH 0/9] Add support for SVM atomics in Nouveau
Date: Thu, 18 Feb 2021 10:00:54 +1100 [thread overview]
Message-ID: <6616185.Wbe1NtApLk@nvdebian> (raw)
In-Reply-To: <20210211075510.GA2368090@infradead.org>
On Thursday, 11 February 2021 6:55:10 PM AEDT Christoph Hellwig wrote:
> On Wed, Feb 10, 2021 at 01:59:13PM -0400, Jason Gunthorpe wrote:
> > Really what you want to do here is leave the CPU page in the VMA and
> > the page tables where it started and deny CPU access to the page. Then
> > all the proper machinery will continue to work.
> >
> > IMHO "migration" is the wrong idea if the data isn't actually moving.
>
> Agreed.
I chose "migration" because device private pages seemed like a good way of
reusing existing code to do what was required (a callback on CPU access).
However I have been reworking this to use mmu notifiers as the callback and it
seems to simplify some things nicely so think I also agree. It removes the
requirement for the pin as well which is nice, I'll post it as a v2 soon.
- Alistair
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <apopple@nvidia.com>
To: <linux-mm@kvack.org>
Cc: Ralph Campbell <rcampbell@nvidia.com>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Nouveau Dev <nouveau@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm-ppc@vger.kernel.org, Christoph Hellwig <hch@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Jerome Glisse <jglisse@redhat.com>,
Ben Skeggs <bskeggs@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/9] Add support for SVM atomics in Nouveau
Date: Thu, 18 Feb 2021 10:00:54 +1100 [thread overview]
Message-ID: <6616185.Wbe1NtApLk@nvdebian> (raw)
In-Reply-To: <20210211075510.GA2368090@infradead.org>
On Thursday, 11 February 2021 6:55:10 PM AEDT Christoph Hellwig wrote:
> On Wed, Feb 10, 2021 at 01:59:13PM -0400, Jason Gunthorpe wrote:
> > Really what you want to do here is leave the CPU page in the VMA and
> > the page tables where it started and deny CPU access to the page. Then
> > all the proper machinery will continue to work.
> >
> > IMHO "migration" is the wrong idea if the data isn't actually moving.
>
> Agreed.
I chose "migration" because device private pages seemed like a good way of
reusing existing code to do what was required (a callback on CPU access).
However I have been reworking this to use mmu notifiers as the callback and it
seems to simplify some things nicely so think I also agree. It removes the
requirement for the pin as well which is nice, I'll post it as a v2 soon.
- Alistair
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <apopple@nvidia.com>
To: linux-mm@kvack.org
Cc: Christoph Hellwig <hch@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>,
Daniel Vetter <daniel@ffwll.ch>,
Nouveau Dev <nouveau@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kvm-ppc@vger.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>,
Ralph Campbell <rcampbell@nvidia.com>,
Jerome Glisse <jglisse@redhat.com>
Subject: Re: [PATCH 0/9] Add support for SVM atomics in Nouveau
Date: Wed, 17 Feb 2021 23:00:54 +0000 [thread overview]
Message-ID: <6616185.Wbe1NtApLk@nvdebian> (raw)
In-Reply-To: <20210211075510.GA2368090@infradead.org>
On Thursday, 11 February 2021 6:55:10 PM AEDT Christoph Hellwig wrote:
> On Wed, Feb 10, 2021 at 01:59:13PM -0400, Jason Gunthorpe wrote:
> > Really what you want to do here is leave the CPU page in the VMA and
> > the page tables where it started and deny CPU access to the page. Then
> > all the proper machinery will continue to work.
> >
> > IMHO "migration" is the wrong idea if the data isn't actually moving.
>
> Agreed.
I chose "migration" because device private pages seemed like a good way of
reusing existing code to do what was required (a callback on CPU access).
However I have been reworking this to use mmu notifiers as the callback and it
seems to simplify some things nicely so think I also agree. It removes the
requirement for the pin as well which is nice, I'll post it as a v2 soon.
- Alistair
next prev parent reply other threads:[~2021-02-17 23:01 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 1:07 [PATCH 0/9] Add support for SVM atomics in Nouveau Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 1/9] mm/migrate.c: Always allow device private pages to migrate Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 13:39 ` Jason Gunthorpe
2021-02-09 13:39 ` Jason Gunthorpe
2021-02-09 13:39 ` Jason Gunthorpe
2021-02-09 13:39 ` [Nouveau] " Jason Gunthorpe
2021-02-10 3:40 ` Alistair Popple
2021-02-10 3:40 ` Alistair Popple
2021-02-10 3:40 ` Alistair Popple
2021-02-10 3:40 ` [Nouveau] " Alistair Popple
2021-02-10 12:56 ` Jason Gunthorpe
2021-02-10 12:56 ` Jason Gunthorpe
2021-02-10 12:56 ` Jason Gunthorpe
2021-02-10 12:56 ` [Nouveau] " Jason Gunthorpe
2021-02-09 1:07 ` [PATCH 2/9] mm/migrate.c: Allow pfn flags to be passed to migrate_vma_setup() Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 3/9] mm/migrate: Add a unmap and pin migration mode Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 4/9] Documentation: Add unmap and pin to HMM Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 5/9] hmm-tests: Add test for unmap and pin Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 6/9] nouveau/dmem: Only map migrating pages Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 7/9] nouveau/svm: Refactor nouveau_range_fault Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 8/9] nouveau/dmem: Add support for multiple page types Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 1:07 ` [PATCH 9/9] nouveau/svm: Implement atomic SVM access Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` Alistair Popple
2021-02-09 1:07 ` [Nouveau] " Alistair Popple
2021-02-09 10:27 ` [PATCH 0/9] Add support for SVM atomics in Nouveau Daniel Vetter
2021-02-09 10:27 ` Daniel Vetter
2021-02-09 10:27 ` Daniel Vetter
2021-02-09 10:27 ` [Nouveau] " Daniel Vetter
2021-02-09 10:27 ` Daniel Vetter
2021-02-09 12:57 ` Alistair Popple
2021-02-09 12:57 ` Alistair Popple
2021-02-09 12:57 ` Alistair Popple
2021-02-09 12:57 ` [Nouveau] " Alistair Popple
2021-02-09 13:35 ` Jason Gunthorpe
2021-02-09 13:35 ` Jason Gunthorpe
2021-02-09 13:35 ` Jason Gunthorpe
2021-02-09 13:35 ` [Nouveau] " Jason Gunthorpe
2021-02-09 13:39 ` Daniel Vetter
2021-02-09 13:39 ` Daniel Vetter
2021-02-09 13:39 ` Daniel Vetter
2021-02-09 13:39 ` [Nouveau] " Daniel Vetter
2021-02-09 13:39 ` Daniel Vetter
2021-02-09 13:44 ` Jason Gunthorpe
2021-02-09 13:44 ` Jason Gunthorpe
2021-02-09 13:44 ` Jason Gunthorpe
2021-02-09 13:44 ` [Nouveau] " Jason Gunthorpe
2021-02-09 21:17 ` Jerome Glisse
2021-02-09 21:17 ` Jerome Glisse
2021-02-09 21:17 ` Jerome Glisse
2021-02-09 21:17 ` [Nouveau] " Jerome Glisse
2021-02-10 17:56 ` Jason Gunthorpe
2021-02-10 17:56 ` Jason Gunthorpe
2021-02-10 17:56 ` Jason Gunthorpe
2021-02-10 17:56 ` [Nouveau] " Jason Gunthorpe
2021-02-09 13:37 ` Daniel Vetter
2021-02-09 13:37 ` Daniel Vetter
2021-02-09 13:37 ` Daniel Vetter
2021-02-09 13:37 ` [Nouveau] " Daniel Vetter
2021-02-09 13:37 ` Daniel Vetter
2021-02-09 20:53 ` John Hubbard
2021-02-09 20:53 ` John Hubbard
2021-02-09 20:53 ` John Hubbard
2021-02-09 20:53 ` [Nouveau] " John Hubbard
2021-02-10 12:59 ` Daniel Vetter
2021-02-10 12:59 ` Daniel Vetter
2021-02-10 12:59 ` Daniel Vetter
2021-02-10 12:59 ` [Nouveau] " Daniel Vetter
2021-02-11 2:26 ` John Hubbard
2021-02-11 2:26 ` John Hubbard
2021-02-11 2:26 ` John Hubbard
2021-02-11 2:26 ` [Nouveau] " John Hubbard
2021-02-10 17:59 ` Jason Gunthorpe
2021-02-10 17:59 ` Jason Gunthorpe
2021-02-10 17:59 ` Jason Gunthorpe
2021-02-10 17:59 ` [Nouveau] " Jason Gunthorpe
2021-02-11 7:55 ` Christoph Hellwig
2021-02-11 7:55 ` [Nouveau] " Christoph Hellwig
2021-02-17 23:00 ` Alistair Popple [this message]
2021-02-17 23:00 ` Alistair Popple
2021-02-17 23:00 ` Alistair Popple
2021-02-17 23:00 ` [Nouveau] " Alistair Popple
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6616185.Wbe1NtApLk@nvdebian \
--to=apopple@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.