From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Wen Yang <wen.yang99@zte.com.cn>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses
Date: Mon, 13 May 2019 14:22:44 +0200 [thread overview]
Message-ID: <66250f72-c433-28c7-a224-6f248339ec4c@web.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1905131130530.3616@hadrien>
>> Take additional casts for these code exclusion specifications into account
>> together with optional parentheses.
>
> NACK.
I find this rejection surprising.
> You don't need so many type metavariables.
I got an other software development opinion for this aspect.
Yesterday we started to clarify consequences from the isomorphism specification
“drop_cast” (for SmPL code).
https://github.com/coccinelle/coccinelle/blob/32d3b89ad909316464344a5f61a8092d8d702321/standard.iso#L52
Information like the following influenced my design decision to add three
metavariables here.
elfring@Sonne:~/Projekte/Linux/next-patched> spatch --parse-cocci scripts/coccinelle/free/put_device.cocci
…
warning: iso drop_cast does not match the code below on line -1
T (T )id
pure metavariable T is matched against the following nonpure code:
T
…
> Type metavariables in the same ... can be the same.
I would find it also occasionally nice when multiple SmPL ellipses
can refer to identical type casts.
* The under-documented “type purity” hinders this at the moment.
* But I got the impression that it can be safer to distinguish these
code variants better.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Yi Wang <wang.yi59@zte.com.cn>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, Wen Yang <wen.yang99@zte.com.cn>,
cocci@systeme.lip6.fr
Subject: Re: [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses
Date: Mon, 13 May 2019 14:22:44 +0200 [thread overview]
Message-ID: <66250f72-c433-28c7-a224-6f248339ec4c@web.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1905131130530.3616@hadrien>
>> Take additional casts for these code exclusion specifications into account
>> together with optional parentheses.
>
> NACK.
I find this rejection surprising.
> You don't need so many type metavariables.
I got an other software development opinion for this aspect.
Yesterday we started to clarify consequences from the isomorphism specification
“drop_cast” (for SmPL code).
https://github.com/coccinelle/coccinelle/blob/32d3b89ad909316464344a5f61a8092d8d702321/standard.iso#L52
Information like the following influenced my design decision to add three
metavariables here.
elfring@Sonne:~/Projekte/Linux/next-patched> spatch --parse-cocci scripts/coccinelle/free/put_device.cocci
…
warning: iso drop_cast does not match the code below on line -1
T (T )id
pure metavariable T is matched against the following nonpure code:
T
…
> Type metavariables in the same ... can be the same.
I would find it also occasionally nice when multiple SmPL ellipses
can refer to identical type casts.
* The under-documented “type purity” hinders this at the moment.
* But I got the impression that it can be safer to distinguish these
code variants better.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-05-13 12:23 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 6:14 [PATCH] coccinelle: put_device: reduce false positives Wen Yang
2019-03-23 6:14 ` [Cocci] " Wen Yang
2019-03-23 13:41 ` Julia Lawall
2019-03-23 13:41 ` [Cocci] " Julia Lawall
2019-03-23 19:44 ` Markus Elfring
2019-03-23 19:44 ` [Cocci] " Markus Elfring
2019-03-23 19:44 ` Markus Elfring
2019-03-23 20:06 ` Julia Lawall
2019-03-23 20:06 ` [Cocci] " Julia Lawall
2019-03-23 20:06 ` Julia Lawall
2019-03-26 8:45 ` Dan Carpenter
2019-03-26 8:45 ` [Cocci] " Dan Carpenter
2019-03-26 8:45 ` Dan Carpenter
2019-03-26 9:38 ` Julia Lawall
2019-03-26 9:38 ` [Cocci] " Julia Lawall
2019-03-26 9:38 ` Julia Lawall
2019-03-26 10:11 ` Dan Carpenter
2019-03-26 10:11 ` [Cocci] " Dan Carpenter
2019-03-26 10:11 ` Dan Carpenter
2019-03-26 10:15 ` Julia Lawall
2019-03-26 10:15 ` [Cocci] " Julia Lawall
2019-03-26 10:15 ` Julia Lawall
2019-03-28 13:08 ` Masahiro Yamada
2019-03-28 13:08 ` [Cocci] " Masahiro Yamada
2019-03-28 13:08 ` Masahiro Yamada
2019-03-28 14:19 ` Julia Lawall
2019-03-28 14:19 ` [Cocci] " Julia Lawall
2019-03-28 14:19 ` Julia Lawall
2019-04-01 6:44 ` Coccinelle: " Markus Elfring
2019-04-01 6:44 ` [Cocci] " Markus Elfring
2019-04-01 6:44 ` Markus Elfring
2019-04-01 20:04 ` Julia Lawall
2019-04-01 20:04 ` [Cocci] " Julia Lawall
2019-04-01 20:04 ` Julia Lawall
2019-05-13 8:55 ` [PATCH 0/5] Coccinelle: put_device: Adjustments for a SmPL script Markus Elfring
2019-05-13 8:55 ` [Cocci] " Markus Elfring
2019-05-13 8:59 ` [PATCH 1/5] Coccinelle: put_device: Adjust a message construction Markus Elfring
2019-05-13 8:59 ` [Cocci] " Markus Elfring
2019-05-13 9:35 ` Julia Lawall
2019-05-13 9:35 ` [Cocci] " Julia Lawall
2019-05-13 11:33 ` [1/5] " Markus Elfring
2019-05-13 11:33 ` [Cocci] " Markus Elfring
2019-05-13 11:36 ` Julia Lawall
2019-05-13 11:36 ` [Cocci] " Julia Lawall
2019-05-13 12:48 ` Markus Elfring
2019-05-13 12:48 ` [Cocci] " Markus Elfring
2019-07-06 13:13 ` [Cocci] [PATCH 1/5] " Masahiro Yamada
2019-07-06 13:13 ` Masahiro Yamada
2019-05-13 9:01 ` [PATCH 2/5] Coccinelle: put_device: Add a cast to an expression for an assignment Markus Elfring
2019-05-13 9:01 ` [Cocci] " Markus Elfring
2019-05-13 9:33 ` Julia Lawall
2019-05-13 9:33 ` [Cocci] " Julia Lawall
2019-07-06 13:13 ` Masahiro Yamada
2019-07-06 13:13 ` Masahiro Yamada
2019-05-13 9:05 ` [PATCH 3/5] Coccinelle: put_device: Merge four SmPL when constraints into one Markus Elfring
2019-05-13 9:05 ` [Cocci] " Markus Elfring
2019-05-13 9:32 ` Julia Lawall
2019-05-13 9:32 ` [Cocci] " Julia Lawall
2019-05-13 11:48 ` [3/5] " Markus Elfring
2019-05-13 11:48 ` [Cocci] " Markus Elfring
2019-05-13 11:48 ` Markus Elfring
2019-05-13 11:48 ` [Cocci] " Markus Elfring
2019-05-13 11:51 ` Julia Lawall
2019-05-13 11:51 ` [Cocci] " Julia Lawall
2019-05-13 12:52 ` Markus Elfring
2019-05-13 12:52 ` [Cocci] " Markus Elfring
2019-05-13 9:07 ` [PATCH 4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses Markus Elfring
2019-05-13 9:07 ` [Cocci] " Markus Elfring
2019-05-13 9:31 ` Julia Lawall
2019-05-13 9:31 ` [Cocci] " Julia Lawall
2019-05-13 12:22 ` Markus Elfring [this message]
2019-05-13 12:22 ` [Cocci] [4/5] " Markus Elfring
2019-05-14 5:55 ` Markus Elfring
2019-05-14 5:55 ` [Cocci] " Markus Elfring
2019-05-14 6:52 ` Julia Lawall
2019-05-14 6:52 ` [Cocci] " Julia Lawall
2019-05-14 7:49 ` Markus Elfring
2019-05-14 7:49 ` [Cocci] " Markus Elfring
2019-05-14 9:18 ` [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for twoSmPL ellipses wen.yang99
2019-05-14 9:51 ` Markus Elfring
2019-05-14 9:51 ` [Cocci] " Markus Elfring
2019-05-15 17:09 ` [4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses Markus Elfring
2019-05-14 7:49 ` Markus Elfring
2019-05-14 7:49 ` [Cocci] " Markus Elfring
2019-05-13 9:07 ` [PATCH 4/5] " Markus Elfring
2019-05-13 9:07 ` [Cocci] " Markus Elfring
2019-05-13 9:10 ` [PATCH 5/5] Coccinelle: put_device: Merge two SmPL when constraints into one Markus Elfring
2019-05-13 9:10 ` [Cocci] " Markus Elfring
2019-05-13 9:30 ` Julia Lawall
2019-05-13 9:30 ` [Cocci] " Julia Lawall
2019-05-13 12:35 ` [5/5] " Markus Elfring
2019-05-13 12:35 ` [Cocci] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66250f72-c433-28c7-a224-6f248339ec4c@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.