* [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
@ 2019-08-15 5:58 ` Nishka Dasgupta
0 siblings, 0 replies; 9+ messages in thread
From: Nishka Dasgupta @ 2019-08-15 5:58 UTC (permalink / raw)
To: pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue,
linux-i2c, linux-stm32, linux-arm-kernel, linux-kernel
Cc: Nishka Dasgupta
Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
when it is assigned to constant field algo of a variable having type
i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
const as well to protect it from unintended modification.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 266d1c269b83..d36cf08461f7 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
I2C_FUNC_SMBUS_I2C_BLOCK;
}
-static struct i2c_algorithm stm32f7_i2c_algo = {
+static const struct i2c_algorithm stm32f7_i2c_algo = {
.master_xfer = stm32f7_i2c_xfer,
.smbus_xfer = stm32f7_i2c_smbus_xfer,
.functionality = stm32f7_i2c_func,
--
2.19.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
@ 2019-08-15 5:58 ` Nishka Dasgupta
0 siblings, 0 replies; 9+ messages in thread
From: Nishka Dasgupta @ 2019-08-15 5:58 UTC (permalink / raw)
To: pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue,
linux-i2c, linux-stm32, linux-arm-kernel, linux-kernel
Cc: Nishka Dasgupta
Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
when it is assigned to constant field algo of a variable having type
i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
const as well to protect it from unintended modification.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
drivers/i2c/busses/i2c-stm32f7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index 266d1c269b83..d36cf08461f7 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
I2C_FUNC_SMBUS_I2C_BLOCK;
}
-static struct i2c_algorithm stm32f7_i2c_algo = {
+static const struct i2c_algorithm stm32f7_i2c_algo = {
.master_xfer = stm32f7_i2c_xfer,
.smbus_xfer = stm32f7_i2c_smbus_xfer,
.functionality = stm32f7_i2c_func,
--
2.19.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
2019-08-15 5:58 ` Nishka Dasgupta
@ 2019-09-03 18:05 ` Wolfram Sang
-1 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2019-09-03 18:05 UTC (permalink / raw)
To: Nishka Dasgupta
Cc: pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue,
linux-i2c, linux-stm32, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]
On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
> when it is assigned to constant field algo of a variable having type
> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
> const as well to protect it from unintended modification.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
Are you guys okay with this patch?
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 266d1c269b83..d36cf08461f7 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
> I2C_FUNC_SMBUS_I2C_BLOCK;
> }
>
> -static struct i2c_algorithm stm32f7_i2c_algo = {
> +static const struct i2c_algorithm stm32f7_i2c_algo = {
> .master_xfer = stm32f7_i2c_xfer,
> .smbus_xfer = stm32f7_i2c_smbus_xfer,
> .functionality = stm32f7_i2c_func,
> --
> 2.19.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
@ 2019-09-03 18:05 ` Wolfram Sang
0 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2019-09-03 18:05 UTC (permalink / raw)
To: Nishka Dasgupta
Cc: alexandre.torgue, linux-kernel, pierre-yves.mordret, linux-i2c,
mcoquelin.stm32, linux-stm32, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1175 bytes --]
On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
> when it is assigned to constant field algo of a variable having type
> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
> const as well to protect it from unintended modification.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
Are you guys okay with this patch?
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 266d1c269b83..d36cf08461f7 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
> I2C_FUNC_SMBUS_I2C_BLOCK;
> }
>
> -static struct i2c_algorithm stm32f7_i2c_algo = {
> +static const struct i2c_algorithm stm32f7_i2c_algo = {
> .master_xfer = stm32f7_i2c_xfer,
> .smbus_xfer = stm32f7_i2c_smbus_xfer,
> .functionality = stm32f7_i2c_func,
> --
> 2.19.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
2019-09-03 18:05 ` Wolfram Sang
(?)
@ 2019-09-04 7:47 ` Pierre Yves MORDRET
-1 siblings, 0 replies; 9+ messages in thread
From: Pierre Yves MORDRET @ 2019-09-04 7:47 UTC (permalink / raw)
To: Wolfram Sang, Nishka Dasgupta
Cc: mcoquelin.stm32, alexandre.torgue, linux-i2c, linux-stm32,
linux-arm-kernel, linux-kernel
Hi Wolfram
Sorry for the delay.
Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
BR
On 9/3/19 8:05 PM, Wolfram Sang wrote:
> On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
>> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
>> when it is assigned to constant field algo of a variable having type
>> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
>> const as well to protect it from unintended modification.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>
> Are you guys okay with this patch?
>
>> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
>> index 266d1c269b83..d36cf08461f7 100644
>> --- a/drivers/i2c/busses/i2c-stm32f7.c
>> +++ b/drivers/i2c/busses/i2c-stm32f7.c
>> @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
>> I2C_FUNC_SMBUS_I2C_BLOCK;
>> }
>>
>> -static struct i2c_algorithm stm32f7_i2c_algo = {
>> +static const struct i2c_algorithm stm32f7_i2c_algo = {
>> .master_xfer = stm32f7_i2c_xfer,
>> .smbus_xfer = stm32f7_i2c_smbus_xfer,
>> .functionality = stm32f7_i2c_func,
>> --
>> 2.19.1
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
@ 2019-09-04 7:47 ` Pierre Yves MORDRET
0 siblings, 0 replies; 9+ messages in thread
From: Pierre Yves MORDRET @ 2019-09-04 7:47 UTC (permalink / raw)
To: Wolfram Sang, Nishka Dasgupta
Cc: alexandre.torgue, linux-kernel, linux-i2c, mcoquelin.stm32,
linux-stm32, linux-arm-kernel
Hi Wolfram
Sorry for the delay.
Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
BR
On 9/3/19 8:05 PM, Wolfram Sang wrote:
> On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
>> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
>> when it is assigned to constant field algo of a variable having type
>> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
>> const as well to protect it from unintended modification.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>
> Are you guys okay with this patch?
>
>> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
>> index 266d1c269b83..d36cf08461f7 100644
>> --- a/drivers/i2c/busses/i2c-stm32f7.c
>> +++ b/drivers/i2c/busses/i2c-stm32f7.c
>> @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
>> I2C_FUNC_SMBUS_I2C_BLOCK;
>> }
>>
>> -static struct i2c_algorithm stm32f7_i2c_algo = {
>> +static const struct i2c_algorithm stm32f7_i2c_algo = {
>> .master_xfer = stm32f7_i2c_xfer,
>> .smbus_xfer = stm32f7_i2c_smbus_xfer,
>> .functionality = stm32f7_i2c_func,
>> --
>> 2.19.1
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
@ 2019-09-04 7:47 ` Pierre Yves MORDRET
0 siblings, 0 replies; 9+ messages in thread
From: Pierre Yves MORDRET @ 2019-09-04 7:47 UTC (permalink / raw)
To: Wolfram Sang, Nishka Dasgupta
Cc: alexandre.torgue, linux-kernel, linux-i2c, mcoquelin.stm32,
linux-stm32, linux-arm-kernel
Hi Wolfram
Sorry for the delay.
Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
BR
On 9/3/19 8:05 PM, Wolfram Sang wrote:
> On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
>> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
>> when it is assigned to constant field algo of a variable having type
>> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
>> const as well to protect it from unintended modification.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>
> Are you guys okay with this patch?
>
>> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
>> index 266d1c269b83..d36cf08461f7 100644
>> --- a/drivers/i2c/busses/i2c-stm32f7.c
>> +++ b/drivers/i2c/busses/i2c-stm32f7.c
>> @@ -1809,7 +1809,7 @@ static u32 stm32f7_i2c_func(struct i2c_adapter *adap)
>> I2C_FUNC_SMBUS_I2C_BLOCK;
>> }
>>
>> -static struct i2c_algorithm stm32f7_i2c_algo = {
>> +static const struct i2c_algorithm stm32f7_i2c_algo = {
>> .master_xfer = stm32f7_i2c_xfer,
>> .smbus_xfer = stm32f7_i2c_smbus_xfer,
>> .functionality = stm32f7_i2c_func,
>> --
>> 2.19.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
2019-08-15 5:58 ` Nishka Dasgupta
@ 2019-09-04 21:12 ` Wolfram Sang
-1 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2019-09-04 21:12 UTC (permalink / raw)
To: Nishka Dasgupta
Cc: pierre-yves.mordret, mcoquelin.stm32, alexandre.torgue,
linux-i2c, linux-stm32, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
> when it is assigned to constant field algo of a variable having type
> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
> const as well to protect it from unintended modification.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant
@ 2019-09-04 21:12 ` Wolfram Sang
0 siblings, 0 replies; 9+ messages in thread
From: Wolfram Sang @ 2019-09-04 21:12 UTC (permalink / raw)
To: Nishka Dasgupta
Cc: alexandre.torgue, linux-kernel, pierre-yves.mordret, linux-i2c,
mcoquelin.stm32, linux-stm32, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 477 bytes --]
On Thu, Aug 15, 2019 at 11:28:57AM +0530, Nishka Dasgupta wrote:
> Static structure stm32f7_i2c_algo, of type i2c_algorithm, is used only
> when it is assigned to constant field algo of a variable having type
> i2c_adapter. As stm32f7_i2c_algo is therefore never modified, make it
> const as well to protect it from unintended modification.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-09-04 21:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-15 5:58 [PATCH] i2c: stm32f7: Make structure stm32f7_i2c_algo constant Nishka Dasgupta
2019-08-15 5:58 ` Nishka Dasgupta
2019-09-03 18:05 ` Wolfram Sang
2019-09-03 18:05 ` Wolfram Sang
2019-09-04 7:47 ` Pierre Yves MORDRET
2019-09-04 7:47 ` Pierre Yves MORDRET
2019-09-04 7:47 ` Pierre Yves MORDRET
2019-09-04 21:12 ` Wolfram Sang
2019-09-04 21:12 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.