* [PATCH v2] pinctrl: st: Include the right header
@ 2019-08-20 11:11 Linus Walleij
2019-08-26 7:41 ` Patrice CHOTARD
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2019-08-20 11:11 UTC (permalink / raw)
To: linux-gpio; +Cc: Linus Walleij, Patrice Chotard, Maxime Coquelin
The ST pinctrl driver wants to provode a gpio_chip but is not
including the header for this, fix the inclusion to use the right
header. <linux/of_gpio.h> has to remain as the driver is calling
of_get_named_gpio().
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- Include <linux/of_gpio.h> again, the driver is indeed using
it.
- Add an explanatory comment.
---
drivers/pinctrl/pinctrl-st.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index b9688ea548da..25236b716fb3 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -12,8 +12,9 @@
#include <linux/io.h>
#include <linux/of.h>
#include <linux/of_irq.h>
-#include <linux/of_gpio.h>
+#include <linux/of_gpio.h> /* of_get_named_gpio() */
#include <linux/of_address.h>
+#include <linux/gpio/driver.h>
#include <linux/regmap.h>
#include <linux/mfd/syscon.h>
#include <linux/pinctrl/pinctrl.h>
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] pinctrl: st: Include the right header
2019-08-20 11:11 [PATCH v2] pinctrl: st: Include the right header Linus Walleij
@ 2019-08-26 7:41 ` Patrice CHOTARD
0 siblings, 0 replies; 2+ messages in thread
From: Patrice CHOTARD @ 2019-08-26 7:41 UTC (permalink / raw)
To: Linus Walleij, linux-gpio; +Cc: Maxime Coquelin
Hi Linus
On 8/20/19 1:11 PM, Linus Walleij wrote:
> The ST pinctrl driver wants to provode a gpio_chip but is not
> including the header for this, fix the inclusion to use the right
> header. <linux/of_gpio.h> has to remain as the driver is calling
> of_get_named_gpio().
>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Maxime Coquelin <maxime.coquelin@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Include <linux/of_gpio.h> again, the driver is indeed using
> it.
> - Add an explanatory comment.
> ---
> drivers/pinctrl/pinctrl-st.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index b9688ea548da..25236b716fb3 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -12,8 +12,9 @@
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_irq.h>
> -#include <linux/of_gpio.h>
> +#include <linux/of_gpio.h> /* of_get_named_gpio() */
> #include <linux/of_address.h>
> +#include <linux/gpio/driver.h>
> #include <linux/regmap.h>
> #include <linux/mfd/syscon.h>
> #include <linux/pinctrl/pinctrl.h>
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-26 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 11:11 [PATCH v2] pinctrl: st: Include the right header Linus Walleij
2019-08-26 7:41 ` Patrice CHOTARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.