[PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

[PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

[Marek Szyprowski]

TE-gpio, if defined, is placed in the panel's node, not the parent DSI
node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
pass proper device node to it. The code already has a proper cleanup
path, so it looks that the devm_* variant has been applied assidentally
during the conversion to gpiod API.

Fixes: ee6c8b5afa62 ("drm/exynos: Replace legacy gpio interface for gpiod interface")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 14ebbb124852..d13f5e3a030d 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1334,7 +1334,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
 	int ret;
 	int te_gpio_irq;
 
-	dsi->te_gpio = devm_gpiod_get_optional(dsi->dev, "te", GPIOD_IN);
+	dsi->te_gpio = gpiod_get_optional(panel, "te", GPIOD_IN);
 	if (!dsi->te_gpio) {
 		return 0;
 	} else if (IS_ERR(dsi->te_gpio)) {
-- 
2.17.1

[PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

[Marek Szyprowski]

TE-gpio, if defined, is placed in the panel's node, not the parent DSI
node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
pass proper device node to it. The code already has a proper cleanup
path, so it looks that the devm_* variant has been applied assidentally
during the conversion to gpiod API.

Fixes: ee6c8b5afa62 ("drm/exynos: Replace legacy gpio interface for gpiod interface")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 14ebbb124852..d13f5e3a030d 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1334,7 +1334,7 @@ static int exynos_dsi_register_te_irq(struct exynos_dsi *dsi,
 	int ret;
 	int te_gpio_irq;
 
-	dsi->te_gpio = devm_gpiod_get_optional(dsi->dev, "te", GPIOD_IN);
+	dsi->te_gpio = gpiod_get_optional(panel, "te", GPIOD_IN);
 	if (!dsi->te_gpio) {
 		return 0;
 	} else if (IS_ERR(dsi->te_gpio)) {
-- 
2.17.1

Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

[Henrik Grimler]

Hi Marek,

On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote:
> TE-gpio, if defined, is placed in the panel's node, not the parent DSI
> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
> pass proper device node to it. The code already has a proper cleanup
> path, so it looks that the devm_* variant has been applied assidentally
                                                             ~~~~~~~~~~~~
Small observation: the spelling above should probably be    "accidentally".

> during the conversion to gpiod API.

Best regards,
Henrik Grimler

Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

[Henrik Grimler]

Hi Marek,

On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote:
> TE-gpio, if defined, is placed in the panel's node, not the parent DSI
> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
> pass proper device node to it. The code already has a proper cleanup
> path, so it looks that the devm_* variant has been applied assidentally
                                                             ~~~~~~~~~~~~
Small observation: the spelling above should probably be    "accidentally".

> during the conversion to gpiod API.

Best regards,
Henrik Grimler

Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

[Inki Dae]

Hi,

22. 1. 25. 00:22에 Henrik Grimler 이(가) 쓴 글:
> Hi Marek,
> 
> On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote:
>> TE-gpio, if defined, is placed in the panel's node, not the parent DSI
>> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
>> pass proper device node to it. The code already has a proper cleanup
>> path, so it looks that the devm_* variant has been applied assidentally
>                                                              ~~~~~~~~~~~~
> Small observation: the spelling above should probably be    "accidentally".
> 

I can fix it. Thanks.

>> during the conversion to gpiod API.
> 
> Best regards,
> Henrik Grimler
> 

Re: [PATCH] drm/exynos: Search for TE-gpio in DSI panel's node

[Inki Dae]

Hi,

22. 1. 25. 00:22에 Henrik Grimler 이(가) 쓴 글:
> Hi Marek,
> 
> On Mon, Jan 24, 2022 at 02:52:46PM +0100, Marek Szyprowski wrote:
>> TE-gpio, if defined, is placed in the panel's node, not the parent DSI
>> node. Change the devm_gpiod_get_optional() to gpiod_get_optional() and
>> pass proper device node to it. The code already has a proper cleanup
>> path, so it looks that the devm_* variant has been applied assidentally
>                                                              ~~~~~~~~~~~~
> Small observation: the spelling above should probably be    "accidentally".
> 

I can fix it. Thanks.

>> during the conversion to gpiod API.
> 
> Best regards,
> Henrik Grimler
>