[PATCH net-next] docs: networking: phy: add missing space

[PATCH net-next] docs: networking: phy: add missing space

[Casper Andersson]

Missing space between "pins'" and "strength"

Signed-off-by: Casper Andersson <casper.casan@gmail.com>
---
 Documentation/networking/phy.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/networking/phy.rst b/Documentation/networking/phy.rst
index 06f4fcdb58b6..d11329a08984 100644
--- a/Documentation/networking/phy.rst
+++ b/Documentation/networking/phy.rst
@@ -120,7 +120,7 @@ required delays, as defined per the RGMII standard, several options may be
 available:
 
 * Some SoCs may offer a pin pad/mux/controller capable of configuring a given
-  set of pins'strength, delays, and voltage; and it may be a suitable
+  set of pins' strength, delays, and voltage; and it may be a suitable
   option to insert the expected 2ns RGMII delay.
 
 * Modifying the PCB design to include a fixed delay (e.g: using a specifically
-- 
2.34.1

Re: [PATCH net-next] docs: networking: phy: add missing space

[Paolo Abeni]

On Tue, 2022-10-04 at 09:32 +0200, Casper Andersson wrote:
> Missing space between "pins'" and "strength"
> 
> Signed-off-by: Casper Andersson <casper.casan@gmail.com>
> ---

The merge window has now started (after Linus tagged 6.0)
and will last until he tags 6.1-rc1 (two weeks from now). During this
time we'll not be taking any patches for net-next so
please repost in around 2 weeks.

Thanks,

Paolo

Re: [PATCH net-next] docs: networking: phy: add missing space

[Florian Fainelli]

On 10/4/22 03:30, Paolo Abeni wrote:
> On Tue, 2022-10-04 at 09:32 +0200, Casper Andersson wrote:
>> Missing space between "pins'" and "strength"
>>
>> Signed-off-by: Casper Andersson <casper.casan@gmail.com>
>> ---
> 
> The merge window has now started (after Linus tagged 6.0)
> and will last until he tags 6.1-rc1 (two weeks from now). During this
> time we'll not be taking any patches for net-next so
> please repost in around 2 weeks.

It is a documentation patch, therefore not functionally touching code, 
maybe that could count as an exception?
-- 
Florian

Re: [PATCH net-next] docs: networking: phy: add missing space

[Bagas Sanjaya]

On 10/4/22 14:32, Casper Andersson wrote:
>  
>  * Some SoCs may offer a pin pad/mux/controller capable of configuring a given
> -  set of pins'strength, delays, and voltage; and it may be a suitable
> +  set of pins' strength, delays, and voltage; and it may be a suitable
>    option to insert the expected 2ns RGMII delay.
>  

Looks OK.

IMO, I would like to write the phrase as "... configuring a given set of
pin parameters (strength, delays, and voltage) ...".

Regardless,

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara

Re: [PATCH net-next] docs: networking: phy: add missing space

[Bagas Sanjaya]

On 10/5/22 01:35, Florian Fainelli wrote:
> On 10/4/22 03:30, Paolo Abeni wrote:
>> On Tue, 2022-10-04 at 09:32 +0200, Casper Andersson wrote:
>>> Missing space between "pins'" and "strength"
>>>
>>> Signed-off-by: Casper Andersson <casper.casan@gmail.com>
>>> ---
>>
>> The merge window has now started (after Linus tagged 6.0)
>> and will last until he tags 6.1-rc1 (two weeks from now). During this
>> time we'll not be taking any patches for net-next so
>> please repost in around 2 weeks.
> 
> It is a documentation patch, therefore not functionally touching code, maybe that could count as an exception?

I think jon will pick up this patch, maybe as -rc-worthy fixes.

-- 
An old man doll... just what I always wanted! - Clara

Re: [PATCH net-next] docs: networking: phy: add missing space

[Jonathan Corbet]

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 10/5/22 01:35, Florian Fainelli wrote:
>> On 10/4/22 03:30, Paolo Abeni wrote:
>>> On Tue, 2022-10-04 at 09:32 +0200, Casper Andersson wrote:
>>>> Missing space between "pins'" and "strength"
>>>>
>>>> Signed-off-by: Casper Andersson <casper.casan@gmail.com>
>>>> ---
>>>
>>> The merge window has now started (after Linus tagged 6.0)
>>> and will last until he tags 6.1-rc1 (two weeks from now). During this
>>> time we'll not be taking any patches for net-next so
>>> please repost in around 2 weeks.
>> 
>> It is a documentation patch, therefore not functionally touching code, maybe that could count as an exception?
>
> I think jon will pick up this patch, maybe as -rc-worthy fixes.

The networking folks prefer to carry their own documentation patches, so
I don't normally do that.  I'd be happy to this time with a suitable
ack.

But honestly, there is nothing urgent about this change, I'd say just
wait until net-next is open.

jon

Re: [PATCH net-next] docs: networking: phy: add missing space

[Jakub Kicinski]

On Wed, 05 Oct 2022 08:12:26 -0600 Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
> >> It is a documentation patch, therefore not functionally touching
> >> code, maybe that could count as an exception?  
> >
> > I think jon will pick up this patch, maybe as -rc-worthy fixes.  
> 
> The networking folks prefer to carry their own documentation patches,
> so I don't normally do that.  I'd be happy to this time with a
> suitable ack.
> 
> But honestly, there is nothing urgent about this change, I'd say just
> wait until net-next is open.

Sorry for the back and forth, the patch is waiting patchwork, we've 
just been unusually busy the last two days. We'll apply it soon.

Re: [PATCH net-next] docs: networking: phy: add missing space

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  4 Oct 2022 09:32:42 +0200 you wrote:
> Missing space between "pins'" and "strength"
> 
> Signed-off-by: Casper Andersson <casper.casan@gmail.com>
> ---
>  Documentation/networking/phy.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] docs: networking: phy: add missing space
    https://git.kernel.org/netdev/net/c/229a0027591c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html