From: Wesley Cheng <quic_wcheng@quicinc.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>, <perex@perex.cz>, <lgirdwood@gmail.com>, <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>, <Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>, <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>, <agross@kernel.org> Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>, <quic_jackp@quicinc.com>, <quic_plai@quicinc.com> Subject: Re: [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Date: Mon, 30 Jan 2023 14:02:49 -0800 [thread overview] Message-ID: <6655bd97-61e8-e03b-b782-bcfcc2138717@quicinc.com> (raw) In-Reply-To: <05e55db1-5181-8025-8aee-e398200b047c@linaro.org> Hi Krzysztof, On 1/26/2023 4:01 AM, Krzysztof Kozlowski wrote: > On 26/01/2023 04:14, Wesley Cheng wrote: >> Add a new definition for specifying how many XHCI secondary interrupters >> can be allocated. XHCI in general can potentially support up to 1024 >> interrupters, which some uses may want to limit depending on how many >> users utilize the interrupters. > > I cannot find in the code any user of this. Your next patch stores it, > but which other patch uses stored value? > > What I still don't get how is this exactly hardware property, not policy > or driver choice. > Sorry I must have missed that patchset when rebasing over Mathias' xHCI changes. It was there previously in my initial submission where the property is carried over into xhci-plat from dwc3/host.c. So the xHC controller has a HCSPARAMs field that defines the number of interrupters it can support. It does potentially have the capability of having 1024 interrupters. Each interrupter has to have its own set of interrupt register sets, which depending on the vendor implementing it could limit the maximum. For example, as stated below, DWC3 only allows for 8 interrupters to be allocated. The purpose for this property is to allow the user/driver to not have to allocate memory for supporting 1024 event rings, if they are only going to utilize one. Likewise, if the user attempts to allocate more than what is supported by the HW, then Mathias' SW will cross check to ensure that isn't allowed. (by checking the HCSPARAMs against the DT property below) >> >> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> >> --- >> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> index 6d78048c4613..4faaec9655e0 100644 >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> @@ -349,6 +349,18 @@ properties: >> items: >> enum: [1, 4, 8, 16, 32, 64, 128, 256] >> >> + snps,num-hc-interrupters: >> + description: >> + Defines the maximum number of XHCI host controller interrupters that can >> + be supported. The XHCI host controller has support to allocate multiple >> + event rings, which can be assigned to different clients/users. The DWC3 >> + controller has a maximum of 8 interrupters. If this is not defined then >> + the value will be defaulted to 1. This parameter is used only when >> + operating in host mode. >> + $ref: /schemas/types.yaml#/definitions/uint8 >> + minimum: 1 >> + maximum: 8 > > default: 1 > Got it. Thanks Wesley Cheng
WARNING: multiple messages have this Message-ID (diff)
From: Wesley Cheng <quic_wcheng@quicinc.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>, <perex@perex.cz>, <lgirdwood@gmail.com>, <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <gregkh@linuxfoundation.org>, <Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>, <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>, <agross@kernel.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com Subject: Re: [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Date: Mon, 30 Jan 2023 14:02:49 -0800 [thread overview] Message-ID: <6655bd97-61e8-e03b-b782-bcfcc2138717@quicinc.com> (raw) In-Reply-To: <05e55db1-5181-8025-8aee-e398200b047c@linaro.org> Hi Krzysztof, On 1/26/2023 4:01 AM, Krzysztof Kozlowski wrote: > On 26/01/2023 04:14, Wesley Cheng wrote: >> Add a new definition for specifying how many XHCI secondary interrupters >> can be allocated. XHCI in general can potentially support up to 1024 >> interrupters, which some uses may want to limit depending on how many >> users utilize the interrupters. > > I cannot find in the code any user of this. Your next patch stores it, > but which other patch uses stored value? > > What I still don't get how is this exactly hardware property, not policy > or driver choice. > Sorry I must have missed that patchset when rebasing over Mathias' xHCI changes. It was there previously in my initial submission where the property is carried over into xhci-plat from dwc3/host.c. So the xHC controller has a HCSPARAMs field that defines the number of interrupters it can support. It does potentially have the capability of having 1024 interrupters. Each interrupter has to have its own set of interrupt register sets, which depending on the vendor implementing it could limit the maximum. For example, as stated below, DWC3 only allows for 8 interrupters to be allocated. The purpose for this property is to allow the user/driver to not have to allocate memory for supporting 1024 event rings, if they are only going to utilize one. Likewise, if the user attempts to allocate more than what is supported by the HW, then Mathias' SW will cross check to ensure that isn't allowed. (by checking the HCSPARAMs against the DT property below) >> >> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> >> --- >> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> index 6d78048c4613..4faaec9655e0 100644 >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> @@ -349,6 +349,18 @@ properties: >> items: >> enum: [1, 4, 8, 16, 32, 64, 128, 256] >> >> + snps,num-hc-interrupters: >> + description: >> + Defines the maximum number of XHCI host controller interrupters that can >> + be supported. The XHCI host controller has support to allocate multiple >> + event rings, which can be assigned to different clients/users. The DWC3 >> + controller has a maximum of 8 interrupters. If this is not defined then >> + the value will be defaulted to 1. This parameter is used only when >> + operating in host mode. >> + $ref: /schemas/types.yaml#/definitions/uint8 >> + minimum: 1 >> + maximum: 8 > > default: 1 > Got it. Thanks Wesley Cheng
next prev parent reply other threads:[~2023-01-30 22:03 UTC|newest] Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-26 3:14 [RFC PATCH v2 00/22] Introduce QC USB SND audio offloading support Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 01/22] xhci: fix event ring segment table related masks and variables in header Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 02/22] xhci: remove xhci_test_trb_in_td_math early development check Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 7:48 ` Greg KH 2023-01-26 7:48 ` Greg KH 2023-01-26 3:14 ` [RFC PATCH v2 03/22] xhci: Refactor interrupter code for initial multi interrupter support Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 04/22] xhci: Add support to allocate several interrupters Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 05/22] usb: xhci: Add XHCI APIs to support USB offloading Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 06/22] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 07/22] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:32 ` Pierre-Louis Bossart 2023-01-30 22:36 ` Wesley Cheng 2023-01-30 22:36 ` Wesley Cheng 2023-01-28 13:26 ` Greg KH 2023-01-28 13:26 ` Greg KH 2023-01-29 6:54 ` Zhou Furong 2023-01-29 6:54 ` Zhou Furong 2023-01-29 7:09 ` Greg KH 2023-01-29 7:09 ` Greg KH 2023-01-30 8:34 ` Zhou Furong 2023-01-30 8:34 ` Zhou Furong 2023-01-30 9:27 ` Greg KH 2023-01-30 9:27 ` Greg KH 2023-02-10 22:46 ` Wesley Cheng 2023-02-10 22:46 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 08/22] ASoC: dt-bindings: Add USB_RX port Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 11:55 ` Krzysztof Kozlowski 2023-01-26 11:55 ` Krzysztof Kozlowski 2023-01-30 21:52 ` Wesley Cheng 2023-01-30 21:52 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 09/22] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:07 ` Srinivas Kandagatla 2023-01-26 15:07 ` Srinivas Kandagatla 2023-01-26 15:38 ` Pierre-Louis Bossart 2023-01-30 22:54 ` Wesley Cheng 2023-01-30 22:54 ` Wesley Cheng 2023-01-30 23:59 ` Pierre-Louis Bossart 2023-02-01 2:40 ` Wesley Cheng 2023-02-01 2:40 ` Wesley Cheng 2023-02-01 3:02 ` Pierre-Louis Bossart 2023-02-03 1:23 ` Wesley Cheng 2023-02-03 1:23 ` Wesley Cheng 2023-02-03 1:44 ` Wesley Cheng 2023-02-03 1:44 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 10/22] ASoC: qdsp6: q6afe: Increase APR timeout Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:09 ` Srinivas Kandagatla 2023-01-26 15:09 ` Srinivas Kandagatla 2023-01-26 3:14 ` [RFC PATCH v2 11/22] ASoC: qcom: Add USB backend ASoC driver for Q6 Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:44 ` Pierre-Louis Bossart 2023-01-30 22:59 ` Wesley Cheng 2023-01-30 22:59 ` Wesley Cheng 2023-01-30 23:50 ` Pierre-Louis Bossart 2023-01-26 16:35 ` Srinivas Kandagatla 2023-01-26 16:35 ` Srinivas Kandagatla 2023-01-26 3:14 ` [RFC PATCH v2 12/22] sound: usb: card: Introduce USB SND platform op callbacks Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:50 ` Pierre-Louis Bossart 2023-01-30 23:00 ` Wesley Cheng 2023-01-30 23:00 ` Wesley Cheng 2023-01-28 13:28 ` Greg KH 2023-01-28 13:28 ` Greg KH 2023-02-10 22:49 ` Wesley Cheng 2023-02-10 22:49 ` Wesley Cheng 2023-02-28 2:59 ` Wesley Cheng 2023-02-28 2:59 ` Wesley Cheng 2023-02-28 7:30 ` Greg KH 2023-02-28 7:30 ` Greg KH 2023-02-28 9:19 ` Wesley Cheng 2023-02-28 9:19 ` Wesley Cheng 2023-02-28 15:29 ` Greg KH 2023-02-28 15:29 ` Greg KH 2023-02-20 17:11 ` Albert Wang 2023-02-20 17:11 ` Albert Wang 2023-01-26 3:14 ` [RFC PATCH v2 13/22] sound: usb: Export USB SND APIs for modules Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps, num-hc-interrupters definition Wesley Cheng 2023-01-26 12:01 ` [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Krzysztof Kozlowski 2023-01-26 12:01 ` Krzysztof Kozlowski 2023-01-30 22:02 ` Wesley Cheng [this message] 2023-01-30 22:02 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 15/22] usb: dwc3: Add DT parameter to specify maximum number of interrupters Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 16/22] sound: usb: Introduce QC USB SND offloading support Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 16:07 ` Pierre-Louis Bossart 2023-01-28 13:32 ` Greg KH 2023-01-28 13:32 ` Greg KH 2023-02-11 0:03 ` Wesley Cheng 2023-02-11 0:03 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 17/22] sound: usb: card: Check for support for requested audio format Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 18/22] sound: soc: soc-usb: Add PCM format check API for USB backend Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 19/22] sound: soc: qcom: qusb6: Ensure PCM format is supported by USB audio device Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 20/22] sound: usb: Prevent starting of audio stream if in use Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 16:12 ` Pierre-Louis Bossart 2023-02-07 1:15 ` Wesley Cheng 2023-02-07 1:15 ` Wesley Cheng 2023-02-07 13:29 ` Pierre-Louis Bossart 2023-02-07 13:29 ` Pierre-Louis Bossart 2023-02-11 9:52 ` Wesley Cheng 2023-02-11 9:52 ` Wesley Cheng 2023-02-13 15:22 ` Pierre-Louis Bossart 2023-02-13 20:12 ` Wesley Cheng 2023-02-13 20:12 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 21/22] ASoC: dt-bindings: Add Q6USB backend bindings Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 12:03 ` Krzysztof Kozlowski 2023-01-26 12:03 ` Krzysztof Kozlowski 2023-01-26 16:01 ` Srinivas Kandagatla 2023-01-26 16:01 ` Srinivas Kandagatla 2023-01-26 3:14 ` [RFC PATCH v2 22/22] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 12:05 ` Krzysztof Kozlowski 2023-01-26 12:05 ` Krzysztof Kozlowski 2023-01-26 9:23 ` [RFC PATCH v2 00/22] Introduce QC USB SND audio offloading support Mathias Nyman 2023-01-26 9:23 ` Mathias Nyman 2023-01-30 21:51 ` Wesley Cheng 2023-01-30 21:51 ` Wesley Cheng 2023-01-26 16:22 ` Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6655bd97-61e8-e03b-b782-bcfcc2138717@quicinc.com \ --to=quic_wcheng@quicinc.com \ --cc=Thinh.Nguyen@synopsys.com \ --cc=agross@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=andersson@kernel.org \ --cc=bgoswami@quicinc.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=perex@perex.cz \ --cc=quic_jackp@quicinc.com \ --cc=quic_plai@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.