* [PATCH 0/3] Extending hwmon ABI with attributes for rated values
@ 2020-07-31 19:37 Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 1/3] docs: hwmon: Add attributes to report " Zbigniew Lukwinski
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Zbigniew Lukwinski @ 2020-07-31 19:37 UTC (permalink / raw)
To: linux-hwmon; +Cc: linux, Zbigniew Lukwinski
This patch series is about extending hwmon ABI with new attributes
for rated values. All of that is to cover PMBus specification which
provides registers reporting rated values:
PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
chapters: 22.3.1 - 22.3.10, 22.3.15
Zbigniew Lukwinski (3):
docs: hwmon: Add attributes to report rated values
hwmon: (core) Add support for rated attributes
hwmon: (pmbus/core) Add support for rated attributes
Documentation/hwmon/pmbus.rst | 15 ++++++-
Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++
drivers/hwmon/hwmon.c | 10 +++++
drivers/hwmon/pmbus/pmbus.h | 13 ++++++
drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++----
include/linux/hwmon.h | 20 ++++++++++
6 files changed, 168 insertions(+), 9 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] docs: hwmon: Add attributes to report rated values
2020-07-31 19:37 [PATCH 0/3] Extending hwmon ABI with attributes for rated values Zbigniew Lukwinski
@ 2020-07-31 19:37 ` Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 2/3] hwmon: (core) Add support for rated attributes Zbigniew Lukwinski
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Zbigniew Lukwinski @ 2020-07-31 19:37 UTC (permalink / raw)
To: linux-hwmon; +Cc: linux, Zbigniew Lukwinski
New attributes (rated_min/rated_max) are being added the hwmon ABI.
They are needed to cover rated values documented by PMBus
specification:
PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
chapters: 22.3.1 - 22.3.10, 22.3.15
Signed-off-by: Zbigniew Lukwinski <zbigniew.lukwinski@linux.intel.com>
---
Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++
1 file changed, 70 insertions(+)
diff --git a/Documentation/hwmon/sysfs-interface.rst b/Documentation/hwmon/sysfs-interface.rst
index fd59063..678c9c6 100644
--- a/Documentation/hwmon/sysfs-interface.rst
+++ b/Documentation/hwmon/sysfs-interface.rst
@@ -241,6 +241,20 @@ Voltages
Affects the way the driver calculates the CPU core reference
voltage from the vid pins.
+`in[0-*]_rated_min`
+ Minimum rated voltage.
+
+ Unit: millivolt
+
+ RO
+
+`in[0-*]_rated_max`
+ Maximum rated voltage.
+
+ Unit: millivolt
+
+ RO
+
Also see the Alarms section for status flags associated with voltages.
@@ -574,6 +588,20 @@ Temperatures
RW
+`temp[1-*]_rated_min`
+ Minimum rated temperature.
+
+ Unit: millidegree Celsius
+
+ RO
+
+`temp[1-*]_rated_max`
+ Maximum rated temperature.
+
+ Unit: millidegree Celsius
+
+ RO
+
Some chips measure temperature using external thermistors and an ADC, and
report the temperature measurement as a voltage. Converting this voltage
back to a temperature (or the other way around for limits) requires
@@ -664,6 +692,20 @@ Currents
RW
+`curr[1-*]_rated_min`
+ Minimum rated current.
+
+ Unit: milliampere
+
+ RO
+
+`curr[1-*]_rated_max`
+ Maximum rated current.
+
+ Unit: milliampere
+
+ RO
+
Also see the Alarms section for status flags associated with currents.
*****
@@ -830,6 +872,20 @@ Power
RW
+`power[1-*]_rated_min`
+ Minimum rated power.
+
+ Unit: microWatt
+
+ RO
+
+`power[1-*]_rated_max`
+ Maximum rated power.
+
+ Unit: microWatt
+
+ RO
+
Also see the Alarms section for status flags associated with power readings.
******
@@ -877,6 +933,20 @@ Humidity
RW
+`humidity[1-*]_rated_min`
+ Minimum rated humidity.
+
+ Unit: milli-percent (per cent mille, pcm)
+
+ RO
+
+`humidity[1-*]_rated_max`
+ Maximum rated humidity.
+
+ Unit: milli-percent (per cent mille, pcm)
+
+ RO
+
******
Alarms
******
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] hwmon: (core) Add support for rated attributes
2020-07-31 19:37 [PATCH 0/3] Extending hwmon ABI with attributes for rated values Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 1/3] docs: hwmon: Add attributes to report " Zbigniew Lukwinski
@ 2020-07-31 19:37 ` Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 3/3] hwmon: (pmbus/core) " Zbigniew Lukwinski
2020-08-07 15:52 ` [PATCH 0/3] Extending hwmon ABI with attributes for rated values Guenter Roeck
3 siblings, 0 replies; 6+ messages in thread
From: Zbigniew Lukwinski @ 2020-07-31 19:37 UTC (permalink / raw)
To: linux-hwmon; +Cc: linux, Zbigniew Lukwinski
Adding implementation for new attributes (rated_min/rated_max) for
currentX, inX, powerX, tempX and humidityX.
Tested with OpenBMC stack and simple hwmon driver using
rated_min/rated_max for the following types of sensors: hwmon_temp,
hwmon_in, hwmon_curr, hwmon_power, hwmon_humidity.
For each sensor rated attributes were available and returned
expected values.
Signed-off-by: Zbigniew Lukwinski <zbigniew.lukwinski@linux.intel.com>
---
drivers/hwmon/hwmon.c | 10 ++++++++++
include/linux/hwmon.h | 20 ++++++++++++++++++++
2 files changed, 30 insertions(+)
diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index 3f596a5..6c68405 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -431,6 +431,8 @@ static const char * const hwmon_temp_attr_templates[] = {
[hwmon_temp_lowest] = "temp%d_lowest",
[hwmon_temp_highest] = "temp%d_highest",
[hwmon_temp_reset_history] = "temp%d_reset_history",
+ [hwmon_temp_rated_min] = "temp%d_rated_min",
+ [hwmon_temp_rated_max] = "temp%d_rated_max",
};
static const char * const hwmon_in_attr_templates[] = {
@@ -450,6 +452,8 @@ static const char * const hwmon_in_attr_templates[] = {
[hwmon_in_max_alarm] = "in%d_max_alarm",
[hwmon_in_lcrit_alarm] = "in%d_lcrit_alarm",
[hwmon_in_crit_alarm] = "in%d_crit_alarm",
+ [hwmon_in_rated_min] = "in%d_rated_min",
+ [hwmon_in_rated_max] = "in%d_rated_max",
};
static const char * const hwmon_curr_attr_templates[] = {
@@ -469,6 +473,8 @@ static const char * const hwmon_curr_attr_templates[] = {
[hwmon_curr_max_alarm] = "curr%d_max_alarm",
[hwmon_curr_lcrit_alarm] = "curr%d_lcrit_alarm",
[hwmon_curr_crit_alarm] = "curr%d_crit_alarm",
+ [hwmon_curr_rated_min] = "curr%d_rated_min",
+ [hwmon_curr_rated_max] = "curr%d_rated_max",
};
static const char * const hwmon_power_attr_templates[] = {
@@ -501,6 +507,8 @@ static const char * const hwmon_power_attr_templates[] = {
[hwmon_power_max_alarm] = "power%d_max_alarm",
[hwmon_power_lcrit_alarm] = "power%d_lcrit_alarm",
[hwmon_power_crit_alarm] = "power%d_crit_alarm",
+ [hwmon_power_rated_min] = "power%d_rated_min",
+ [hwmon_power_rated_max] = "power%d_rated_max",
};
static const char * const hwmon_energy_attr_templates[] = {
@@ -519,6 +527,8 @@ static const char * const hwmon_humidity_attr_templates[] = {
[hwmon_humidity_max_hyst] = "humidity%d_max_hyst",
[hwmon_humidity_alarm] = "humidity%d_alarm",
[hwmon_humidity_fault] = "humidity%d_fault",
+ [hwmon_humidity_rated_min] = "humidity%d_rated_min",
+ [hwmon_humidity_rated_max] = "humidity%d_rated_max",
};
static const char * const hwmon_fan_attr_templates[] = {
diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
index 363d4a8..1e8d6ea 100644
--- a/include/linux/hwmon.h
+++ b/include/linux/hwmon.h
@@ -85,6 +85,8 @@ enum hwmon_temp_attributes {
hwmon_temp_lowest,
hwmon_temp_highest,
hwmon_temp_reset_history,
+ hwmon_temp_rated_min,
+ hwmon_temp_rated_max,
};
#define HWMON_T_ENABLE BIT(hwmon_temp_enable)
@@ -112,6 +114,8 @@ enum hwmon_temp_attributes {
#define HWMON_T_LOWEST BIT(hwmon_temp_lowest)
#define HWMON_T_HIGHEST BIT(hwmon_temp_highest)
#define HWMON_T_RESET_HISTORY BIT(hwmon_temp_reset_history)
+#define HWMON_T_RATED_MIN BIT(hwmon_temp_rated_min)
+#define HWMON_T_RATED_MAX BIT(hwmon_temp_rated_max)
enum hwmon_in_attributes {
hwmon_in_enable,
@@ -130,6 +134,8 @@ enum hwmon_in_attributes {
hwmon_in_max_alarm,
hwmon_in_lcrit_alarm,
hwmon_in_crit_alarm,
+ hwmon_in_rated_min,
+ hwmon_in_rated_max,
};
#define HWMON_I_ENABLE BIT(hwmon_in_enable)
@@ -148,6 +154,8 @@ enum hwmon_in_attributes {
#define HWMON_I_MAX_ALARM BIT(hwmon_in_max_alarm)
#define HWMON_I_LCRIT_ALARM BIT(hwmon_in_lcrit_alarm)
#define HWMON_I_CRIT_ALARM BIT(hwmon_in_crit_alarm)
+#define HWMON_I_RATED_MIN BIT(hwmon_in_rated_min)
+#define HWMON_I_RATED_MAX BIT(hwmon_in_rated_max)
enum hwmon_curr_attributes {
hwmon_curr_enable,
@@ -166,6 +174,8 @@ enum hwmon_curr_attributes {
hwmon_curr_max_alarm,
hwmon_curr_lcrit_alarm,
hwmon_curr_crit_alarm,
+ hwmon_curr_rated_min,
+ hwmon_curr_rated_max,
};
#define HWMON_C_ENABLE BIT(hwmon_curr_enable)
@@ -184,6 +194,8 @@ enum hwmon_curr_attributes {
#define HWMON_C_MAX_ALARM BIT(hwmon_curr_max_alarm)
#define HWMON_C_LCRIT_ALARM BIT(hwmon_curr_lcrit_alarm)
#define HWMON_C_CRIT_ALARM BIT(hwmon_curr_crit_alarm)
+#define HWMON_C_RATED_MIN BIT(hwmon_curr_rated_min)
+#define HWMON_C_RATED_MAX BIT(hwmon_curr_rated_max)
enum hwmon_power_attributes {
hwmon_power_enable,
@@ -215,6 +227,8 @@ enum hwmon_power_attributes {
hwmon_power_max_alarm,
hwmon_power_lcrit_alarm,
hwmon_power_crit_alarm,
+ hwmon_power_rated_min,
+ hwmon_power_rated_max,
};
#define HWMON_P_ENABLE BIT(hwmon_power_enable)
@@ -246,6 +260,8 @@ enum hwmon_power_attributes {
#define HWMON_P_MAX_ALARM BIT(hwmon_power_max_alarm)
#define HWMON_P_LCRIT_ALARM BIT(hwmon_power_lcrit_alarm)
#define HWMON_P_CRIT_ALARM BIT(hwmon_power_crit_alarm)
+#define HWMON_P_RATED_MIN BIT(hwmon_power_rated_min)
+#define HWMON_P_RATED_MAX BIT(hwmon_power_rated_max)
enum hwmon_energy_attributes {
hwmon_energy_enable,
@@ -267,6 +283,8 @@ enum hwmon_humidity_attributes {
hwmon_humidity_max_hyst,
hwmon_humidity_alarm,
hwmon_humidity_fault,
+ hwmon_humidity_rated_min,
+ hwmon_humidity_rated_max,
};
#define HWMON_H_ENABLE BIT(hwmon_humidity_enable)
@@ -278,6 +296,8 @@ enum hwmon_humidity_attributes {
#define HWMON_H_MAX_HYST BIT(hwmon_humidity_max_hyst)
#define HWMON_H_ALARM BIT(hwmon_humidity_alarm)
#define HWMON_H_FAULT BIT(hwmon_humidity_fault)
+#define HWMON_H_RATED_MIN BIT(hwmon_humidity_rated_min)
+#define HWMON_H_RATED_MAX BIT(hwmon_humidity_rated_max)
enum hwmon_fan_attributes {
hwmon_fan_enable,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] hwmon: (pmbus/core) Add support for rated attributes
2020-07-31 19:37 [PATCH 0/3] Extending hwmon ABI with attributes for rated values Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 1/3] docs: hwmon: Add attributes to report " Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 2/3] hwmon: (core) Add support for rated attributes Zbigniew Lukwinski
@ 2020-07-31 19:37 ` Zbigniew Lukwinski
2020-08-07 15:52 ` [PATCH 0/3] Extending hwmon ABI with attributes for rated values Guenter Roeck
3 siblings, 0 replies; 6+ messages in thread
From: Zbigniew Lukwinski @ 2020-07-31 19:37 UTC (permalink / raw)
To: linux-hwmon; +Cc: linux, Zbigniew Lukwinski
Adding implementation for new attributes (rated_min/rated_max) to
cover PMBus specification about rated values reporting:
MFR_VIN_MIN, MFR_VIN_MAX, MFR_IIN_MAX, MFR_PIN_MAX, MFR_VOUT_MIN,
MFR_VOUT_MAX, MFR_IOUT_MAX, MFR_POUT_MAX, MFR_MAX_TEMP_1/2/3.
Tested with OpenBMC stack. All rated attributes were available
and reported correct values.
Signed-off-by: Zbigniew Lukwinski <zbigniew.lukwinski@linux.intel.com>
---
Documentation/hwmon/pmbus.rst | 15 +++++++++++-
drivers/hwmon/pmbus/pmbus.h | 13 +++++++++++
drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++++++++++++++++-------
3 files changed, 68 insertions(+), 9 deletions(-)
diff --git a/Documentation/hwmon/pmbus.rst b/Documentation/hwmon/pmbus.rst
index 2658dde..fd3403b 100644
--- a/Documentation/hwmon/pmbus.rst
+++ b/Documentation/hwmon/pmbus.rst
@@ -211,6 +211,10 @@ inX_lcrit_alarm Voltage critical low alarm.
inX_crit_alarm Voltage critical high alarm.
From VOLTAGE_OV_FAULT status.
inX_label "vin", "vcap", or "voutY"
+inX_rated_min Minimum rated voltage.
+ From MFR_VIN_MIN or MFR_VOUT_MIN register.
+inX_rated_max Maximum rated voltage.
+ From MFR_VIN_MAX or MFR_VOUT_MAX register.
currX_input Measured current. From READ_IIN or READ_IOUT register.
currX_max Maximum current.
@@ -230,6 +234,8 @@ currX_crit_alarm Current critical high alarm.
currX_label "iin", "iinY", "iinY.Z", "ioutY", or "ioutY.Z",
where Y reflects the page number and Z reflects the
phase.
+currX_rated_max Maximum rated current.
+ From MFR_IIN_MAX or MFR_IOUT_MAX register.
powerX_input Measured power. From READ_PIN or READ_POUT register.
powerX_cap Output power cap. From POUT_MAX register.
@@ -244,10 +250,12 @@ powerX_crit_alarm Output power critical high alarm.
powerX_label "pin", "pinY", "pinY.Z", "poutY", or "poutY.Z",
where Y reflects the page number and Z reflects the
phase.
+powerX_rated_max Maximum rated power.
+ From MFR_PIN_MAX or MFR_POUT_MAX register.
tempX_input Measured temperature.
From READ_TEMPERATURE_X register.
-tempX_min Mimimum temperature. From UT_WARN_LIMIT register.
+tempX_min Minimum temperature. From UT_WARN_LIMIT register.
tempX_max Maximum temperature. From OT_WARN_LIMIT register.
tempX_lcrit Critical low temperature.
From UT_FAULT_LIMIT register.
@@ -265,4 +273,9 @@ tempX_lcrit_alarm Chip temperature critical low alarm. Set by comparing
tempX_crit_alarm Chip temperature critical high alarm. Set by comparing
READ_TEMPERATURE_X with OT_FAULT_LIMIT if
TEMP_OT_FAULT status is set.
+tempX_rated_min Minimum rated temperature.
+ From MFR_TAMBIENT_MIN register.
+tempX_rated_max Maximum rated temperature.
+ From MFR_TAMBIENT_MAX, MFR_MAX_TEMP_1, MFR_MAX_TEMP_2 or
+ MFR_MAX_TEMP_3 register.
======================= ========================================================
diff --git a/drivers/hwmon/pmbus/pmbus.h b/drivers/hwmon/pmbus/pmbus.h
index 18e06fc..6d9f2cf 100644
--- a/drivers/hwmon/pmbus/pmbus.h
+++ b/drivers/hwmon/pmbus/pmbus.h
@@ -119,9 +119,22 @@ enum pmbus_regs {
PMBUS_MFR_DATE = 0x9D,
PMBUS_MFR_SERIAL = 0x9E,
+ PMBUS_MFR_VIN_MIN = 0xA0,
+ PMBUS_MFR_VIN_MAX = 0xA1,
+ PMBUS_MFR_IIN_MAX = 0xA2,
+ PMBUS_MFR_PIN_MAX = 0xA3,
+ PMBUS_MFR_VOUT_MIN = 0xA4,
+ PMBUS_MFR_VOUT_MAX = 0xA5,
+ PMBUS_MFR_IOUT_MAX = 0xA6,
+ PMBUS_MFR_POUT_MAX = 0xA7,
+
PMBUS_IC_DEVICE_ID = 0xAD,
PMBUS_IC_DEVICE_REV = 0xAE,
+ PMBUS_MFR_MAX_TEMP_1 = 0xC0,
+ PMBUS_MFR_MAX_TEMP_2 = 0xC1,
+ PMBUS_MFR_MAX_TEMP_3 = 0xC2,
+
/*
* Virtual registers.
* Useful to support attributes which are not supported by standard PMBus
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 2191575..e51fb04 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -1408,6 +1408,12 @@ static const struct pmbus_limit_attr vin_limit_attrs[] = {
}, {
.reg = PMBUS_VIRT_RESET_VIN_HISTORY,
.attr = "reset_history",
+ }, {
+ .reg = PMBUS_MFR_VIN_MIN,
+ .attr = "rated_min",
+ }, {
+ .reg = PMBUS_MFR_VIN_MAX,
+ .attr = "rated_max",
},
};
@@ -1471,7 +1477,13 @@ static const struct pmbus_limit_attr vout_limit_attrs[] = {
}, {
.reg = PMBUS_VIRT_RESET_VOUT_HISTORY,
.attr = "reset_history",
- }
+ }, {
+ .reg = PMBUS_MFR_VOUT_MIN,
+ .attr = "rated_min",
+ }, {
+ .reg = PMBUS_MFR_VOUT_MAX,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_sensor_attr voltage_attributes[] = {
@@ -1541,7 +1553,10 @@ static const struct pmbus_limit_attr iin_limit_attrs[] = {
}, {
.reg = PMBUS_VIRT_RESET_IIN_HISTORY,
.attr = "reset_history",
- }
+ }, {
+ .reg = PMBUS_MFR_IIN_MAX,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_limit_attr iout_limit_attrs[] = {
@@ -1575,7 +1590,10 @@ static const struct pmbus_limit_attr iout_limit_attrs[] = {
}, {
.reg = PMBUS_VIRT_RESET_IOUT_HISTORY,
.attr = "reset_history",
- }
+ }, {
+ .reg = PMBUS_MFR_IOUT_MAX,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_sensor_attr current_attributes[] = {
@@ -1626,7 +1644,10 @@ static const struct pmbus_limit_attr pin_limit_attrs[] = {
}, {
.reg = PMBUS_VIRT_RESET_PIN_HISTORY,
.attr = "reset_history",
- }
+ }, {
+ .reg = PMBUS_MFR_PIN_MAX,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_limit_attr pout_limit_attrs[] = {
@@ -1660,7 +1681,10 @@ static const struct pmbus_limit_attr pout_limit_attrs[] = {
}, {
.reg = PMBUS_VIRT_RESET_POUT_HISTORY,
.attr = "reset_history",
- }
+ }, {
+ .reg = PMBUS_MFR_POUT_MAX,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_sensor_attr power_attributes[] = {
@@ -1724,7 +1748,10 @@ static const struct pmbus_limit_attr temp_limit_attrs[] = {
}, {
.reg = PMBUS_VIRT_RESET_TEMP_HISTORY,
.attr = "reset_history",
- }
+ }, {
+ .reg = PMBUS_MFR_MAX_TEMP_1,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_limit_attr temp_limit_attrs2[] = {
@@ -1762,7 +1789,10 @@ static const struct pmbus_limit_attr temp_limit_attrs2[] = {
}, {
.reg = PMBUS_VIRT_RESET_TEMP2_HISTORY,
.attr = "reset_history",
- }
+ }, {
+ .reg = PMBUS_MFR_MAX_TEMP_2,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_limit_attr temp_limit_attrs3[] = {
@@ -1788,7 +1818,10 @@ static const struct pmbus_limit_attr temp_limit_attrs3[] = {
.attr = "crit",
.alarm = "crit_alarm",
.sbit = PB_TEMP_OT_FAULT,
- }
+ }, {
+ .reg = PMBUS_MFR_MAX_TEMP_3,
+ .attr = "rated_max",
+ },
};
static const struct pmbus_sensor_attr temp_attributes[] = {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Extending hwmon ABI with attributes for rated values
2020-07-31 19:37 [PATCH 0/3] Extending hwmon ABI with attributes for rated values Zbigniew Lukwinski
` (2 preceding siblings ...)
2020-07-31 19:37 ` [PATCH 3/3] hwmon: (pmbus/core) " Zbigniew Lukwinski
@ 2020-08-07 15:52 ` Guenter Roeck
2020-08-10 5:39 ` zlukwins
3 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2020-08-07 15:52 UTC (permalink / raw)
To: Zbigniew Lukwinski, linux-hwmon
On 7/31/20 12:37 PM, Zbigniew Lukwinski wrote:
> This patch series is about extending hwmon ABI with new attributes
> for rated values. All of that is to cover PMBus specification which
> provides registers reporting rated values:
> PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
> chapters: 22.3.1 - 22.3.10, 22.3.15
>
> Zbigniew Lukwinski (3):
> docs: hwmon: Add attributes to report rated values
> hwmon: (core) Add support for rated attributes
> hwmon: (pmbus/core) Add support for rated attributes
>
> Documentation/hwmon/pmbus.rst | 15 ++++++-
> Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++
> drivers/hwmon/hwmon.c | 10 +++++
> drivers/hwmon/pmbus/pmbus.h | 13 ++++++
> drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++----
> include/linux/hwmon.h | 20 ++++++++++
> 6 files changed, 168 insertions(+), 9 deletions(-)
>
I have been struggling with "rated_{min,max}" vs. "{min,max}_rated",
but then figured it does not really make a difference, and rated_ as
prefix may actually make more sense. I'll queue the series for v5.10.
Let's see if there is any feedback.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/3] Extending hwmon ABI with attributes for rated values
2020-08-07 15:52 ` [PATCH 0/3] Extending hwmon ABI with attributes for rated values Guenter Roeck
@ 2020-08-10 5:39 ` zlukwins
0 siblings, 0 replies; 6+ messages in thread
From: zlukwins @ 2020-08-10 5:39 UTC (permalink / raw)
To: Guenter Roeck, linux-hwmon
On 8/7/20 5:52 PM, Guenter Roeck wrote:
> On 7/31/20 12:37 PM, Zbigniew Lukwinski wrote:
>> This patch series is about extending hwmon ABI with new attributes
>> for rated values. All of that is to cover PMBus specification which
>> provides registers reporting rated values:
>> PMBus Power System Mgt Protocol Specification - Part II – Revision 1.3.1,
>> chapters: 22.3.1 - 22.3.10, 22.3.15
>>
>> Zbigniew Lukwinski (3):
>> docs: hwmon: Add attributes to report rated values
>> hwmon: (core) Add support for rated attributes
>> hwmon: (pmbus/core) Add support for rated attributes
>>
>> Documentation/hwmon/pmbus.rst | 15 ++++++-
>> Documentation/hwmon/sysfs-interface.rst | 70 +++++++++++++++++++++++++++++++++
>> drivers/hwmon/hwmon.c | 10 +++++
>> drivers/hwmon/pmbus/pmbus.h | 13 ++++++
>> drivers/hwmon/pmbus/pmbus_core.c | 49 +++++++++++++++++++----
>> include/linux/hwmon.h | 20 ++++++++++
>> 6 files changed, 168 insertions(+), 9 deletions(-)
>>
> I have been struggling with "rated_{min,max}" vs. "{min,max}_rated",
> but then figured it does not really make a difference, and rated_ as
> prefix may actually make more sense. I'll queue the series for v5.10.
> Let's see if there is any feedback.
>
> Thanks,
> Guenter
Sure.
Thanks,
Zbigniew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-10 5:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31 19:37 [PATCH 0/3] Extending hwmon ABI with attributes for rated values Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 1/3] docs: hwmon: Add attributes to report " Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 2/3] hwmon: (core) Add support for rated attributes Zbigniew Lukwinski
2020-07-31 19:37 ` [PATCH 3/3] hwmon: (pmbus/core) " Zbigniew Lukwinski
2020-08-07 15:52 ` [PATCH 0/3] Extending hwmon ABI with attributes for rated values Guenter Roeck
2020-08-10 5:39 ` zlukwins
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.