* [PATCH V1] ASoC: fsl_esai: replace fall-through with break
@ 2019-04-08 9:28 S.j. Wang
2019-04-08 15:55 ` Gustavo A. R. Silva
2019-04-10 3:51 ` Nicolin Chen
0 siblings, 2 replies; 9+ messages in thread
From: S.j. Wang @ 2019-04-08 9:28 UTC (permalink / raw)
To: timur, nicoleotsuka, Xiubo.Lee, festevam, broonie, alsa-devel, gustavo
Cc: linuxppc-dev
case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
each other, so replace fall-through with break.
Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch fall-through")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
sound/soc/fsl/fsl_esai.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index c7410bbfd2af..bad0dfed6b68 100644
--- a/sound/soc/fsl/fsl_esai.c
+++ b/sound/soc/fsl/fsl_esai.c
@@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
break;
case ESAI_HCKT_EXTAL:
ecr |= ESAI_ECR_ETI;
- /* fall through */
+ break;
case ESAI_HCKR_EXTAL:
ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
2019-04-08 9:28 [PATCH V1] ASoC: fsl_esai: replace fall-through with break S.j. Wang
@ 2019-04-08 15:55 ` Gustavo A. R. Silva
2019-04-09 2:54 ` S.j. Wang
2019-04-10 3:51 ` Nicolin Chen
1 sibling, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-08 15:55 UTC (permalink / raw)
To: S.j. Wang, timur, nicoleotsuka, Xiubo.Lee, festevam, broonie, alsa-devel
Cc: linuxppc-dev
On 4/8/19 4:28 AM, S.j. Wang wrote:
> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
> each other, so replace fall-through with break.
>
If this is correct, then you should use the following "Fixes" tag instead,
which is the one that introduced the bug:
Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
> Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch fall-through")
>
^^^^
because this didn't change any functionality.
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> sound/soc/fsl/fsl_esai.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> index c7410bbfd2af..bad0dfed6b68 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
> break;
> case ESAI_HCKT_EXTAL:
> ecr |= ESAI_ECR_ETI;
Also, you should use a simple assignment operator "=" instead of "|=" in both cases.
> - /* fall through */
> + break;
> case ESAI_HCKR_EXTAL:
> ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
> break;
>
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
2019-04-08 15:55 ` Gustavo A. R. Silva
@ 2019-04-09 2:54 ` S.j. Wang
0 siblings, 0 replies; 9+ messages in thread
From: S.j. Wang @ 2019-04-09 2:54 UTC (permalink / raw)
To: Gustavo A. R. Silva, timur, nicoleotsuka, Xiubo.Lee, festevam,
broonie, alsa-devel
Cc: linuxppc-dev
Hi Gustavo
>
>
> On 4/8/19 4:28 AM, S.j. Wang wrote:
> > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be
> independent of
> > each other, so replace fall-through with break.
> >
> If this is correct, then you should use the following "Fixes" tag instead,
> which is the one that introduced the bug:
>
> Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
>
> > Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch
> > fall-through")
> >
> ^^^^
> because this didn't change any functionality.
Ok, this will be updated.
>
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> > sound/soc/fsl/fsl_esai.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index
> > c7410bbfd2af..bad0dfed6b68 100644
> > --- a/sound/soc/fsl/fsl_esai.c
> > +++ b/sound/soc/fsl/fsl_esai.c
> > @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct
> snd_soc_dai *dai, int clk_id,
> > break;
> > case ESAI_HCKT_EXTAL:
> > ecr |= ESAI_ECR_ETI;
>
> Also, you should use a simple assignment operator "=" instead of "|=" in
> both cases.
The result is same for "=" and "|=", because there is "ecr = 0" in beginning of
This function.
>
> > - /* fall through */
> > + break;
> > case ESAI_HCKR_EXTAL:
> > ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
> > break;
> >
>
> Thanks
> --
> Gustavo
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
@ 2019-04-09 2:54 ` S.j. Wang
0 siblings, 0 replies; 9+ messages in thread
From: S.j. Wang @ 2019-04-09 2:54 UTC (permalink / raw)
To: Gustavo A. R. Silva, timur, nicoleotsuka, Xiubo.Lee, festevam,
broonie, alsa-devel
Cc: linuxppc-dev
Hi Gustavo
>
>
> On 4/8/19 4:28 AM, S.j. Wang wrote:
> > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be
> independent of
> > each other, so replace fall-through with break.
> >
> If this is correct, then you should use the following "Fixes" tag instead,
> which is the one that introduced the bug:
>
> Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
>
> > Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch
> > fall-through")
> >
> ^^^^
> because this didn't change any functionality.
Ok, this will be updated.
>
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> > sound/soc/fsl/fsl_esai.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index
> > c7410bbfd2af..bad0dfed6b68 100644
> > --- a/sound/soc/fsl/fsl_esai.c
> > +++ b/sound/soc/fsl/fsl_esai.c
> > @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct
> snd_soc_dai *dai, int clk_id,
> > break;
> > case ESAI_HCKT_EXTAL:
> > ecr |= ESAI_ECR_ETI;
>
> Also, you should use a simple assignment operator "=" instead of "|=" in
> both cases.
The result is same for "=" and "|=", because there is "ecr = 0" in beginning of
This function.
>
> > - /* fall through */
> > + break;
> > case ESAI_HCKR_EXTAL:
> > ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
> > break;
> >
>
> Thanks
> --
> Gustavo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
2019-04-09 2:54 ` S.j. Wang
(?)
@ 2019-04-09 3:20 ` Gustavo A. R. Silva
2019-04-09 3:54 ` Nicolin Chen
-1 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-09 3:20 UTC (permalink / raw)
To: S.j. Wang, timur, nicoleotsuka, Xiubo.Lee, festevam, broonie, alsa-devel
Cc: linuxppc-dev
Hi Shengjiu,
On 4/8/19 9:54 PM, S.j. Wang wrote:
> Hi Gustavo
>
>>
>>
>> On 4/8/19 4:28 AM, S.j. Wang wrote:
>>> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be
>> independent of
>>> each other, so replace fall-through with break.
>>>
>> If this is correct, then you should use the following "Fixes" tag instead,
>> which is the one that introduced the bug:
>>
>> Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
>>
>>> Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch
>>> fall-through")
>>>
>> ^^^^
>> because this didn't change any functionality.
>
> Ok, this will be updated.
>
>>
>>> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
>>> ---
>>> sound/soc/fsl/fsl_esai.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index
>>> c7410bbfd2af..bad0dfed6b68 100644
>>> --- a/sound/soc/fsl/fsl_esai.c
>>> +++ b/sound/soc/fsl/fsl_esai.c
>>> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct
>> snd_soc_dai *dai, int clk_id,
>>> break;
>>> case ESAI_HCKT_EXTAL:
>>> ecr |= ESAI_ECR_ETI;
>>
>> Also, you should use a simple assignment operator "=" instead of "|=" in
>> both cases.
>
> The result is same for "=" and "|=", because there is "ecr = 0" in beginning of
> This function.
>
Following that same logic, then why not use "+=" instead?
The point is: is "|=" or any other assignment operator other than "=" necessary?
The answer in this case is: no, it is not. So, go for the simple one and avoid
any unnecessary confusion.
Also, there is no need for versioning a patch for it's first revision. If you
receive feedback on a patch and are asked to update it, then you do need to
version the patches that you re-send.
Thanks
--
Gustavo
>>
>>> - /* fall through */
>>> + break;
>>> case ESAI_HCKR_EXTAL:
>>> ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
>>> break;
>>>
>>
>> Thanks
>> --
>> Gustavo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
2019-04-09 3:20 ` Gustavo A. R. Silva
@ 2019-04-09 3:54 ` Nicolin Chen
2019-04-10 2:39 ` S.j. Wang
0 siblings, 1 reply; 9+ messages in thread
From: Nicolin Chen @ 2019-04-09 3:54 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: alsa-devel, timur, Xiubo.Lee, linuxppc-dev, S.j. Wang, broonie, festevam
Hi Gustavo,
On Mon, Apr 08, 2019 at 10:20:25PM -0500, Gustavo A. R. Silva wrote:
> >>> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index
> >>> c7410bbfd2af..bad0dfed6b68 100644
> >>> --- a/sound/soc/fsl/fsl_esai.c
> >>> +++ b/sound/soc/fsl/fsl_esai.c
> >>> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct
> >> snd_soc_dai *dai, int clk_id,
> >>> break;
> >>> case ESAI_HCKT_EXTAL:
> >>> ecr |= ESAI_ECR_ETI;
> >>
> >> Also, you should use a simple assignment operator "=" instead of "|=" in
> >> both cases.
> >
> > The result is same for "=" and "|=", because there is "ecr = 0" in beginning of
> > This function.
> >
>
> Following that same logic, then why not use "+=" instead?
>
> The point is: is "|=" or any other assignment operator other than "=" necessary?
> The answer in this case is: no, it is not. So, go for the simple one and avoid
> any unnecessary confusion.
I would like to keep "|=" here, just in case that someday it'd be easier
to insert something to ecr before this chunk. So please get easy on this
one.
Thanks
Nicolin
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
2019-04-09 3:54 ` Nicolin Chen
@ 2019-04-10 2:39 ` S.j. Wang
0 siblings, 0 replies; 9+ messages in thread
From: S.j. Wang @ 2019-04-10 2:39 UTC (permalink / raw)
To: Nicolin Chen, Gustavo A. R. Silva
Cc: alsa-devel, timur, Xiubo.Lee, festevam, broonie, linuxppc-dev
Hi
>
> Hi Gustavo,
>
> On Mon, Apr 08, 2019 at 10:20:25PM -0500, Gustavo A. R. Silva wrote:
> > >>> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> > >>> index
> > >>> c7410bbfd2af..bad0dfed6b68 100644
> > >>> --- a/sound/soc/fsl/fsl_esai.c
> > >>> +++ b/sound/soc/fsl/fsl_esai.c
> > >>> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct
> > >> snd_soc_dai *dai, int clk_id,
> > >>> break;
> > >>> case ESAI_HCKT_EXTAL:
> > >>> ecr |= ESAI_ECR_ETI;
> > >>
> > >> Also, you should use a simple assignment operator "=" instead of
> > >> "|=" in both cases.
> > >
> > > The result is same for "=" and "|=", because there is "ecr = 0" in
> > > beginning of This function.
> > >
> >
> > Following that same logic, then why not use "+=" instead?
> >
> > The point is: is "|=" or any other assignment operator other than "="
> necessary?
> > The answer in this case is: no, it is not. So, go for the simple one
> > and avoid any unnecessary confusion.
>
> I would like to keep "|=" here, just in case that someday it'd be easier to
> insert something to ecr before this chunk. So please get easy on this one.
>
> Thanks
> Nicolin
Thanks for reviewing, I will send v2.
Best regards
Wang shengjiu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
2019-04-08 9:28 [PATCH V1] ASoC: fsl_esai: replace fall-through with break S.j. Wang
2019-04-08 15:55 ` Gustavo A. R. Silva
@ 2019-04-10 3:51 ` Nicolin Chen
2019-04-10 3:52 ` Nicolin Chen
1 sibling, 1 reply; 9+ messages in thread
From: Nicolin Chen @ 2019-04-10 3:51 UTC (permalink / raw)
To: S.j. Wang
Cc: alsa-devel, timur, gustavo, linuxppc-dev, Xiubo.Lee, broonie, festevam
On Mon, Apr 08, 2019 at 09:28:06AM +0000, S.j. Wang wrote:
> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
> each other, so replace fall-through with break.
>
> Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch fall-through")
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break
2019-04-10 3:51 ` Nicolin Chen
@ 2019-04-10 3:52 ` Nicolin Chen
0 siblings, 0 replies; 9+ messages in thread
From: Nicolin Chen @ 2019-04-10 3:52 UTC (permalink / raw)
To: S.j. Wang
Cc: alsa-devel, timur, gustavo, linuxppc-dev, Xiubo.Lee, broonie, festevam
On Tue, Apr 09, 2019 at 08:50:59PM -0700, Nicolin Chen wrote:
> On Mon, Apr 08, 2019 at 09:28:06AM +0000, S.j. Wang wrote:
> > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
> > each other, so replace fall-through with break.
> >
> > Fixes: 16bbeb2b43c3 ("ASoC: fsl_esai: Mark expected switch fall-through")
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
>
> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
>
> Thanks
Oops. Acked the older version...should have gong for v2.
Please ignore it.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-04-10 3:52 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 9:28 [PATCH V1] ASoC: fsl_esai: replace fall-through with break S.j. Wang
2019-04-08 15:55 ` Gustavo A. R. Silva
2019-04-09 2:54 ` [EXT] " S.j. Wang
2019-04-09 2:54 ` S.j. Wang
2019-04-09 3:20 ` Gustavo A. R. Silva
2019-04-09 3:54 ` Nicolin Chen
2019-04-10 2:39 ` S.j. Wang
2019-04-10 3:51 ` Nicolin Chen
2019-04-10 3:52 ` Nicolin Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.