From: John Garry <john.garry@huawei.com> To: Leo Yan <leo.yan@linaro.org>, Jianlin Lv <Jianlin.Lv@arm.com> Cc: <will@kernel.org>, <mathieu.poirier@linaro.org>, <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>, <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>, <namhyung@kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] perf tools: Fix arm64 build error with gcc-11 Date: Tue, 9 Feb 2021 14:18:26 +0000 [thread overview] Message-ID: <66c8385e-b9fb-4a5b-a55e-e1543ad3d3c3@huawei.com> (raw) In-Reply-To: <20210209121728.GA12546@leoy-ThinkPad-X240s> On 09/02/2021 12:17, Leo Yan wrote: > Hi Jianlin, > > On Tue, Feb 09, 2021 at 07:33:57PM +0800, Jianlin Lv wrote: >> gcc version: 11.0.0 20210208 (experimental) (GCC) >> >> Following build error on arm64: >> >> ....... >> In function ‘printf’, >> inlined from ‘regs_dump__printf’ at util/session.c:1141:3, >> inlined from ‘regs__printf’ at util/session.c:1169:2: >> /usr/include/aarch64-linux-gnu/bits/stdio2.h:107:10: \ >> error: ‘%-5s’ directive argument is null [-Werror=format-overflow=] >> >> 107 | return __printf_chk (__USE_FORTIFY_LEVEL - 1, __fmt, \ >> __va_arg_pack ()); >> >> ...... >> In function ‘fprintf’, >> inlined from ‘perf_sample__fprintf_regs.isra’ at \ >> builtin-script.c:622:14: >> /usr/include/aarch64-linux-gnu/bits/stdio2.h:100:10: \ >> error: ‘%5s’ directive argument is null [-Werror=format-overflow=] >> 100 | return __fprintf_chk (__stream, __USE_FORTIFY_LEVEL - 1, __fmt, >> 101 | __va_arg_pack ()); >> >> cc1: all warnings being treated as errors >> ....... >> >> This patch fixes Wformat-overflow warnings by replacing the return >> value NULL of perf_reg_name with "unknown". >> >> Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com> >> --- >> tools/perf/arch/arm64/include/perf_regs.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/perf/arch/arm64/include/perf_regs.h b/tools/perf/arch/arm64/include/perf_regs.h >> index baaa5e64a3fb..901419f907c0 100644 >> --- a/tools/perf/arch/arm64/include/perf_regs.h >> +++ b/tools/perf/arch/arm64/include/perf_regs.h >> @@ -85,10 +85,10 @@ static inline const char *perf_reg_name(int id) >> case PERF_REG_ARM64_PC: >> return "pc"; >> default: >> - return NULL; >> + return "unknown"; >> } >> >> - return NULL; >> + return "unknown"; > > This issue is a common issue crossing all archs. So it's better to > change the code in the places where calls perf_reg_name(), e.g. in > util/session.c: > > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1135,12 +1135,14 @@ static void branch_stack__printf(struct perf_sample *sample, bool callstack) > static void regs_dump__printf(u64 mask, u64 *regs) > { > unsigned rid, i = 0; > + char *reg_name; > > for_each_set_bit(rid, (unsigned long *) &mask, sizeof(mask) * 8) { > u64 val = regs[i++]; > > + reg_name = perf_reg_name(rid); > printf(".... %-5s 0x%016" PRIx64 "\n", > - perf_reg_name(rid), val); > + reg_name ?: "Unknown", val); > } > } > > And another potential issue is the format specifier "%-5s", it prints > out maximum to 5 chars, Doesn't the width field specify the min, not max, number of characters? Cheers, John > but actually string "Unknown" has 7 chars. > Actually the format specifier breaks other archs register names, e.g. > [1][2], seems to me, it's better to change as "%-8s", you might need > to use a dedicated patch for format specifier changes. > > Thanks, > Leo > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/arch/powerpc/include/perf_regs.h#n57 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/arch/csky/include/perf_regs.h#n83 > . >
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com> To: Leo Yan <leo.yan@linaro.org>, Jianlin Lv <Jianlin.Lv@arm.com> Cc: mark.rutland@arm.com, mathieu.poirier@linaro.org, peterz@infradead.org, jolsa@redhat.com, linux-kernel@vger.kernel.org, acme@kernel.org, alexander.shishkin@linux.intel.com, mingo@redhat.com, namhyung@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] perf tools: Fix arm64 build error with gcc-11 Date: Tue, 9 Feb 2021 14:18:26 +0000 [thread overview] Message-ID: <66c8385e-b9fb-4a5b-a55e-e1543ad3d3c3@huawei.com> (raw) In-Reply-To: <20210209121728.GA12546@leoy-ThinkPad-X240s> On 09/02/2021 12:17, Leo Yan wrote: > Hi Jianlin, > > On Tue, Feb 09, 2021 at 07:33:57PM +0800, Jianlin Lv wrote: >> gcc version: 11.0.0 20210208 (experimental) (GCC) >> >> Following build error on arm64: >> >> ....... >> In function ‘printf’, >> inlined from ‘regs_dump__printf’ at util/session.c:1141:3, >> inlined from ‘regs__printf’ at util/session.c:1169:2: >> /usr/include/aarch64-linux-gnu/bits/stdio2.h:107:10: \ >> error: ‘%-5s’ directive argument is null [-Werror=format-overflow=] >> >> 107 | return __printf_chk (__USE_FORTIFY_LEVEL - 1, __fmt, \ >> __va_arg_pack ()); >> >> ...... >> In function ‘fprintf’, >> inlined from ‘perf_sample__fprintf_regs.isra’ at \ >> builtin-script.c:622:14: >> /usr/include/aarch64-linux-gnu/bits/stdio2.h:100:10: \ >> error: ‘%5s’ directive argument is null [-Werror=format-overflow=] >> 100 | return __fprintf_chk (__stream, __USE_FORTIFY_LEVEL - 1, __fmt, >> 101 | __va_arg_pack ()); >> >> cc1: all warnings being treated as errors >> ....... >> >> This patch fixes Wformat-overflow warnings by replacing the return >> value NULL of perf_reg_name with "unknown". >> >> Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com> >> --- >> tools/perf/arch/arm64/include/perf_regs.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/perf/arch/arm64/include/perf_regs.h b/tools/perf/arch/arm64/include/perf_regs.h >> index baaa5e64a3fb..901419f907c0 100644 >> --- a/tools/perf/arch/arm64/include/perf_regs.h >> +++ b/tools/perf/arch/arm64/include/perf_regs.h >> @@ -85,10 +85,10 @@ static inline const char *perf_reg_name(int id) >> case PERF_REG_ARM64_PC: >> return "pc"; >> default: >> - return NULL; >> + return "unknown"; >> } >> >> - return NULL; >> + return "unknown"; > > This issue is a common issue crossing all archs. So it's better to > change the code in the places where calls perf_reg_name(), e.g. in > util/session.c: > > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1135,12 +1135,14 @@ static void branch_stack__printf(struct perf_sample *sample, bool callstack) > static void regs_dump__printf(u64 mask, u64 *regs) > { > unsigned rid, i = 0; > + char *reg_name; > > for_each_set_bit(rid, (unsigned long *) &mask, sizeof(mask) * 8) { > u64 val = regs[i++]; > > + reg_name = perf_reg_name(rid); > printf(".... %-5s 0x%016" PRIx64 "\n", > - perf_reg_name(rid), val); > + reg_name ?: "Unknown", val); > } > } > > And another potential issue is the format specifier "%-5s", it prints > out maximum to 5 chars, Doesn't the width field specify the min, not max, number of characters? Cheers, John > but actually string "Unknown" has 7 chars. > Actually the format specifier breaks other archs register names, e.g. > [1][2], seems to me, it's better to change as "%-8s", you might need > to use a dedicated patch for format specifier changes. > > Thanks, > Leo > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/arch/powerpc/include/perf_regs.h#n57 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/arch/csky/include/perf_regs.h#n83 > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-09 14:20 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-09 11:33 [PATCH] perf tools: Fix arm64 build error with gcc-11 Jianlin Lv 2021-02-09 11:33 ` Jianlin Lv 2021-02-09 12:17 ` Leo Yan 2021-02-09 12:17 ` Leo Yan 2021-02-09 14:18 ` John Garry [this message] 2021-02-09 14:18 ` John Garry 2021-02-09 14:44 ` Leo Yan 2021-02-09 14:44 ` Leo Yan 2021-02-10 2:31 ` Jianlin Lv 2021-02-10 2:31 ` Jianlin Lv
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=66c8385e-b9fb-4a5b-a55e-e1543ad3d3c3@huawei.com \ --to=john.garry@huawei.com \ --cc=Jianlin.Lv@arm.com \ --cc=acme@kernel.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=jolsa@redhat.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.