From: Florian Fainelli <f.fainelli@gmail.com>
To: matthias.bgg@kernel.org, mpm@selenic.com,
herbert@gondor.apana.org.au, rjui@broadcom.com,
sbranden@broadcom.com, f.fainelli@gmail.com
Cc: linux-kernel@vger.kernel.org, Julia.Lawall@inria.fr,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-crypto@vger.kernel.org,
Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block.
Date: Mon, 14 Dec 2020 09:36:37 -0800 [thread overview]
Message-ID: <66f1721d-968e-8b2c-386d-cfe97910fe3b@gmail.com> (raw)
In-Reply-To: <20201214160454.22769-1-matthias.bgg@kernel.org>
On 12/14/20 8:04 AM, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> When trying to disable the block we bitwise or the control
> register with value zero. This will leave the block always turned on.
> Fix this by setting the corresponding bit to zero.
>
> Fixes: c83d45d5685f ("hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver")
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: matthias.bgg@kernel.org, mpm@selenic.com,
herbert@gondor.apana.org.au, rjui@broadcom.com,
sbranden@broadcom.com, f.fainelli@gmail.com
Cc: Matthias Brugger <mbrugger@suse.com>,
linux-kernel@vger.kernel.org, Julia.Lawall@inria.fr,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block.
Date: Mon, 14 Dec 2020 09:36:37 -0800 [thread overview]
Message-ID: <66f1721d-968e-8b2c-386d-cfe97910fe3b@gmail.com> (raw)
In-Reply-To: <20201214160454.22769-1-matthias.bgg@kernel.org>
On 12/14/20 8:04 AM, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> When trying to disable the block we bitwise or the control
> register with value zero. This will leave the block always turned on.
> Fix this by setting the corresponding bit to zero.
>
> Fixes: c83d45d5685f ("hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver")
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-14 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 16:04 [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block matthias.bgg
2020-12-14 16:04 ` matthias.bgg
2020-12-14 16:04 ` [PATCH 2/2] hwrng: iproc-rng200: Move enable/disable in separate function matthias.bgg
2020-12-14 16:04 ` matthias.bgg
2020-12-14 17:39 ` Florian Fainelli
2020-12-14 17:39 ` Florian Fainelli
2020-12-14 17:50 ` Scott Branden
2020-12-14 17:50 ` Scott Branden
2020-12-14 17:36 ` Florian Fainelli [this message]
2020-12-14 17:36 ` [PATCH 1/2] hwrng: iproc-rng200: Fix disable of the block Florian Fainelli
2020-12-14 17:45 ` Scott Branden
2020-12-14 17:45 ` Scott Branden
2020-12-18 10:49 ` Matthias Brugger
2020-12-18 10:49 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66f1721d-968e-8b2c-386d-cfe97910fe3b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Julia.Lawall@inria.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@kernel.org \
--cc=mbrugger@suse.com \
--cc=mpm@selenic.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.