* [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA
@ 2017-07-31 21:10 Arnd Bergmann
2017-08-01 21:17 ` Gary R Hook
2017-08-09 13:57 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-07-31 21:10 UTC (permalink / raw)
To: Tom Lendacky, Gary Hook, Herbert Xu, David S. Miller
Cc: Arnd Bergmann, Brijesh Singh, linux-crypto, linux-kernel
Without the base RSA code, we run into a link error:
ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
Like the other drivers implementing RSA in hardware, this
can be avoided by always enabling the base support when we build
CCP.
Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/ccp/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
index 15b63fd3d180..6d626606b9c5 100644
--- a/drivers/crypto/ccp/Kconfig
+++ b/drivers/crypto/ccp/Kconfig
@@ -27,6 +27,7 @@ config CRYPTO_DEV_CCP_CRYPTO
select CRYPTO_HASH
select CRYPTO_BLKCIPHER
select CRYPTO_AUTHENC
+ select CRYPTO_RSA
help
Support for using the cryptographic API with the AMD Cryptographic
Coprocessor. This module supports offload of SHA and AES algorithms.
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA
2017-07-31 21:10 [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA Arnd Bergmann
@ 2017-08-01 21:17 ` Gary R Hook
2017-08-09 13:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Gary R Hook @ 2017-08-01 21:17 UTC (permalink / raw)
To: Arnd Bergmann, Lendacky, Thomas, Herbert Xu, David S. Miller
Cc: Singh, Brijesh, linux-crypto, linux-kernel
On 07/31/2017 04:10 PM, Arnd Bergmann wrote:
> Without the base RSA code, we run into a link error:
>
> ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
> ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
>
> Like the other drivers implementing RSA in hardware, this
> can be avoided by always enabling the base support when we build
> CCP.
>
> Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/crypto/ccp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
> index 15b63fd3d180..6d626606b9c5 100644
> --- a/drivers/crypto/ccp/Kconfig
> +++ b/drivers/crypto/ccp/Kconfig
> @@ -27,6 +27,7 @@ config CRYPTO_DEV_CCP_CRYPTO
> select CRYPTO_HASH
> select CRYPTO_BLKCIPHER
> select CRYPTO_AUTHENC
> + select CRYPTO_RSA
> help
> Support for using the cryptographic API with the AMD Cryptographic
> Coprocessor. This module supports offload of SHA and AES algorithms.
>
Reviewed by: Gary R Hook <gary.hook@amd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA
2017-07-31 21:10 [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA Arnd Bergmann
2017-08-01 21:17 ` Gary R Hook
@ 2017-08-09 13:57 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2017-08-09 13:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Tom Lendacky, Gary Hook, David S. Miller, Brijesh Singh,
linux-crypto, linux-kernel
On Mon, Jul 31, 2017 at 11:10:57PM +0200, Arnd Bergmann wrote:
> Without the base RSA code, we run into a link error:
>
> ERROR: "rsa_parse_pub_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
> ERROR: "rsa_parse_priv_key" [drivers/crypto/ccp/ccp-crypto.ko] undefined!
>
> Like the other drivers implementing RSA in hardware, this
> can be avoided by always enabling the base support when we build
> CCP.
>
> Fixes: ceeec0afd684 ("crypto: ccp - Add support for RSA on the CCP")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-09 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31 21:10 [PATCH] crypto: ccp - select CONFIG_CRYPTO_RSA Arnd Bergmann
2017-08-01 21:17 ` Gary R Hook
2017-08-09 13:57 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.