[PATCH 1/2 v5] Configure script for Haiku

[PATCH 1/2 v5] Configure script for Haiku

[Richard Zak]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Signed-off-by: Richard Zak <richard.j.zak@gmail.com>
---
 configure | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 232c54dcc1..163af793e9 100755
--- a/configure
+++ b/configure
@@ -768,7 +768,8 @@ SunOS)
 ;;
 Haiku)
   haiku="yes"
-  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE $QEMU_CFLAGS"
+  pie="no"
+  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE -fPIC
$QEMU_CFLAGS"
 ;;
 Linux)
   audio_drv_list="try-pa oss"
-- 
2.25.1

v5: Proper formatting for patch (sorry)
v4:
This refers to the email from a few weeks ago, regarding TPM & Haiku. It
seems the assertion failure isn't really about the TPM, but about disabling
PIE and adding -fPIC. There's discussion on the Haiku forum[1] about the
incompatibility with PIE, and this fixes the assertion failure without
altering the TPM configuration variable.
[1] https://discuss.haiku-os.org/t/qemu-on-haiku-sdl-issue/10961/6?u=rjzak

Previously, the TPM option was causing an assertion error at
util/async.c:669 qemu_set_current_aio_context() !my_aiocontext. I suspect
it was because the TPM option may have implied PIE. This patch ensures PIE
doesn't get used, but -fPIC is used instead.



-- 
Regards,

Richard J. Zak
Professional Genius
PGP Key: https://keybase.io/rjzak/key.asc

[-- Attachment #2: Type: text/html, Size: 2019 bytes --]

Re: [PATCH 1/2 v5] Configure script for Haiku

[Thomas Huth]

On 21/07/2021 03.40, Richard Zak wrote:
> Signed-off-by: Richard Zak <richard.j.zak@gmail.com 
> <mailto:richard.j.zak@gmail.com>>
> ---
>   configure | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 232c54dcc1..163af793e9 100755
> --- a/configure
> +++ b/configure
> @@ -768,7 +768,8 @@ SunOS)
>   ;;
>   Haiku)
>     haiku="yes"
> -  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE $QEMU_CFLAGS"
> +  pie="no"
> +  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE -fPIC $QEMU_CFLAGS"
>   ;;
>   Linux)
>     audio_drv_list="try-pa oss"

Thanks, I've slightly updated the title and patch description and  queued it 
now to my branch here:

https://gitlab.com/thuth/qemu/-/commits/testing-next/

  Thomas