* [Buildroot] [PATCH v3 1/2] librtas: new package
2015-05-19 5:59 [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas Sam Bobroff
@ 2015-05-19 5:59 ` Sam Bobroff
2015-07-13 15:32 ` Romain Naour
2015-07-13 16:37 ` Thomas Petazzoni
2015-05-19 5:59 ` [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas Sam Bobroff
2015-06-01 4:05 ` [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas Sam Bobroff
2 siblings, 2 replies; 11+ messages in thread
From: Sam Bobroff @ 2015-05-19 5:59 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
---
v2:
Remove redundant INSTALL_TARGET=yes.
Add patch description and patch signed-off-by.
Rename patch with correct prefix (0001-).
package/Config.in | 1 +
...0001-librtas-install-librtas.so.1-symlink.patch | 31 ++++++++++++++++++++
package/librtas/Config.in | 9 ++++++
package/librtas/librtas.mk | 26 ++++++++++++++++
4 files changed, 67 insertions(+)
create mode 100644 package/librtas/0001-librtas-install-librtas.so.1-symlink.patch
create mode 100644 package/librtas/Config.in
create mode 100644 package/librtas/librtas.mk
diff --git a/package/Config.in b/package/Config.in
index af4d2b7..51de1c0 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -832,6 +832,7 @@ menu "Hardware handling"
source "package/libphidget/Config.in"
source "package/libqmi/Config.in"
source "package/libraw1394/Config.in"
+ source "package/librtas/Config.in"
source "package/librtlsdr/Config.in"
source "package/libserial/Config.in"
source "package/libserialport/Config.in"
diff --git a/package/librtas/0001-librtas-install-librtas.so.1-symlink.patch b/package/librtas/0001-librtas-install-librtas.so.1-symlink.patch
new file mode 100644
index 0000000..2150c3f
--- /dev/null
+++ b/package/librtas/0001-librtas-install-librtas.so.1-symlink.patch
@@ -0,0 +1,31 @@
+Add a line to the librtas Makefile to create librtas.so.1 when
+performing "make install".
+
+Without this patch programs linked with librtas will fail at run time:
+
+error while loading shared libraries: librtas.so.1: cannot open shared
+object file: No such file or directory
+
+A patch has been submitted upstream so it is likely that this patch
+can be dropped after the next release of librtas.
+
+Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
+---
+ librtas_src/Makefile | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/librtas_src/Makefile b/librtas_src/Makefile
+index 3a10222..deba29d 100644
+--- a/librtas_src/Makefile
++++ b/librtas_src/Makefile
+@@ -33,6 +33,7 @@ install:
+ @$(call install_lib,$(LIBRTAS),$(DESTDIR))
+ @$(call install_inc,$(HEADERS),$(DESTDIR))
+ @ln -sf $(LIBRTAS) $(DESTDIR)/$(LIB_DIR)$(call is_lib64,$(LIBRTAS))/$(LIBRTAS_SONAME)
++ @ln -sf $(LIBRTAS) $(DESTDIR)/$(LIB_DIR)$(call is_lib64,$(LIBRTAS))/$(LIBRTAS_SONAME).1
+
+ uninstall:
+ @$(call uninstall_lib,$(LIBRTAS),$(DESTDIR))
+--
+1.7.10.4
+
diff --git a/package/librtas/Config.in b/package/librtas/Config.in
new file mode 100644
index 0000000..bf0a705
--- /dev/null
+++ b/package/librtas/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBRTAS
+ bool "librtas"
+ depends on BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
+ help
+ The librtas package provides an interface for Run-Time Abstraction
+ Services (RTAS) calls on PAPR platforms. The libraries allow users to
+ examine and manipulate hardware, and parse RTAS events.
+
+ http://librtas.sourceforge.net/
diff --git a/package/librtas/librtas.mk b/package/librtas/librtas.mk
new file mode 100644
index 0000000..b081a91
--- /dev/null
+++ b/package/librtas/librtas.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# librtas
+#
+################################################################################
+
+LIBRTAS_VERSION = 1.3.13
+LIBRTAS_SITE = http://downloads.sourceforge.net/project/librtas
+LIBRTAS_LICENSE = Common Public License Version 1.0
+LIBRTAS_LICENSE_FILES = COPYRIGHT
+LIBRTAS_INSTALL_STAGING = YES
+
+define LIBRTAS_BUILD_CMDS
+ $(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
+endef
+
+define LIBRTAS_INSTALL_STAGING_CMDS
+ $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
+endef
+
+define LIBRTAS_INSTALL_TARGET_CMDS
+ $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
+endef
+
+
+$(eval $(generic-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 1/2] librtas: new package
2015-05-19 5:59 ` [Buildroot] [PATCH v3 1/2] librtas: new package Sam Bobroff
@ 2015-07-13 15:32 ` Romain Naour
2015-07-13 15:38 ` Romain Naour
2015-07-13 16:37 ` Thomas Petazzoni
1 sibling, 1 reply; 11+ messages in thread
From: Romain Naour @ 2015-07-13 15:32 UTC (permalink / raw)
To: buildroot
Hi Sam,
Le 19/05/2015 07:59, Sam Bobroff a ?crit :
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
> v2:
>
> Remove redundant INSTALL_TARGET=yes.
> Add patch description and patch signed-off-by.
> Rename patch with correct prefix (0001-).
>
> package/Config.in | 1 +
> ...0001-librtas-install-librtas.so.1-symlink.patch | 31 ++++++++++++++++++++
> package/librtas/Config.in | 9 ++++++
> package/librtas/librtas.mk | 26 ++++++++++++++++
> 4 files changed, 67 insertions(+)
> create mode 100644 package/librtas/0001-librtas-install-librtas.so.1-symlink.patch
> create mode 100644 package/librtas/Config.in
> create mode 100644 package/librtas/librtas.mk
>
[snip]
> diff --git a/package/librtas/Config.in b/package/librtas/Config.in
> new file mode 100644
> index 0000000..bf0a705
> --- /dev/null
> +++ b/package/librtas/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_LIBRTAS
> + bool "librtas"
> + depends on BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
Have you tested this package with uClibc-ng or musl ?
I tried to build with an experimental musl 1.1.6 based toolchain but it won't
build (lot of build errors).
Then I tried to build with a uClibc-ng powerpc toolchain used in autobuilder [1]
and powerpc-utils fail to build when librtas support is enabled.
src/drmgr/common.c:17:22: fatal error: execinfo.h No such file or directory.
But it build fine with a glibc based toolchain (build tested with the CS powerpc
2011.03 toolchain). For now, it's ok if librtas can be available on glibc
toolchains.
Also, the package should depends on !BR2_STATIC_LIBS since librtas build
unconditionally a shared library.
Otherwise, you patch looks ok.
Best regards,
Romain Naour
[1] http://autobuild.buildroot.net/toolchains/configs/br-powerpc-e500mc-full.config
> + help
> + The librtas package provides an interface for Run-Time Abstraction
> + Services (RTAS) calls on PAPR platforms. The libraries allow users to
> + examine and manipulate hardware, and parse RTAS events.
> +
> + http://librtas.sourceforge.net/
> diff --git a/package/librtas/librtas.mk b/package/librtas/librtas.mk
> new file mode 100644
> index 0000000..b081a91
> --- /dev/null
> +++ b/package/librtas/librtas.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# librtas
> +#
> +################################################################################
> +
> +LIBRTAS_VERSION = 1.3.13
> +LIBRTAS_SITE = http://downloads.sourceforge.net/project/librtas
> +LIBRTAS_LICENSE = Common Public License Version 1.0
> +LIBRTAS_LICENSE_FILES = COPYRIGHT
> +LIBRTAS_INSTALL_STAGING = YES
> +
> +define LIBRTAS_BUILD_CMDS
> + $(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
> +endef
> +
> +define LIBRTAS_INSTALL_STAGING_CMDS
> + $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
> +endef
> +
> +define LIBRTAS_INSTALL_TARGET_CMDS
> + $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> +endef
> +
> +
> +$(eval $(generic-package))
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 1/2] librtas: new package
2015-07-13 15:32 ` Romain Naour
@ 2015-07-13 15:38 ` Romain Naour
0 siblings, 0 replies; 11+ messages in thread
From: Romain Naour @ 2015-07-13 15:38 UTC (permalink / raw)
To: buildroot
Hi Sam,
Le 13/07/2015 17:32, Romain Naour a ?crit :
> Hi Sam,
>
> Le 19/05/2015 07:59, Sam Bobroff a ?crit :
>> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
>> ---
>> v2:
>>
>> Remove redundant INSTALL_TARGET=yes.
>> Add patch description and patch signed-off-by.
>> Rename patch with correct prefix (0001-).
>>
>> package/Config.in | 1 +
>> ...0001-librtas-install-librtas.so.1-symlink.patch | 31 ++++++++++++++++++++
>> package/librtas/Config.in | 9 ++++++
>> package/librtas/librtas.mk | 26 ++++++++++++++++
>> 4 files changed, 67 insertions(+)
>> create mode 100644 package/librtas/0001-librtas-install-librtas.so.1-symlink.patch
>> create mode 100644 package/librtas/Config.in
>> create mode 100644 package/librtas/librtas.mk
>>
>
> [snip]
>
>> diff --git a/package/librtas/Config.in b/package/librtas/Config.in
>> new file mode 100644
>> index 0000000..bf0a705
>> --- /dev/null
>> +++ b/package/librtas/Config.in
>> @@ -0,0 +1,9 @@
>> +config BR2_PACKAGE_LIBRTAS
>> + bool "librtas"
>> + depends on BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
>
> Have you tested this package with uClibc-ng or musl ?
>
> I tried to build with an experimental musl 1.1.6 based toolchain but it won't
> build (lot of build errors).
>
> Then I tried to build with a uClibc-ng powerpc toolchain used in autobuilder [1]
> and powerpc-utils fail to build when librtas support is enabled.
>
> src/drmgr/common.c:17:22: fatal error: execinfo.h No such file or directory.
>
> But it build fine with a glibc based toolchain (build tested with the CS powerpc
> 2011.03 toolchain). For now, it's ok if librtas can be available on glibc
> toolchains.
>
> Also, the package should depends on !BR2_STATIC_LIBS since librtas build
> unconditionally a shared library.
>
> Otherwise, you patch looks ok.
>
> Best regards,
> Romain Naour
>
> [1] http://autobuild.buildroot.net/toolchains/configs/br-powerpc-e500mc-full.config
>
>> + help
>> + The librtas package provides an interface for Run-Time Abstraction
>> + Services (RTAS) calls on PAPR platforms. The libraries allow users to
>> + examine and manipulate hardware, and parse RTAS events.
>> +
>> + http://librtas.sourceforge.net/
>> diff --git a/package/librtas/librtas.mk b/package/librtas/librtas.mk
>> new file mode 100644
>> index 0000000..b081a91
>> --- /dev/null
>> +++ b/package/librtas/librtas.mk
>> @@ -0,0 +1,26 @@
>> +################################################################################
>> +#
>> +# librtas
>> +#
>> +################################################################################
>> +
>> +LIBRTAS_VERSION = 1.3.13
>> +LIBRTAS_SITE = http://downloads.sourceforge.net/project/librtas
>> +LIBRTAS_LICENSE = Common Public License Version 1.0
>> +LIBRTAS_LICENSE_FILES = COPYRIGHT
>> +LIBRTAS_INSTALL_STAGING = YES
>> +
>> +define LIBRTAS_BUILD_CMDS
>> + $(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
>> +endef
>> +
>> +define LIBRTAS_INSTALL_STAGING_CMDS
>> + $(MAKE) -C $(@D) DESTDIR=$(STAGING_DIR) install
>> +endef
>> +
>> +define LIBRTAS_INSTALL_TARGET_CMDS
>> + $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
>> +endef
>> +
>> +
Extra new line.
Otherwise, with my previous comment taken into account:
Reviewed-by: Romain Naour <romain.naour@openwide.fr>
Best regards,
Romain Naour
>> +$(eval $(generic-package))
>>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 1/2] librtas: new package
2015-05-19 5:59 ` [Buildroot] [PATCH v3 1/2] librtas: new package Sam Bobroff
2015-07-13 15:32 ` Romain Naour
@ 2015-07-13 16:37 ` Thomas Petazzoni
1 sibling, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2015-07-13 16:37 UTC (permalink / raw)
To: buildroot
Dear Sam Bobroff,
On Tue, 19 May 2015 15:59:55 +1000, Sam Bobroff wrote:
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
> v2:
Applied after the following changes:
[Thomas:
- make the package depend on glibc, since it needs execinfo.h
- use TARGET_CONFIGURE_OPTS instead of defining manually CC and LD
- add hash file
- remove useless empty newline.
Thanks to Romain Naour for the review!]
Thanks for the contribution!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas
2015-05-19 5:59 [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas Sam Bobroff
2015-05-19 5:59 ` [Buildroot] [PATCH v3 1/2] librtas: new package Sam Bobroff
@ 2015-05-19 5:59 ` Sam Bobroff
2015-07-13 15:44 ` Romain Naour
2015-07-13 16:44 ` Thomas Petazzoni
2015-06-01 4:05 ` [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas Sam Bobroff
2 siblings, 2 replies; 11+ messages in thread
From: Sam Bobroff @ 2015-05-19 5:59 UTC (permalink / raw)
To: buildroot
Now that librtas is available, optionally use it with powerpc-utils to
enable it's RTAS dependant functionality. It is used by default, as
most distros do, but made optional because it adds several new programs
and significantly increases the size of the installed package.
Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
---
v3:
Group "with" and "without" clauses.
v2:
Make librtas support in powerpc-utils optional due to size concerns.
package/powerpc-utils/Config.in | 18 ++++++++++++++++++
package/powerpc-utils/powerpc-utils.mk | 8 +++++++-
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/package/powerpc-utils/Config.in b/package/powerpc-utils/Config.in
index eded41e..8b3e3d1 100644
--- a/package/powerpc-utils/Config.in
+++ b/package/powerpc-utils/Config.in
@@ -6,3 +6,21 @@ config BR2_PACKAGE_POWERPC_UTILS
System utilities for PowerPC machines.
http://sourceforge.net/projects/powerpc-utils/
+
+if BR2_PACKAGE_POWERPC_UTILS
+
+config BR2_PACKAGE_POWERPC_UTILS_RTAS
+ bool "RTAS support"
+ select BR2_PACKAGE_LIBRTAS
+ default y
+ help
+ Enable support for functions that require RTAS.
+
+ This adds a dependency on librtas and provides the following
+ additional features at the cost of increasing the installed package
+ size from about 0.5MB to about 2MB:
+ ppc64_cpu --run-mode, uesensor, set_poweron_time, drmgr, lsslot,
+ activate_firmware, rtas_ibm_get_vpd, serv_config,
+ rtas_event_decode, sys_ident.
+
+endif
diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk
index 3b30458..ae4d662 100644
--- a/package/powerpc-utils/powerpc-utils.mk
+++ b/package/powerpc-utils/powerpc-utils.mk
@@ -10,8 +10,14 @@ POWERPC_UTILS_DEPENDENCIES = zlib
POWERPC_UTILS_LICENSE = Common Public License Version 1.0
POWERPC_UTILS_LICENSE_FILES = COPYRIGHT
-POWERPC_UTILS_CONF_OPTS = --without-librtas
POWERPC_UTILS_CONF_ENV = \
ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
+ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y)
+POWERPC_UTILS_DEPENDENCIES += librtas
+POWERPC_UTILS_CONF_OPTS = --with-librtas
+else
+POWERPC_UTILS_CONF_OPTS = --without-librtas
+endif
+
$(eval $(autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas
2015-05-19 5:59 ` [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas Sam Bobroff
@ 2015-07-13 15:44 ` Romain Naour
2015-07-13 16:44 ` Thomas Petazzoni
1 sibling, 0 replies; 11+ messages in thread
From: Romain Naour @ 2015-07-13 15:44 UTC (permalink / raw)
To: buildroot
Le 19/05/2015 07:59, Sam Bobroff a ?crit :
> Now that librtas is available, optionally use it with powerpc-utils to
> enable it's RTAS dependant functionality. It is used by default, as
> most distros do, but made optional because it adds several new programs
> and significantly increases the size of the installed package.
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
> v3:
>
> Group "with" and "without" clauses.
>
> v2:
>
> Make librtas support in powerpc-utils optional due to size concerns.
>
> package/powerpc-utils/Config.in | 18 ++++++++++++++++++
> package/powerpc-utils/powerpc-utils.mk | 8 +++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/package/powerpc-utils/Config.in b/package/powerpc-utils/Config.in
> index eded41e..8b3e3d1 100644
> --- a/package/powerpc-utils/Config.in
> +++ b/package/powerpc-utils/Config.in
> @@ -6,3 +6,21 @@ config BR2_PACKAGE_POWERPC_UTILS
> System utilities for PowerPC machines.
>
> http://sourceforge.net/projects/powerpc-utils/
> +
> +if BR2_PACKAGE_POWERPC_UTILS
> +
> +config BR2_PACKAGE_POWERPC_UTILS_RTAS
> + bool "RTAS support"
> + select BR2_PACKAGE_LIBRTAS
The librtas reverse dependencies should be added here (glibc toolchain only and
!static build)
Reviewed-by: Romain Naour <romain.naour@openwide.fr>
Best regards,
Romain Naour
> + default y
> + help
> + Enable support for functions that require RTAS.
> +
> + This adds a dependency on librtas and provides the following
> + additional features at the cost of increasing the installed package
> + size from about 0.5MB to about 2MB:
> + ppc64_cpu --run-mode, uesensor, set_poweron_time, drmgr, lsslot,
> + activate_firmware, rtas_ibm_get_vpd, serv_config,
> + rtas_event_decode, sys_ident.
> +
> +endif
> diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk
> index 3b30458..ae4d662 100644
> --- a/package/powerpc-utils/powerpc-utils.mk
> +++ b/package/powerpc-utils/powerpc-utils.mk
> @@ -10,8 +10,14 @@ POWERPC_UTILS_DEPENDENCIES = zlib
> POWERPC_UTILS_LICENSE = Common Public License Version 1.0
> POWERPC_UTILS_LICENSE_FILES = COPYRIGHT
>
> -POWERPC_UTILS_CONF_OPTS = --without-librtas
> POWERPC_UTILS_CONF_ENV = \
> ax_cv_check_cflags___fstack_protector_all=$(if $(BR2_TOOLCHAIN_HAS_SSP),yes,no)
>
> +ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y)
> +POWERPC_UTILS_DEPENDENCIES += librtas
> +POWERPC_UTILS_CONF_OPTS = --with-librtas
> +else
> +POWERPC_UTILS_CONF_OPTS = --without-librtas
> +endif
> +
> $(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas
2015-05-19 5:59 ` [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas Sam Bobroff
2015-07-13 15:44 ` Romain Naour
@ 2015-07-13 16:44 ` Thomas Petazzoni
2015-07-20 3:31 ` Sam Bobroff
1 sibling, 1 reply; 11+ messages in thread
From: Thomas Petazzoni @ 2015-07-13 16:44 UTC (permalink / raw)
To: buildroot
Dear Sam Bobroff,
On Tue, 19 May 2015 15:59:56 +1000, Sam Bobroff wrote:
> Now that librtas is available, optionally use it with powerpc-utils to
> enable it's RTAS dependant functionality. It is used by default, as
> most distros do, but made optional because it adds several new programs
> and significantly increases the size of the installed package.
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
> v3:
Applied after propagating the glibc dependency of librtas, as noted by
Romain Naour.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas
2015-07-13 16:44 ` Thomas Petazzoni
@ 2015-07-20 3:31 ` Sam Bobroff
0 siblings, 0 replies; 11+ messages in thread
From: Sam Bobroff @ 2015-07-20 3:31 UTC (permalink / raw)
To: buildroot
On Mon, Jul 13, 2015 at 06:44:18PM +0200, Thomas Petazzoni wrote:
> Dear Sam Bobroff,
>
> On Tue, 19 May 2015 15:59:56 +1000, Sam Bobroff wrote:
> > Now that librtas is available, optionally use it with powerpc-utils to
> > enable it's RTAS dependant functionality. It is used by default, as
> > most distros do, but made optional because it adds several new programs
> > and significantly increases the size of the installed package.
> >
> > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> > ---
> > v3:
>
> Applied after propagating the glibc dependency of librtas, as noted by
> Romain Naour.
>
> Thanks!
>
> Thomas
Baruch, Romain and Thomas,
Thanks for the reviews and improvements!
Cheers,
Sam.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas
2015-05-19 5:59 [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas Sam Bobroff
2015-05-19 5:59 ` [Buildroot] [PATCH v3 1/2] librtas: new package Sam Bobroff
2015-05-19 5:59 ` [Buildroot] [PATCH v3 2/2] powerpc-utils: optionally use librtas Sam Bobroff
@ 2015-06-01 4:05 ` Sam Bobroff
2015-06-01 4:18 ` Baruch Siach
2 siblings, 1 reply; 11+ messages in thread
From: Sam Bobroff @ 2015-06-01 4:05 UTC (permalink / raw)
To: buildroot
Hi Baruch,
Thanks again for the reviews. I think I've addressed all of the issues. Is
there anything else I need to do?
Sam.
On Tue, May 19, 2015 at 03:59:54PM +1000, Sam Bobroff wrote:
>
> Many useful functions are missing from powerpc-utils when built by
> buildroot, because they depend on librtas which is not included.
>
> This set adds the librtas package, a small patch to fix a problem with
> it's make install target, and tweaks the powerpc-utils config
> to include it. This makes the following additional programs available
> from powerpc-utils:
>
> * uesensor
> * set_poweron_time
> * drmgr
> * lsslot
> * activate_firmware
> * rtas_ibm_get_vpd
> * serv_config
> * rtas_event_decode
> * sys_ident
>
>
> Changes v2 -> v3:
> Patch 2/2: powerpc-utils: optionally use librtas
>
> Group "with" and "without" clauses.
>
>
> Changes v1 -> v2:
> Patch 1/2: librtas: new package
>
> Remove redundant INSTALL_TARGET=yes.
> Add patch description and patch signed-off-by.
> Rename patch with correct prefix (0001-).
>
> Patch 2/2: powerpc-utils: optionally use librtas
>
> Make librtas support in powerpc-utils optional due to size concerns.
>
>
> Sam Bobroff (2):
> librtas: new package
> powerpc-utils: optionally use librtas
>
> package/Config.in | 1 +
> ...0001-librtas-install-librtas.so.1-symlink.patch | 31 ++++++++++++++++++++
> package/librtas/Config.in | 9 ++++++
> package/librtas/librtas.mk | 26 ++++++++++++++++
> package/powerpc-utils/Config.in | 18 ++++++++++++
> package/powerpc-utils/powerpc-utils.mk | 8 ++++-
> 6 files changed, 92 insertions(+), 1 deletion(-)
> create mode 100644 package/librtas/0001-librtas-install-librtas.so.1-symlink.patch
> create mode 100644 package/librtas/Config.in
> create mode 100644 package/librtas/librtas.mk
>
> --
> 1.7.10.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas
2015-06-01 4:05 ` [Buildroot] [PATCH v3 0/2] Improve powerpc-utils with librtas Sam Bobroff
@ 2015-06-01 4:18 ` Baruch Siach
0 siblings, 0 replies; 11+ messages in thread
From: Baruch Siach @ 2015-06-01 4:18 UTC (permalink / raw)
To: buildroot
Hi Sam,
On Mon, Jun 01, 2015 at 02:05:29PM +1000, Sam Bobroff wrote:
> Thanks again for the reviews. I think I've addressed all of the issues. Is
> there anything else I need to do?
Just wait for the maintainers to review/apply your patches. The backlog of
patches is visible at http://patchwork.ozlabs.org/project/buildroot/list/, and
as you can see it is quite long. You may help shortening this list by
reviewing other patches from that list. As the list shortens your contribution
will be considered sooner.
baruch
> On Tue, May 19, 2015 at 03:59:54PM +1000, Sam Bobroff wrote:
> > Many useful functions are missing from powerpc-utils when built by
> > buildroot, because they depend on librtas which is not included.
> >
> > This set adds the librtas package, a small patch to fix a problem with
> > it's make install target, and tweaks the powerpc-utils config
> > to include it. This makes the following additional programs available
> > from powerpc-utils:
> >
> > * uesensor
> > * set_poweron_time
> > * drmgr
> > * lsslot
> > * activate_firmware
> > * rtas_ibm_get_vpd
> > * serv_config
> > * rtas_event_decode
> > * sys_ident
> >
> > Changes v2 -> v3:
> > Patch 2/2: powerpc-utils: optionally use librtas
> >
> > Group "with" and "without" clauses.
> >
> > Changes v1 -> v2:
> > Patch 1/2: librtas: new package
> >
> > Remove redundant INSTALL_TARGET=yes.
> > Add patch description and patch signed-off-by.
> > Rename patch with correct prefix (0001-).
> >
> > Patch 2/2: powerpc-utils: optionally use librtas
> >
> > Make librtas support in powerpc-utils optional due to size concerns.
> >
> > Sam Bobroff (2):
> > librtas: new package
> > powerpc-utils: optionally use librtas
> >
> > package/Config.in | 1 +
> > ...0001-librtas-install-librtas.so.1-symlink.patch | 31 ++++++++++++++++++++
> > package/librtas/Config.in | 9 ++++++
> > package/librtas/librtas.mk | 26 ++++++++++++++++
> > package/powerpc-utils/Config.in | 18 ++++++++++++
> > package/powerpc-utils/powerpc-utils.mk | 8 ++++-
> > 6 files changed, 92 insertions(+), 1 deletion(-)
> > create mode 100644 package/librtas/0001-librtas-install-librtas.so.1-symlink.patch
> > create mode 100644 package/librtas/Config.in
> > create mode 100644 package/librtas/librtas.mk
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 11+ messages in thread