* [PATCH] net/ixgbe: fix RSS flow return error
@ 2018-10-23 3:38 Wei Zhao
2018-10-23 6:19 ` Peng, Yuan
2018-10-23 20:36 ` Zhang, Qi Z
0 siblings, 2 replies; 4+ messages in thread
From: Wei Zhao @ 2018-10-23 3:38 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, stable, yuan.peng, Wei Zhao
If hash function is 0, it should disable RSS then return 0.
Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index ae21f04..ad9c46d 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -5703,7 +5703,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,
*/
if ((rss_conf.rss_hf & IXGBE_RSS_OFFLOAD_ALL) == 0) {
ixgbe_rss_disable(dev);
- return -EINVAL;
+ return 0;
}
if (rss_conf.rss_key == NULL)
rss_conf.rss_key = rss_intel_key; /* Default hash key */
--
2.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net/ixgbe: fix RSS flow return error
2018-10-23 3:38 [PATCH] net/ixgbe: fix RSS flow return error Wei Zhao
@ 2018-10-23 6:19 ` Peng, Yuan
2018-10-23 20:36 ` Zhang, Qi Z
1 sibling, 0 replies; 4+ messages in thread
From: Peng, Yuan @ 2018-10-23 6:19 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Zhang, Qi Z, stable, Peng, Yuan
Tested-by: Peng, Yuan <yuan.peng@intel.com>
- Tested Branch: master
- Tested Commit: 739e13bcc98f562d3301f808ec76507ebae82e63
- OS: 4.5.5-300.fc24.x86_64
- GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection [8086:10fb] (rev 01)
Intel Corporation Ethernet Controller X710 for 10GbE SFP+ [8086:1572] (rev 01)
- Default x86_64-native-linuxapp-gcc configuration
- Prerequisites:
- Total 1 cases, 1 passed, 0 failed
- Case:
./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1
1. Start the testpmd::
./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained
testpmd> set fwd rxonly
testpmd> set verbose 1
testpmd> start
2. Show port default RSS fuctions::
testpmd> show port 0 rss-hash
RSS functions:
ipv4-frag ipv4-other ipv6-frag ipv6-other ip
Send the ipv4-other packets with different src/dst ip address.
All the packets are distributed to all the four queues.
3. disable all RSS fuctions::
testpmd> flow create 0 ingress pattern end actions rss types none end / end
Flow rule #0 created
testpmd> show port 0 rss-hash
RSS disabled
Send the ipv4-udp packets with different src/dst ip address.
All the packets are distributed to queue 0.
Notes: only i40e support the command,
others don't support the command created.
4. enable RSS fuction with all RSS hash type::
testpmd> flow create 0 ingress pattern end actions rss types all end / end
Flow rule #1 created
testpmd> show port 0 rss-hash
RSS functions:
all ipv4-frag ipv4-tcp ipv4-udp ipv4-sctp ipv4-other ipv6-frag ipv6-tcp ipv6-udp ipv6-sctp ipv6-other l2-payload ip udp tcp sctp
Send the ipv4-udp packets with different src/dst ip address.
All the packets are distributed to all the four queues.
-----Original Message-----
From: Zhao1, Wei
Sent: Tuesday, October 23, 2018 11:38 AM
To: dev@dpdk.org
Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Peng, Yuan <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
Subject: [PATCH] net/ixgbe: fix RSS flow return error
If hash function is 0, it should disable RSS then return 0.
Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index ae21f04..ad9c46d 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -5703,7 +5703,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,
*/
if ((rss_conf.rss_hf & IXGBE_RSS_OFFLOAD_ALL) == 0) {
ixgbe_rss_disable(dev);
- return -EINVAL;
+ return 0;
}
if (rss_conf.rss_key == NULL)
rss_conf.rss_key = rss_intel_key; /* Default hash key */
--
2.7.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/ixgbe: fix RSS flow return error
2018-10-23 3:38 [PATCH] net/ixgbe: fix RSS flow return error Wei Zhao
2018-10-23 6:19 ` Peng, Yuan
@ 2018-10-23 20:36 ` Zhang, Qi Z
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2018-10-23 20:36 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Peng, Yuan
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, October 22, 2018 10:38 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Peng, Yuan
> <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/ixgbe: fix RSS flow return error
>
> If hash function is 0, it should disable RSS then return 0.
>
> Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] net/ixgbe: fix RSS flow return error
@ 2018-10-23 3:32 Wei Zhao
0 siblings, 0 replies; 4+ messages in thread
From: Wei Zhao @ 2018-10-23 3:32 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, stable, Zhao Wei
From: Zhao Wei <wei.zhao1@intel.com>
If hash function is 0, it should disable RSS then return 0.
Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index ae21f04..ad9c46d 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -5703,7 +5703,7 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,
*/
if ((rss_conf.rss_hf & IXGBE_RSS_OFFLOAD_ALL) == 0) {
ixgbe_rss_disable(dev);
- return -EINVAL;
+ return 0;
}
if (rss_conf.rss_key == NULL)
rss_conf.rss_key = rss_intel_key; /* Default hash key */
--
2.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-23 20:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-23 3:38 [PATCH] net/ixgbe: fix RSS flow return error Wei Zhao
2018-10-23 6:19 ` Peng, Yuan
2018-10-23 20:36 ` Zhang, Qi Z
-- strict thread matches above, loose matches on Subject: below --
2018-10-23 3:32 Wei Zhao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.