[PATCH] media: vimc: Update device configuration in the documentation

[PATCH] media: vimc: Update device configuration in the documentation

[Dafna Hirschfeld]

Since commit 9b4a9b31b9ae ("media: vimc: Enable set resolution at the scaler src pad")
the configuration in the documentation does
not work. Replace it with the configuration
described in commit 9b4a9b31b9ae

Signed-off-by: Dafna Hirschfeld <dafna@fastmail.com>
---
 Documentation/admin-guide/media/vimc.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/admin-guide/media/vimc.rst b/Documentation/admin-guide/media/vimc.rst
index 3b4d2b36b4f3..29d843a8ddb1 100644
--- a/Documentation/admin-guide/media/vimc.rst
+++ b/Documentation/admin-guide/media/vimc.rst
@@ -35,11 +35,11 @@ of commands fits for the default topology:
 
         media-ctl -d platform:vimc -V '"Sensor A":0[fmt:SBGGR8_1X8/640x480]'
         media-ctl -d platform:vimc -V '"Debayer A":0[fmt:SBGGR8_1X8/640x480]'
-        media-ctl -d platform:vimc -V '"Sensor B":0[fmt:SBGGR8_1X8/640x480]'
-        media-ctl -d platform:vimc -V '"Debayer B":0[fmt:SBGGR8_1X8/640x480]'
-        v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=1920,height=1440
+        media-ctl -d platform:vimc -V '"Scaler":0[fmt:RGB888_1X24/640x480]'
+        media-ctl -d platform:vimc -V '"Scaler":0[crop:(100,50)/400x150]'
+        media-ctl -d platform:vimc -V '"Scaler":1[fmt:RGB888_1X24/300x700]'
+        v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=300,height=700
         v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81
-        v4l2-ctl -z platform:vimc -d "Raw Capture 1" -v pixelformat=BA81
 
 Subdevices
 ----------
-- 
2.25.1

Re: [PATCH] media: vimc: Update device configuration in the documentation

[Shuah Khan]

On 10/8/22 15:53, Dafna Hirschfeld wrote:
> Since commit 9b4a9b31b9ae ("media: vimc: Enable set resolution at the scaler src pad")
> the configuration in the documentation does
> not work. Replace it with the configuration
> described in commit 9b4a9b31b9ae
> 
> Signed-off-by: Dafna Hirschfeld <dafna@fastmail.com>
> ---
>   Documentation/admin-guide/media/vimc.rst | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/admin-guide/media/vimc.rst b/Documentation/admin-guide/media/vimc.rst
> index 3b4d2b36b4f3..29d843a8ddb1 100644
> --- a/Documentation/admin-guide/media/vimc.rst
> +++ b/Documentation/admin-guide/media/vimc.rst
> @@ -35,11 +35,11 @@ of commands fits for the default topology:
>   
>           media-ctl -d platform:vimc -V '"Sensor A":0[fmt:SBGGR8_1X8/640x480]'
>           media-ctl -d platform:vimc -V '"Debayer A":0[fmt:SBGGR8_1X8/640x480]'
> -        media-ctl -d platform:vimc -V '"Sensor B":0[fmt:SBGGR8_1X8/640x480]'
> -        media-ctl -d platform:vimc -V '"Debayer B":0[fmt:SBGGR8_1X8/640x480]'
> -        v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=1920,height=1440
> +        media-ctl -d platform:vimc -V '"Scaler":0[fmt:RGB888_1X24/640x480]'
> +        media-ctl -d platform:vimc -V '"Scaler":0[crop:(100,50)/400x150]'
> +        media-ctl -d platform:vimc -V '"Scaler":1[fmt:RGB888_1X24/300x700]'
> +        v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=300,height=700
>           v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81
> -        v4l2-ctl -z platform:vimc -d "Raw Capture 1" -v pixelformat=BA81
>   
>   Subdevices
>   ----------

Thank you - I will apply this after the merge window closes and send it in
for an upcoming 6.1 rc.

thanks,
-- Shuah