From: Michal Simek <michal.simek@xilinx.com> To: linux-kernel@vger.kernel.org, monstr@monstr.eu Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>, "Steffen Trumtrar" <s.trumtrar@pengutronix.de>, "Linus Walleij" <linus.walleij@linaro.org>, "Peter Crosthwaite" <peter.crosthwaite@xilinx.com>, linux-gpio@vger.kernel.org, "Rob Herring" <robherring2@gmail.com>, "Josh Cartwright" <josh.cartwright@ni.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 8/8] gpio: zynq: Fix driver function parameters alignment Date: Mon, 7 Aug 2017 13:02:01 +0200 [thread overview] Message-ID: <67e187a3dbc2ef8b6bacd1b173ae9e91c18aa429.1502103715.git.michal.simek@xilinx.com> (raw) In-Reply-To: <cover.1502103715.git.michal.simek@xilinx.com> In-Reply-To: <cover.1502103715.git.michal.simek@xilinx.com> Fix function parameters alignment reported by checkpatch. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/gpio/gpio-zynq.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 26653bf89e58..97b53e557c15 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -197,7 +197,7 @@ static inline void zynq_gpio_get_bank_pin(unsigned int pin_num, for (bank = 0; bank < gpio->p_data->max_bank; bank++) { if ((pin_num >= gpio->p_data->bank_min[bank]) && - (pin_num <= gpio->p_data->bank_max[bank])) { + (pin_num <= gpio->p_data->bank_max[bank])) { *bank_num = bank; *bank_pin_num = pin_num - gpio->p_data->bank_min[bank]; @@ -313,7 +313,7 @@ static int zynq_gpio_dir_in(struct gpio_chip *chip, unsigned int pin) * as inputs. */ if (zynq_gpio_is_zynq(gpio) && bank_num == 0 && - (bank_pin_num == 7 || bank_pin_num == 8)) + (bank_pin_num == 7 || bank_pin_num == 8)) return -EINVAL; /* clear the bit in direction mode reg to set the pin as input */ @@ -514,13 +514,14 @@ static int zynq_gpio_set_irq_type(struct irq_data *irq_data, unsigned int type) writel_relaxed(int_any, gpio->base_addr + ZYNQ_GPIO_INTANY_OFFSET(bank_num)); - if (type & IRQ_TYPE_LEVEL_MASK) { + if (type & IRQ_TYPE_LEVEL_MASK) irq_set_chip_handler_name_locked(irq_data, - &zynq_gpio_level_irqchip, handle_fasteoi_irq, NULL); - } else { + &zynq_gpio_level_irqchip, + handle_fasteoi_irq, NULL); + else irq_set_chip_handler_name_locked(irq_data, - &zynq_gpio_edge_irqchip, handle_level_irq, NULL); - } + &zynq_gpio_edge_irqchip, + handle_level_irq, NULL); return 0; } @@ -772,7 +773,7 @@ static void zynq_gpio_free(struct gpio_chip *chip, unsigned int offset) static const struct dev_pm_ops zynq_gpio_dev_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(zynq_gpio_suspend, zynq_gpio_resume) SET_RUNTIME_PM_OPS(zynq_gpio_runtime_suspend, - zynq_gpio_runtime_resume, NULL) + zynq_gpio_runtime_resume, NULL) }; static const struct zynq_platform_data zynqmp_gpio_def = { -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: michal.simek@xilinx.com (Michal Simek) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 8/8] gpio: zynq: Fix driver function parameters alignment Date: Mon, 7 Aug 2017 13:02:01 +0200 [thread overview] Message-ID: <67e187a3dbc2ef8b6bacd1b173ae9e91c18aa429.1502103715.git.michal.simek@xilinx.com> (raw) In-Reply-To: <cover.1502103715.git.michal.simek@xilinx.com> Fix function parameters alignment reported by checkpatch. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/gpio/gpio-zynq.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 26653bf89e58..97b53e557c15 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -197,7 +197,7 @@ static inline void zynq_gpio_get_bank_pin(unsigned int pin_num, for (bank = 0; bank < gpio->p_data->max_bank; bank++) { if ((pin_num >= gpio->p_data->bank_min[bank]) && - (pin_num <= gpio->p_data->bank_max[bank])) { + (pin_num <= gpio->p_data->bank_max[bank])) { *bank_num = bank; *bank_pin_num = pin_num - gpio->p_data->bank_min[bank]; @@ -313,7 +313,7 @@ static int zynq_gpio_dir_in(struct gpio_chip *chip, unsigned int pin) * as inputs. */ if (zynq_gpio_is_zynq(gpio) && bank_num == 0 && - (bank_pin_num == 7 || bank_pin_num == 8)) + (bank_pin_num == 7 || bank_pin_num == 8)) return -EINVAL; /* clear the bit in direction mode reg to set the pin as input */ @@ -514,13 +514,14 @@ static int zynq_gpio_set_irq_type(struct irq_data *irq_data, unsigned int type) writel_relaxed(int_any, gpio->base_addr + ZYNQ_GPIO_INTANY_OFFSET(bank_num)); - if (type & IRQ_TYPE_LEVEL_MASK) { + if (type & IRQ_TYPE_LEVEL_MASK) irq_set_chip_handler_name_locked(irq_data, - &zynq_gpio_level_irqchip, handle_fasteoi_irq, NULL); - } else { + &zynq_gpio_level_irqchip, + handle_fasteoi_irq, NULL); + else irq_set_chip_handler_name_locked(irq_data, - &zynq_gpio_edge_irqchip, handle_level_irq, NULL); - } + &zynq_gpio_edge_irqchip, + handle_level_irq, NULL); return 0; } @@ -772,7 +773,7 @@ static void zynq_gpio_free(struct gpio_chip *chip, unsigned int offset) static const struct dev_pm_ops zynq_gpio_dev_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(zynq_gpio_suspend, zynq_gpio_resume) SET_RUNTIME_PM_OPS(zynq_gpio_runtime_suspend, - zynq_gpio_runtime_resume, NULL) + zynq_gpio_runtime_resume, NULL) }; static const struct zynq_platform_data zynqmp_gpio_def = { -- 1.9.1
next prev parent reply other threads:[~2017-08-07 11:02 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-07 11:01 [PATCH 0/8] Zynq GPIO driver changes Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-07 11:01 ` [PATCH 1/8] gpio: zynq: Add support for suspend resume Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-14 13:44 ` Linus Walleij 2017-08-14 13:44 ` Linus Walleij 2017-08-07 11:01 ` [PATCH 2/8] gpio: zynq: Wakeup gpio controller when it is used as IRQ controller Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-14 13:53 ` Linus Walleij 2017-08-14 13:53 ` Linus Walleij 2017-08-14 14:33 ` Michal Simek 2017-08-14 14:33 ` Michal Simek 2017-08-22 12:57 ` Linus Walleij 2017-08-22 12:57 ` Linus Walleij 2019-01-07 15:42 ` Thomas Petazzoni 2019-01-07 15:42 ` Thomas Petazzoni 2019-01-08 13:21 ` Michal Simek 2019-01-08 13:21 ` Michal Simek 2019-01-11 9:54 ` Linus Walleij 2019-01-11 9:54 ` Linus Walleij 2019-01-11 12:54 ` Thomas Petazzoni 2019-01-11 12:54 ` Thomas Petazzoni 2019-01-11 14:37 ` Linus Walleij 2019-01-11 14:37 ` Linus Walleij 2019-01-11 14:37 ` Linus Walleij 2019-01-21 6:11 ` Shubhrajyoti Datta 2019-01-21 6:11 ` Shubhrajyoti Datta 2019-01-21 6:11 ` Shubhrajyoti Datta 2017-08-07 11:01 ` [PATCH 3/8] gpio: zynq: Shift zynq_gpio_init() to subsys_initcall level Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-14 13:55 ` Linus Walleij 2017-08-14 13:55 ` Linus Walleij 2017-08-14 14:15 ` Michal Simek 2017-08-14 14:15 ` Michal Simek 2017-08-22 13:02 ` Linus Walleij 2017-08-22 13:02 ` Linus Walleij 2017-08-07 11:01 ` [PATCH 4/8] gpio: zynq: Provided workaround for GPIO Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-14 13:57 ` Linus Walleij 2017-08-14 13:57 ` Linus Walleij 2017-08-14 14:01 ` Michal Simek 2017-08-14 14:01 ` Michal Simek 2017-08-07 11:01 ` [PATCH 5/8] gpio: zynq: Fix kernel doc warnings Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-14 13:58 ` Linus Walleij 2017-08-14 13:58 ` Linus Walleij 2017-08-07 11:01 ` [PATCH 6/8] gpio: zynq: Fix empty lines in driver Michal Simek 2017-08-07 11:01 ` Michal Simek 2017-08-14 13:59 ` Linus Walleij 2017-08-14 13:59 ` Linus Walleij 2017-08-07 11:02 ` [PATCH 7/8] gpio: zynq: Fix warnings in the driver Michal Simek 2017-08-07 11:02 ` Michal Simek 2017-08-14 14:00 ` Linus Walleij 2017-08-14 14:00 ` Linus Walleij 2017-08-07 11:02 ` Michal Simek [this message] 2017-08-07 11:02 ` [PATCH 8/8] gpio: zynq: Fix driver function parameters alignment Michal Simek 2017-08-14 14:01 ` Linus Walleij 2017-08-14 14:01 ` Linus Walleij 2017-08-14 14:03 ` Michal Simek 2017-08-14 14:03 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=67e187a3dbc2ef8b6bacd1b173ae9e91c18aa429.1502103715.git.michal.simek@xilinx.com \ --to=michal.simek@xilinx.com \ --cc=josh.cartwright@ni.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=monstr@monstr.eu \ --cc=peter.crosthwaite@xilinx.com \ --cc=robherring2@gmail.com \ --cc=s.trumtrar@pengutronix.de \ --cc=soren.brinkmann@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.