* Re: [PATCH v2 2/3] Input: adc-joystick - Add polled input device support
2022-06-01 20:49 ` [PATCH v2 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
@ 2022-06-01 22:00 ` Dmitry Torokhov
2022-06-01 22:14 ` Artur Rojek
` (2 subsequent siblings)
3 siblings, 0 replies; 13+ messages in thread
From: Dmitry Torokhov @ 2022-06-01 22:00 UTC (permalink / raw)
To: Chris Morgan, Jonathan Cameron
Cc: linux-input, devicetree, robh+dt, krzysztof.kozlowski+dt, heiko,
maccraft123mc, contact, Chris Morgan
On Wed, Jun 01, 2022 at 03:49:26PM -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add polled input device support to the adc-joystick driver. This is
> useful for devices which do not have hardware capable triggers on
> their SARADC. Code modified from adc-joystick.c changes made by Maya
> Matuszczyk.
I'd like to hear Jonathan's take on this...
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
> 1 file changed, 41 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c
> index 78ebca7d400a..5a28fe7b8ebc 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -13,6 +13,10 @@
>
> #include <asm/unaligned.h>
>
> +#define ADC_JSK_POLL_INTERVAL 16
> +#define ADC_JSK_POLL_MIN 8
> +#define ADC_JSK_POLL_MAX 32
> +
> struct adc_joystick_axis {
> u32 code;
> s32 range[2];
> @@ -26,8 +30,21 @@ struct adc_joystick {
> struct adc_joystick_axis *axes;
> struct iio_channel *chans;
> int num_chans;
> + bool polled;
> };
>
> +static void adc_joystick_poll(struct input_dev *input)
> +{
> + struct adc_joystick *joy = input_get_drvdata(input);
> + int i, val;
> +
> + for (i = 0; i < joy->num_chans; i++) {
> + iio_read_channel_raw(&joy->chans[i], &val);
> + input_report_abs(input, joy->axes[i].code, val);
> + }
> + input_sync(input);
> +}
> +
> static int adc_joystick_handle(const void *data, void *private)
> {
> struct adc_joystick *joy = private;
> @@ -215,8 +232,19 @@ static int adc_joystick_probe(struct platform_device *pdev)
> joy->input = input;
> input->name = pdev->name;
> input->id.bustype = BUS_HOST;
> - input->open = adc_joystick_open;
> - input->close = adc_joystick_close;
> +
> + if (device_property_read_bool(dev, "adc-joystick,polled"))
> + joy->polled = 1;
> +
> + if (joy->polled) {
> + input_setup_polling(input, adc_joystick_poll);
> + input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
> + input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
> + input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
> + } else {
> + input->open = adc_joystick_open;
> + input->close = adc_joystick_close;
> + }
>
> error = adc_joystick_set_axes(dev, joy);
> if (error)
> @@ -229,16 +257,18 @@ static int adc_joystick_probe(struct platform_device *pdev)
> return error;
> }
>
> - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> - if (IS_ERR(joy->buffer)) {
> - dev_err(dev, "Unable to allocate callback buffer\n");
> - return PTR_ERR(joy->buffer);
> - }
> + if (!joy->polled) {
> + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> + if (IS_ERR(joy->buffer)) {
> + dev_err(dev, "Unable to allocate callback buffer\n");
> + return PTR_ERR(joy->buffer);
> + }
>
> - error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
> - if (error) {
> - dev_err(dev, "Unable to add action\n");
> - return error;
> + error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
> + if (error) {
> + dev_err(dev, "Unable to add action\n");
> + return error;
> + }
> }
>
> return 0;
> --
> 2.25.1
>
--
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 2/3] Input: adc-joystick - Add polled input device support
2022-06-01 20:49 ` [PATCH v2 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
2022-06-01 22:00 ` Dmitry Torokhov
@ 2022-06-01 22:14 ` Artur Rojek
2022-06-02 9:22 ` Paul Cercueil
2022-06-02 11:01 ` Heiko Stübner
3 siblings, 0 replies; 13+ messages in thread
From: Artur Rojek @ 2022-06-01 22:14 UTC (permalink / raw)
To: Chris Morgan
Cc: linux-input, devicetree, dmitry.torokhov, robh+dt,
krzysztof.kozlowski+dt, heiko, maccraft123mc, Chris Morgan
On 2022-06-01 22:49, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add polled input device support to the adc-joystick driver. This is
> useful for devices which do not have hardware capable triggers on
> their SARADC. Code modified from adc-joystick.c changes made by Maya
> Matuszczyk.
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
> 1 file changed, 41 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/input/joystick/adc-joystick.c
> b/drivers/input/joystick/adc-joystick.c
> index 78ebca7d400a..5a28fe7b8ebc 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -13,6 +13,10 @@
>
> #include <asm/unaligned.h>
>
> +#define ADC_JSK_POLL_INTERVAL 16
> +#define ADC_JSK_POLL_MIN 8
> +#define ADC_JSK_POLL_MAX 32
> +
> struct adc_joystick_axis {
> u32 code;
> s32 range[2];
> @@ -26,8 +30,21 @@ struct adc_joystick {
> struct adc_joystick_axis *axes;
> struct iio_channel *chans;
> int num_chans;
> + bool polled;
> };
>
> +static void adc_joystick_poll(struct input_dev *input)
> +{
> + struct adc_joystick *joy = input_get_drvdata(input);
> + int i, val;
> +
> + for (i = 0; i < joy->num_chans; i++) {
> + iio_read_channel_raw(&joy->chans[i], &val);
> + input_report_abs(input, joy->axes[i].code, val);
> + }
> + input_sync(input);
> +}
> +
> static int adc_joystick_handle(const void *data, void *private)
> {
> struct adc_joystick *joy = private;
> @@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> joy->input = input;
> input->name = pdev->name;
> input->id.bustype = BUS_HOST;
> - input->open = adc_joystick_open;
> - input->close = adc_joystick_close;
> +
> + if (device_property_read_bool(dev, "adc-joystick,polled"))
> + joy->polled = 1;
No need for branching, you can simply do:
joy->polled = device_property_read_bool(dev, "adc-joystick,polled");
> +
> + if (joy->polled) {
> + input_setup_polling(input, adc_joystick_poll);
> + input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
> + input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
> + input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
> + } else {
> + input->open = adc_joystick_open;
> + input->close = adc_joystick_close;
> + }
>
> error = adc_joystick_set_axes(dev, joy);
> if (error)
> @@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> return error;
> }
>
> - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> - if (IS_ERR(joy->buffer)) {
> - dev_err(dev, "Unable to allocate callback buffer\n");
> - return PTR_ERR(joy->buffer);
> - }
> + if (!joy->polled) {
> + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> + if (IS_ERR(joy->buffer)) {
> + dev_err(dev, "Unable to allocate callback buffer\n");
> + return PTR_ERR(joy->buffer);
> + }
>
> - error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> joy->buffer);
> - if (error) {
> - dev_err(dev, "Unable to add action\n");
> - return error;
> + error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> joy->buffer);
> + if (error) {
> + dev_err(dev, "Unable to add action\n");
> + return error;
> + }
> }
>
> return 0;
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 2/3] Input: adc-joystick - Add polled input device support
2022-06-01 20:49 ` [PATCH v2 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
2022-06-01 22:00 ` Dmitry Torokhov
2022-06-01 22:14 ` Artur Rojek
@ 2022-06-02 9:22 ` Paul Cercueil
2022-06-19 15:17 ` Jonathan Cameron
2022-06-02 11:01 ` Heiko Stübner
3 siblings, 1 reply; 13+ messages in thread
From: Paul Cercueil @ 2022-06-02 9:22 UTC (permalink / raw)
To: Chris Morgan, Jonathan Cameron
Cc: linux-input, devicetree, dmitry.torokhov, robh+dt,
krzysztof.kozlowski+dt, heiko, maccraft123mc, contact,
Chris Morgan
Hi Chris,
Le mer., juin 1 2022 at 15:49:26 -0500, Chris Morgan
<macroalpha82@gmail.com> a écrit :
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add polled input device support to the adc-joystick driver. This is
> useful for devices which do not have hardware capable triggers on
> their SARADC. Code modified from adc-joystick.c changes made by Maya
> Matuszczyk.
I understand what you're trying to do, but maybe there's a better way.
It would be better if pollable IIO devices would also be able to be
used with a buffer, with the client driver manually triggering the IIO
device through a function call.
Jonathan (Cc'd) might have his reasons why this isn't done this way,
and in this case your patch makes sense, but I'd like to hear
Jonathan's thoughts first.
As for "adc-joystick,polled"... it doesn't describe the hardware but
rather a specific configuration, so it shouldn't appear in the device
tree.
Cheers,
-Paul
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> drivers/input/joystick/adc-joystick.c | 52
> +++++++++++++++++++++------
> 1 file changed, 41 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/input/joystick/adc-joystick.c
> b/drivers/input/joystick/adc-joystick.c
> index 78ebca7d400a..5a28fe7b8ebc 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -13,6 +13,10 @@
>
> #include <asm/unaligned.h>
>
> +#define ADC_JSK_POLL_INTERVAL 16
> +#define ADC_JSK_POLL_MIN 8
> +#define ADC_JSK_POLL_MAX 32
> +
> struct adc_joystick_axis {
> u32 code;
> s32 range[2];
> @@ -26,8 +30,21 @@ struct adc_joystick {
> struct adc_joystick_axis *axes;
> struct iio_channel *chans;
> int num_chans;
> + bool polled;
> };
>
> +static void adc_joystick_poll(struct input_dev *input)
> +{
> + struct adc_joystick *joy = input_get_drvdata(input);
> + int i, val;
> +
> + for (i = 0; i < joy->num_chans; i++) {
> + iio_read_channel_raw(&joy->chans[i], &val);
> + input_report_abs(input, joy->axes[i].code, val);
> + }
> + input_sync(input);
> +}
> +
> static int adc_joystick_handle(const void *data, void *private)
> {
> struct adc_joystick *joy = private;
> @@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> joy->input = input;
> input->name = pdev->name;
> input->id.bustype = BUS_HOST;
> - input->open = adc_joystick_open;
> - input->close = adc_joystick_close;
> +
> + if (device_property_read_bool(dev, "adc-joystick,polled"))
> + joy->polled = 1;
> +
> + if (joy->polled) {
> + input_setup_polling(input, adc_joystick_poll);
> + input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
> + input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
> + input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
> + } else {
> + input->open = adc_joystick_open;
> + input->close = adc_joystick_close;
> + }
>
> error = adc_joystick_set_axes(dev, joy);
> if (error)
> @@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> return error;
> }
>
> - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> - if (IS_ERR(joy->buffer)) {
> - dev_err(dev, "Unable to allocate callback buffer\n");
> - return PTR_ERR(joy->buffer);
> - }
> + if (!joy->polled) {
> + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
> joy);
> + if (IS_ERR(joy->buffer)) {
> + dev_err(dev, "Unable to allocate callback buffer\n");
> + return PTR_ERR(joy->buffer);
> + }
>
> - error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> joy->buffer);
> - if (error) {
> - dev_err(dev, "Unable to add action\n");
> - return error;
> + error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> joy->buffer);
> + if (error) {
> + dev_err(dev, "Unable to add action\n");
> + return error;
> + }
> }
>
> return 0;
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 2/3] Input: adc-joystick - Add polled input device support
2022-06-02 9:22 ` Paul Cercueil
@ 2022-06-19 15:17 ` Jonathan Cameron
0 siblings, 0 replies; 13+ messages in thread
From: Jonathan Cameron @ 2022-06-19 15:17 UTC (permalink / raw)
To: Paul Cercueil
Cc: Chris Morgan, linux-input, devicetree, dmitry.torokhov, robh+dt,
krzysztof.kozlowski+dt, heiko, maccraft123mc, contact,
Chris Morgan
On Thu, 02 Jun 2022 10:22:11 +0100
Paul Cercueil <paul@crapouillou.net> wrote:
> Hi Chris,
>
> Le mer., juin 1 2022 at 15:49:26 -0500, Chris Morgan
> <macroalpha82@gmail.com> a écrit :
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Add polled input device support to the adc-joystick driver. This is
> > useful for devices which do not have hardware capable triggers on
> > their SARADC. Code modified from adc-joystick.c changes made by Maya
> > Matuszczyk.
>
> I understand what you're trying to do, but maybe there's a better way.
>
> It would be better if pollable IIO devices would also be able to be
> used with a buffer, with the client driver manually triggering the IIO
> device through a function call.
We've done exactly that in the past for some of the weirder consumer
drivers. Though it's done by hooking up a trigger that is provided
by the channel consumer to the supplier device.
>
> Jonathan (Cc'd) might have his reasons why this isn't done this way,
> and in this case your patch makes sense, but I'd like to hear
> Jonathan's thoughts first.
It rarely makes sense to have a sysfs only ADC and it's usually trivial
to add basic support for buffered mode to use with a trigger from elsewhere.
It's rare that their aren't optimizations around batching etc that
make sense though in this path and not the sysfs polling path where only
one channel is being read. Hence it's not worth a generic route to
hooking them together.
>
> As for "adc-joystick,polled"... it doesn't describe the hardware but
> rather a specific configuration, so it shouldn't appear in the device
> tree.
Sorry, got lost in my email.
I'll take a look at v3.
Jonathan
>
> Cheers,
> -Paul
>
> >
> > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> > drivers/input/joystick/adc-joystick.c | 52
> > +++++++++++++++++++++------
> > 1 file changed, 41 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/input/joystick/adc-joystick.c
> > b/drivers/input/joystick/adc-joystick.c
> > index 78ebca7d400a..5a28fe7b8ebc 100644
> > --- a/drivers/input/joystick/adc-joystick.c
> > +++ b/drivers/input/joystick/adc-joystick.c
> > @@ -13,6 +13,10 @@
> >
> > #include <asm/unaligned.h>
> >
> > +#define ADC_JSK_POLL_INTERVAL 16
> > +#define ADC_JSK_POLL_MIN 8
> > +#define ADC_JSK_POLL_MAX 32
> > +
> > struct adc_joystick_axis {
> > u32 code;
> > s32 range[2];
> > @@ -26,8 +30,21 @@ struct adc_joystick {
> > struct adc_joystick_axis *axes;
> > struct iio_channel *chans;
> > int num_chans;
> > + bool polled;
> > };
> >
> > +static void adc_joystick_poll(struct input_dev *input)
> > +{
> > + struct adc_joystick *joy = input_get_drvdata(input);
> > + int i, val;
> > +
> > + for (i = 0; i < joy->num_chans; i++) {
> > + iio_read_channel_raw(&joy->chans[i], &val);
> > + input_report_abs(input, joy->axes[i].code, val);
> > + }
> > + input_sync(input);
> > +}
> > +
> > static int adc_joystick_handle(const void *data, void *private)
> > {
> > struct adc_joystick *joy = private;
> > @@ -215,8 +232,19 @@ static int adc_joystick_probe(struct
> > platform_device *pdev)
> > joy->input = input;
> > input->name = pdev->name;
> > input->id.bustype = BUS_HOST;
> > - input->open = adc_joystick_open;
> > - input->close = adc_joystick_close;
> > +
> > + if (device_property_read_bool(dev, "adc-joystick,polled"))
> > + joy->polled = 1;
> > +
> > + if (joy->polled) {
> > + input_setup_polling(input, adc_joystick_poll);
> > + input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
> > + input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
> > + input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
> > + } else {
> > + input->open = adc_joystick_open;
> > + input->close = adc_joystick_close;
> > + }
> >
> > error = adc_joystick_set_axes(dev, joy);
> > if (error)
> > @@ -229,16 +257,18 @@ static int adc_joystick_probe(struct
> > platform_device *pdev)
> > return error;
> > }
> >
> > - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> > - if (IS_ERR(joy->buffer)) {
> > - dev_err(dev, "Unable to allocate callback buffer\n");
> > - return PTR_ERR(joy->buffer);
> > - }
> > + if (!joy->polled) {
> > + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
> > joy);
> > + if (IS_ERR(joy->buffer)) {
> > + dev_err(dev, "Unable to allocate callback buffer\n");
> > + return PTR_ERR(joy->buffer);
> > + }
> >
> > - error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> > joy->buffer);
> > - if (error) {
> > - dev_err(dev, "Unable to add action\n");
> > - return error;
> > + error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> > joy->buffer);
> > + if (error) {
> > + dev_err(dev, "Unable to add action\n");
> > + return error;
> > + }
> > }
> >
> > return 0;
>
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v2 2/3] Input: adc-joystick - Add polled input device support
2022-06-01 20:49 ` [PATCH v2 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
` (2 preceding siblings ...)
2022-06-02 9:22 ` Paul Cercueil
@ 2022-06-02 11:01 ` Heiko Stübner
3 siblings, 0 replies; 13+ messages in thread
From: Heiko Stübner @ 2022-06-02 11:01 UTC (permalink / raw)
To: linux-input, Chris Morgan
Cc: devicetree, dmitry.torokhov, robh+dt, krzysztof.kozlowski+dt,
maccraft123mc, contact, Chris Morgan
Am Mittwoch, 1. Juni 2022, 22:49:26 CEST schrieb Chris Morgan:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add polled input device support to the adc-joystick driver. This is
> useful for devices which do not have hardware capable triggers on
> their SARADC. Code modified from adc-joystick.c changes made by Maya
> Matuszczyk.
as the dts patch mentiones the odroid go2, this probably means the
Rockchip-saradc?
I very much remember that we converted the saradc to also support
triggered buffers [0] two years ago, and as I remember that worked
rather nicely on the Go-1 at least - similar hardware I think.
So it would be really helpful to provide some more explanation on
why this isn't enough for your use-case.
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4e130dc7b41348b13684f0758c26cc6cf72a3449
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> drivers/input/joystick/adc-joystick.c | 52 +++++++++++++++++++++------
> 1 file changed, 41 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/input/joystick/adc-joystick.c b/drivers/input/joystick/adc-joystick.c
> index 78ebca7d400a..5a28fe7b8ebc 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -13,6 +13,10 @@
>
> #include <asm/unaligned.h>
>
> +#define ADC_JSK_POLL_INTERVAL 16
> +#define ADC_JSK_POLL_MIN 8
> +#define ADC_JSK_POLL_MAX 32
> +
> struct adc_joystick_axis {
> u32 code;
> s32 range[2];
> @@ -26,8 +30,21 @@ struct adc_joystick {
> struct adc_joystick_axis *axes;
> struct iio_channel *chans;
> int num_chans;
> + bool polled;
> };
>
> +static void adc_joystick_poll(struct input_dev *input)
> +{
> + struct adc_joystick *joy = input_get_drvdata(input);
> + int i, val;
> +
> + for (i = 0; i < joy->num_chans; i++) {
> + iio_read_channel_raw(&joy->chans[i], &val);
> + input_report_abs(input, joy->axes[i].code, val);
> + }
> + input_sync(input);
> +}
> +
> static int adc_joystick_handle(const void *data, void *private)
> {
> struct adc_joystick *joy = private;
> @@ -215,8 +232,19 @@ static int adc_joystick_probe(struct platform_device *pdev)
> joy->input = input;
> input->name = pdev->name;
> input->id.bustype = BUS_HOST;
> - input->open = adc_joystick_open;
> - input->close = adc_joystick_close;
> +
> + if (device_property_read_bool(dev, "adc-joystick,polled"))
> + joy->polled = 1;
> +
> + if (joy->polled) {
> + input_setup_polling(input, adc_joystick_poll);
> + input_set_poll_interval(input, ADC_JSK_POLL_INTERVAL);
> + input_set_min_poll_interval(input, ADC_JSK_POLL_MIN);
> + input_set_max_poll_interval(input, ADC_JSK_POLL_MAX);
> + } else {
> + input->open = adc_joystick_open;
> + input->close = adc_joystick_close;
> + }
>
> error = adc_joystick_set_axes(dev, joy);
> if (error)
> @@ -229,16 +257,18 @@ static int adc_joystick_probe(struct platform_device *pdev)
> return error;
> }
>
> - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> - if (IS_ERR(joy->buffer)) {
> - dev_err(dev, "Unable to allocate callback buffer\n");
> - return PTR_ERR(joy->buffer);
> - }
> + if (!joy->polled) {
> + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> + if (IS_ERR(joy->buffer)) {
> + dev_err(dev, "Unable to allocate callback buffer\n");
> + return PTR_ERR(joy->buffer);
> + }
>
> - error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
> - if (error) {
> - dev_err(dev, "Unable to add action\n");
> - return error;
> + error = devm_add_action_or_reset(dev, adc_joystick_cleanup, joy->buffer);
> + if (error) {
> + dev_err(dev, "Unable to add action\n");
> + return error;
> + }
> }
>
> return 0;
>
^ permalink raw reply [flat|nested] 13+ messages in thread