All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
	Navid Emamdoost <navid.emamdoost@gmail.com>,
	netdev@vger.kernel.org, oss-drivers@netronome.com
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Stephen A McCamant <smccaman@umn.edu>,
	Colin Ian King <colin.king@canonical.com>,
	"David S. Miller" <davem@davemloft.net>,
	John Hurley <john.hurley@netronome.com>,
	Pablo Neira <pablo@netfilter.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: nfp: abm: fix memory leak in nfp_abm_u32_knode_replace
Date: Sat, 28 Sep 2019 07:55:38 +0200	[thread overview]
Message-ID: <6854393f-8222-3077-1ff8-8be6b07d4862@web.de> (raw)
In-Reply-To: <20190927144242.7e0d8fde@cakuba.netronome.com>

>> Can such a change variant be a bit nicer?
>
> Definitely not.
>
> Looks good as is, thanks Navid!

I find it interesting how the software development opinions are different
also in this use case for the implementation of correct and efficient
exception handling.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=f1f2f614d535564992f32e720739cb53cf03489f#n450

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
	Navid Emamdoost <navid.emamdoost@gmail.com>,
	netdev@vger.kernel.org, oss-drivers@netronome.com
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Stephen A McCamant <smccaman@umn.edu>,
	Colin Ian King <colin.king@canonical.com>,
	"David S. Miller" <davem@davemloft.net>,
	John Hurley <john.hurley@netronome.com>,
	Pablo Neira <pablo@netfilter.org>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: nfp: abm: fix memory leak in nfp_abm_u32_knode_replace
Date: Sat, 28 Sep 2019 05:55:38 +0000	[thread overview]
Message-ID: <6854393f-8222-3077-1ff8-8be6b07d4862@web.de> (raw)
In-Reply-To: <20190927144242.7e0d8fde@cakuba.netronome.com>

>> Can such a change variant be a bit nicer?
>
> Definitely not.
>
> Looks good as is, thanks Navid!

I find it interesting how the software development opinions are different
also in this use case for the implementation of correct and efficient
exception handling.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=f1f2f614d535564992f32e720739cb53cf03489f#n450

Regards,
Markus

  reply	other threads:[~2019-09-28  5:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 18:34 [PATCH] net: flow_offload: fix memory leak in nfp_abm_u32_knode_replace Navid Emamdoost
2019-09-26  1:28 ` Jakub Kicinski
2019-09-26  2:22   ` [PATCH v2] " Navid Emamdoost
2019-09-26  4:53     ` Jakub Kicinski
2019-09-27  1:51       ` [PATCH v3] nfp: abm: " Navid Emamdoost
2019-09-27 12:12         ` Markus Elfring
2019-09-27 12:12           ` Markus Elfring
2019-09-27 21:42           ` Jakub Kicinski
2019-09-27 21:42             ` Jakub Kicinski
2019-09-28  5:55             ` Markus Elfring [this message]
2019-09-28  5:55               ` Markus Elfring
2019-09-27 18:56         ` [PATCH v3] " David Miller
2019-12-04 18:39         ` Jakub Kicinski
2019-09-27  2:26       ` [PATCH v2] net: flow_offload: " Navid Emamdoost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6854393f-8222-3077-1ff8-8be6b07d4862@web.de \
    --to=markus.elfring@web.de \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=emamd001@umn.edu \
    --cc=jakub.kicinski@netronome.com \
    --cc=john.hurley@netronome.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navid.emamdoost@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=pablo@netfilter.org \
    --cc=smccaman@umn.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.